Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-06-25 22:04:15 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Changing the MIPS DRC to not use static char buffers when disassembling

Browse Source
This commit is contained in:
Nathan Woods 2016-11-20 10:18:13 -05:00
parent 7b8128fef5
commit c65cdadcbf
2 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/devices/cpu/mips/mips3.h
View File

@ -771,7 +771,6 @@ private:
***************************************************************************/ ***************************************************************************/
unsigned dasmmips3(std::ostream &stream, unsigned pc, uint32_t op); unsigned dasmmips3(std::ostream &stream, unsigned pc, uint32_t op);
unsigned dasmmips3(char *buffer, unsigned pc, uint32_t op);
#endif /* __MIPS3_H__ */ #endif /* __MIPS3_H__ */

17
src/devices/cpu/mips/mips3drc.cpp
View File

@ -3947,9 +3947,10 @@ void mips3_device::log_add_disasm_comment(drcuml_block *block, uint32_t pc, uint
{ {
if (m_drcuml->logging()) if (m_drcuml->logging())
{ {
char buffer[100]; std::ostringstream stream;
dasmmips3(buffer, pc, op); dasmmips3(stream, pc, op);
block->append_comment("%08X: %s", pc, buffer); // comment const std::string stream_string = stream.str();
block->append_comment("%08X: %s", pc, stream_string.c_str()); // comment
} }
} }
@ -4077,19 +4078,21 @@ void mips3_device::log_opcode_desc(drcuml_state *drcuml, const opcode_desc *desc
/* output each descriptor */ /* output each descriptor */
for ( ; desclist != nullptr; desclist = desclist->next()) for ( ; desclist != nullptr; desclist = desclist->next())
{ {
char buffer[100]; std::ostringstream buffer;
/* disassemle the current instruction and output it to the log */ /* disassemle the current instruction and output it to the log */
if (drcuml->logging() || drcuml->logging_native()) if (drcuml->logging() || drcuml->logging_native())
{ {
if (desclist->flags & OPFLAG_VIRTUAL_NOOP) if (desclist->flags & OPFLAG_VIRTUAL_NOOP)
strcpy(buffer, "<virtual nop>"); buffer << "<virtual nop>";
else else
dasmmips3(buffer, desclist->pc, desclist->opptr.l[0]); dasmmips3(buffer, desclist->pc, desclist->opptr.l[0]);
} }
else else
strcpy(buffer, "???"); buffer << "???";
drcuml->log_printf("%08X [%08X] t:%08X f:%s: %-30s", desclist->pc, desclist->physpc, desclist->targetpc, log_desc_flags_to_string(desclist->flags), buffer);
const std::string buffer_string = buffer.str();
drcuml->log_printf("%08X [%08X] t:%08X f:%s: %-30s", desclist->pc, desclist->physpc, desclist->targetpc, log_desc_flags_to_string(desclist->flags), buffer_string.c_str());
/* output register states */ /* output register states */
log_register_list(drcuml, "use", desclist->regin, nullptr); log_register_list(drcuml, "use", desclist->regin, nullptr);