Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-07-01 08:18:59 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

osdcore: fix buffer overflow with osd_output stack

Browse Source
This commit is contained in:
hap 2021-10-30 21:28:11 +02:00
parent cee44b0414
commit c6993affc6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/osd/osdcore.cpp
View File

@ -26,7 +26,7 @@ static int m_ptr = -1;
void osd_output::push(osd_output *delegate) void osd_output::push(osd_output *delegate)
{ {
if (m_ptr < MAXSTACK) if (m_ptr < MAXSTACK - 1)
{ {
delegate->m_chain = (m_ptr >= 0 ? m_stack[m_ptr] : nullptr); delegate->m_chain = (m_ptr >= 0 ? m_stack[m_ptr] : nullptr);
m_ptr++; m_ptr++;
@ -37,7 +37,7 @@ void osd_output::push(osd_output *delegate)
void osd_output::pop(osd_output *delegate) void osd_output::pop(osd_output *delegate)
{ {
int f = -1; int f = -1;
for (int i=0; i<=m_ptr; i++) for (int i = 0; i <= m_ptr; i++)
if (m_stack[i] == delegate) if (m_stack[i] == delegate)
{ {
f = i; f = i;