Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-23 08:49:55 +03:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

c140.cpp : Remove unnecessary arguments in handlers

Browse Source 
namcona1.cpp : Remove unnecessary handler, Add note
This commit is contained in:
cam900 2019-02-03 18:22:21 +09:00
parent b4aa8fdc10
commit c794900f6f
4 changed files with 7 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/devices/sound/c140.cpp
View File

@ -374,14 +374,14 @@ void c140_device::sound_stream_update(sound_stream &stream, stream_sample_t **in
}
READ8_MEMBER( c140_device::c140_r )
u8 c140_device::c140_r(offs_t offset)
{
offset&=0x1ff;
return m_REG[offset];
}
WRITE8_MEMBER( c140_device::c140_w )
void c140_device::c140_w(offs_t offset, u8 data)
{
m_stream->update();

4
src/devices/sound/c140.h
View File

@ -32,8 +32,8 @@ public:
// configuration
void set_bank_type(C140_TYPE bank) { m_banking_type = bank; }
DECLARE_READ8_MEMBER( c140_r );
DECLARE_WRITE8_MEMBER( c140_w );
u8 c140_r(offs_t offset);
void c140_w(offs_t offset, u8 data);
protected:
// device-level overrides

24
src/mame/drivers/namcona1.cpp
View File

@ -622,30 +622,12 @@ WRITE16_MEMBER(namcona1_state::na1mcu_shared_w)
COMBINE_DATA(&m_workram[offset]);
}
READ16_MEMBER(namcona1_state::snd_r)
{
/* can't use DEVREADWRITE8 for this because it is opposite endianness to the CPU for some reason */
return m_c140->c140_r(space,offset*2+1) | m_c140->c140_r(space,offset*2)<<8;
}
WRITE16_MEMBER(namcona1_state::snd_w)
{
/* can't use DEVREADWRITE8 for this because it is opposite endianness to the CPU for some reason */
if (ACCESSING_BITS_0_7)
{
m_c140->c140_w(space,(offset*2)+1, data);
}
if (ACCESSING_BITS_8_15)
{
m_c140->c140_w(space,(offset*2), data>>8);
}
}
void namcona1_state::namcona1_mcu_map(address_map &map)
{
map(0x000800, 0x000fff).rw(FUNC(namcona1_state::mcu_mailbox_r), FUNC(namcona1_state::mcu_mailbox_w_mcu)); // "Mailslot" communications ports
map(0x001000, 0x001fff).rw(FUNC(namcona1_state::snd_r), FUNC(namcona1_state::snd_w)); // C140-alike sound chip
map(0x001000, 0x001fff).lrw8("c219_rw",
[this](offs_t offset) { return m_c140->c140_r(offset ^ 1)/* need ^ 1 because endian issue */; },
[this](offs_t offset, u8 data) { m_c140->c140_w(offset ^ 1, data); }); // C140-alike sound chip
map(0x002000, 0x002fff).rw(FUNC(namcona1_state::na1mcu_shared_r), FUNC(namcona1_state::na1mcu_shared_w)); // mirror of first page of shared work RAM
map(0x003000, 0x00afff).ram(); // there is a 32k RAM chip according to CGFM
map(0x200000, 0x27ffff).rw(FUNC(namcona1_state::na1mcu_shared_r), FUNC(namcona1_state::na1mcu_shared_w)); // shared work RAM

2
src/mame/includes/namcona1.h
View File

@ -83,8 +83,6 @@ protected:
DECLARE_WRITE16_MEMBER(paletteram_w);
DECLARE_READ16_MEMBER(gfxram_r);
DECLARE_WRITE16_MEMBER(gfxram_w);
DECLARE_READ16_MEMBER(snd_r);
DECLARE_WRITE16_MEMBER(snd_w);
virtual void device_timer(emu_timer &timer, device_timer_id id, int param, void *ptr) override;
uint32_t screen_update(screen_device &screen, bitmap_ind16 &bitmap, const rectangle &cliprect);