Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-23 00:39:36 +03:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

netlist: Remove "extended validation mode"

Browse Source 
* No longer added value.
This commit is contained in:
couriersud 2020-09-28 22:00:16 +02:00
parent 0ba5d9f342
commit c93702f9a3
7 changed files with 7 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/devices/machine/netlist.cpp
View File

@ -987,7 +987,6 @@ std::unique_ptr<netlist::netlist_state_t> netlist_mame_device::base_validity_che
auto lnetlist = std::make_unique<netlist::netlist_state_t>("netlist",
plib::plog_delegate(&validity_logger::log, &logger));
// enable validation mode
lnetlist->set_extended_validation(true);
lnetlist->set_static_solver_lib(std::make_unique<plib::dynlib_static>(nullptr));

22
src/lib/netlist/core/netlist_state.h
View File

@ -217,24 +217,6 @@ namespace netlist
device_arena &pool() noexcept { return m_pool; }
const device_arena &pool() const noexcept { return m_pool; }
/// \brief set extended validation mode.
///
/// The extended validation mode is not intended for running.
/// The intention is to identify power pins which are not properly
/// connected. The downside is that this mode creates a netlist which
/// is different (and not able to run).
///
/// Extended validation is supported by nltool validate option.
///
/// \param val Boolean value enabling/disabling extended validation mode
void set_extended_validation(bool val) { m_extended_validation = val; }
/// \brief State of extended validation mode.
///
/// \returns boolean value indicating if extended validation mode is
/// turned on.
bool is_extended_validation() const { return m_extended_validation; }
struct stats_info
{
const detail::queue_t &m_queue;// performance
@ -263,7 +245,7 @@ namespace netlist
plib::state_manager_t m_state;
log_type m_log;
// FIXME: should only be available during device construcion
// FIXME: should only be available during device construction
host_arena::unique_ptr<setup_t> m_setup;
nets_collection_type m_nets;
@ -271,8 +253,6 @@ namespace netlist
devices_collection_type m_devices;
// sole use is to manage lifetime of family objects
family_collection_type m_family_cache;
bool m_extended_validation;
// dummy version
int m_dummy_version;
};

16
src/lib/netlist/devices/nlid_proxy.cpp
View File

@ -124,19 +124,9 @@ namespace netlist
{
register_subalias("Q", "RN.1");
log().verbose("D/A Proxy: Found power terminals on device {1}", out_proxied->device().name());
if (anetlist.is_extended_validation())
{
// During validation, don't connect to terminals found
// This will cause terminals not connected to a rail net to
// fail connection stage.
connect(m_RN.N(), m_RP.P());
}
else
{
connect(m_RN.N(), *m_tn);
connect(m_RP.P(), *m_tp);
}
connect(m_RN.N(), *m_tn);
connect(m_RP.P(), *m_tp);
connect(m_RN.P(), m_RP.N());
}

1
src/lib/netlist/nl_base.cpp
View File

@ -106,7 +106,6 @@ namespace netlist
netlist_state_t::netlist_state_t(const pstring &name,
plib::plog_delegate logger)
: m_log(logger)
, m_extended_validation(false)
, m_dummy_version(1)
{
m_setup = plib::make_unique<setup_t, host_arena>(*this);

2
src/lib/netlist/nl_setup.cpp
View File

@ -9,6 +9,7 @@
#include "nl_factory.h"
#include "nl_parser.h"
#include "nl_setup.h"
#include "nl_errstr.h"
#include "plib/penum.h"
#include "plib/pstonum.h"
#include "plib/pstrutil.h"
@ -1192,6 +1193,7 @@ void setup_t::resolve_inputs()
log().warning(MW_TERMINAL_1_WITHOUT_CONNECTIONS(name_da));
}
}
log().verbose("checking tristate consistency ...");
for (auto & i : m_terminals)
{

4
src/lib/netlist/prg/nltool.cpp
View File

@ -82,7 +82,6 @@ public:
opt_type(*this, "y", "type", 0, std::vector<pstring>({"spice","eagle","rinf"}), "type of file to be converted: spice,eagle,rinf"),
opt_grp6(*this, "Options for validate command", "These options are only used by the validate command."),
opt_extended_validation(*this, "", "extended", "Identify issues with power terminals."),
opt_grp7(*this, "Options for header command", "These options are only used by the header command."),
opt_tabwidth(*this, "", "tab-width", 4, "Tab width for output."),
@ -153,7 +152,6 @@ private:
plib::option_str_limit<unsigned> opt_type;
plib::option_group opt_grp6;
plib::option_bool opt_extended_validation;
plib::option_group opt_grp7;
plib::option_num<unsigned> opt_tabwidth;
plib::option_num<unsigned> opt_linewidth;
@ -548,8 +546,6 @@ void tool_app_t::validate()
m_errors = 0;
m_warnings = 0;
nt.set_extended_validation(opt_extended_validation());
try
{
nt.read_netlist(opt_files()[0], opt_name(),

5
src/lib/netlist/solver/nld_ms_gcr.h
View File

@ -93,10 +93,7 @@ namespace solver
// FIXME: Move me
//
// During extended validation there is no reason to check for
// differences in the generated code since during
// extended validation this will be different (and non-functional)
if (!this->state().is_extended_validation() && this->state().static_solver_lib().isLoaded())
if (this->state().static_solver_lib().isLoaded())
{
pstring symname = static_compile_name();
m_proc.load(this->state().static_solver_lib(), symname);