Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-06-03 19:36:26 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

(MESS) astrocde: installing expansion handlers only if a slot card is

Browse Source 
present avoids the appearance of gfx garbage at start. garbage
disappeared when pressing reset, but it is better in this way, of course.
nw.
This commit is contained in:
etabeta78 2014-10-29 07:13:14 +01:00
parent b52ecd0d47
commit ca67460d24
3 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/emu/bus/astrocde/exp.c
View File

@ -37,7 +37,8 @@ device_astrocade_card_interface::~device_astrocade_card_interface()
//-------------------------------------------------
astrocade_exp_device::astrocade_exp_device(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock) :
device_t(mconfig, ASTROCADE_EXP_SLOT, "Bally Astrocade expansion", tag, owner, clock, "astrocde_exp", __FILE__),
device_slot_interface(mconfig, *this)
device_slot_interface(mconfig, *this),
m_card_mounted(false)
{
}
@ -57,6 +58,8 @@ astrocade_exp_device::~astrocade_exp_device()
void astrocade_exp_device::device_start()
{
m_card = dynamic_cast<device_astrocade_card_interface *>(get_card_device());
if (m_card)
m_card_mounted = true;
}
/*-------------------------------------------------

6
src/emu/bus/astrocde/exp.h
View File

@ -13,7 +13,7 @@ public:
virtual ~device_astrocade_card_interface();
// reading and writing
virtual DECLARE_READ8_MEMBER(read) { return 0; }
virtual DECLARE_READ8_MEMBER(read) { return 0xff; }
virtual DECLARE_WRITE8_MEMBER(write) {}
protected:
@ -33,12 +33,14 @@ public:
// device-level overrides
virtual void device_start();
bool get_card_mounted() { return m_card_mounted; }
// reading and writing
virtual DECLARE_READ8_MEMBER(read);
virtual DECLARE_WRITE8_MEMBER(write);
protected:
bool m_card_mounted;
device_astrocade_card_interface* m_card;
};

11
src/mess/drivers/astrocde.c
View File

@ -22,10 +22,12 @@ class astrocde_mess_state : public astrocde_state
public:
astrocde_mess_state(const machine_config &mconfig, device_type type, const char *tag)
: astrocde_state(mconfig, type, tag),
m_cart(*this, "cartslot")
m_cart(*this, "cartslot"),
m_exp(*this, "exp")
{ }
required_device<astrocade_cart_slot_device> m_cart;
required_device<astrocade_exp_device> m_exp;
DECLARE_MACHINE_START(astrocde);
};
@ -47,7 +49,7 @@ static ADDRESS_MAP_START( astrocade_mem, AS_PROGRAM, 8, astrocde_mess_state )
AM_RANGE(0x0000, 0x0fff) AM_ROM AM_WRITE(astrocade_funcgen_w)
AM_RANGE(0x1000, 0x3fff) AM_ROM /* Star Fortress writes in here?? */
AM_RANGE(0x4000, 0x4fff) AM_RAM AM_SHARE("videoram") /* ASG */
AM_RANGE(0x5000, 0xffff) AM_DEVREADWRITE("exp", astrocade_exp_device, read, write)
//AM_RANGE(0x5000, 0xffff) AM_DEVREADWRITE("exp", astrocade_exp_device, read, write)
ADDRESS_MAP_END
@ -252,6 +254,11 @@ MACHINE_START_MEMBER(astrocde_mess_state, astrocde)
{
if (m_cart->exists())
m_maincpu->space(AS_PROGRAM).install_read_handler(0x2000, 0x3fff, read8_delegate(FUNC(astrocade_cart_slot_device::read_rom),(astrocade_cart_slot_device*)m_cart));
// if no RAM is mounted and the handlers are installed, the system starts with garbage on screen and a RESET is necessary
// thus, install RAM only if an expansion is mounted
if (m_exp->get_card_mounted())
m_maincpu->space(AS_PROGRAM).install_readwrite_handler(0x5000, 0xffff, read8_delegate(FUNC(astrocade_exp_device::read),(astrocade_exp_device*)m_exp), write8_delegate(FUNC(astrocade_exp_device::write),(astrocade_exp_device*)m_exp));
}
/*************************************