Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-05-13 17:38:21 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Haha, recent change to astrings also revealed that validity checks

Browse Source 
were busted for ROM_FILL/ROM_COPY (we didn't detect regions populated
this way were non-empty).
This commit is contained in:
Aaron Giles 2010-08-21 19:37:32 +00:00
parent 4d1fc8fafa
commit d5d2cd0bb9
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/emu/validity.c
View File

@ -492,23 +492,22 @@ static bool validate_roms(int drivnum, const machine_config *config, region_arra
else else
{ {
astring fulltag; astring fulltag;
int rgnnum;
/* iterate over all regions found so far */ /* iterate over all regions found so far */
rom_region_name(fulltag, driver, source, romp); rom_region_name(fulltag, driver, source, romp);
for (rgnnum = 0; rgnnum < ARRAY_LENGTH(rgninfo->entries); rgnnum++) for (int rgnnum = 0; rgnnum < ARRAY_LENGTH(rgninfo->entries); rgnnum++)
{ {
/* stop when we hit an empty */ /* stop when we hit an empty */
if (!rgninfo->entries[rgnnum].tag) if (!rgninfo->entries[rgnnum].tag)
{ {
currgn = &rgninfo->entries[rgnnum]; currgn = &rgninfo->entries[rgnnum];
currgn->tag.cpy(fulltag); currgn->tag = fulltag;
currgn->length = ROMREGION_GETLENGTH(romp); currgn->length = ROMREGION_GETLENGTH(romp);
break; break;
} }
/* fail if we hit a duplicate */ /* fail if we hit a duplicate */
if (fulltag.cmp(rgninfo->entries[rgnnum].tag) == 0) if (fulltag == rgninfo->entries[rgnnum].tag)
{ {
mame_printf_error("%s: %s has duplicate ROM_REGION tag '%s'\n", driver->source_file, driver->name, fulltag.cstr()); mame_printf_error("%s: %s has duplicate ROM_REGION tag '%s'\n", driver->source_file, driver->name, fulltag.cstr());
error = true; error = true;
@ -564,6 +563,10 @@ static bool validate_roms(int drivnum, const machine_config *config, region_arra
} }
} }
// count copies/fills as valid items
else if (ROMENTRY_ISCOPY(romp) || ROMENTRY_ISFILL(romp))
items_since_region++;
/* for any non-region ending entries, make sure they don't extend past the end */ /* for any non-region ending entries, make sure they don't extend past the end */
if (!ROMENTRY_ISREGIONEND(romp) && currgn != NULL) if (!ROMENTRY_ISREGIONEND(romp) && currgn != NULL)
{ {
@ -658,7 +661,7 @@ static bool validate_gfx(int drivnum, const machine_config *config, region_array
} }
/* if we hit a match, check against the length */ /* if we hit a match, check against the length */
if (rgninfo->entries[rgnnum].tag.cmp(region) == 0) if (rgninfo->entries[rgnnum].tag == region)
{ {
/* if we have a valid region, and we're not using auto-sizing, check the decode against the region length */ /* if we have a valid region, and we're not using auto-sizing, check the decode against the region length */
if (!IS_FRAC(total)) if (!IS_FRAC(total))