Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-06-08 22:03:55 +03:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Added commit command to debugger. [Angelo Salese]

Browse Source
This commit is contained in:
angelosa 2016-06-05 15:30:26 +02:00
parent 3a30f52296
commit ea46245a9a
2 changed files with 39 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/emu/debug/debugcmd.cpp
View File

@ -112,10 +112,11 @@ static void execute_focus(running_machine &machine, int ref, int params, const c
static void execute_ignore(running_machine &machine, int ref, int params, const char **param); static void execute_ignore(running_machine &machine, int ref, int params, const char **param);
static void execute_observe(running_machine &machine, int ref, int params, const char **param); static void execute_observe(running_machine &machine, int ref, int params, const char **param);
static void execute_next(running_machine &machine, int ref, int params, const char **param); static void execute_next(running_machine &machine, int ref, int params, const char **param);
static void execute_comment(running_machine &machine, int ref, int params, const char **param); static void execute_comment_add(running_machine &machine, int ref, int params, const char **param);
static void execute_comment_del(running_machine &machine, int ref, int params, const char **param); static void execute_comment_del(running_machine &machine, int ref, int params, const char **param);
static void execute_comment_save(running_machine &machine, int ref, int params, const char **param); static void execute_comment_save(running_machine &machine, int ref, int params, const char **param);
static void execute_comment_list(running_machine &machine, int ref, int params, const char **param); static void execute_comment_list(running_machine &machine, int ref, int params, const char **param);
static void execute_comment_commit(running_machine &machine, int ref, int params, const char **param);
static void execute_bpset(running_machine &machine, int ref, int params, const char **param); static void execute_bpset(running_machine &machine, int ref, int params, const char **param);
static void execute_bpclear(running_machine &machine, int ref, int params, const char **param); static void execute_bpclear(running_machine &machine, int ref, int params, const char **param);
static void execute_bpdisenable(running_machine &machine, int ref, int params, const char **param); static void execute_bpdisenable(running_machine &machine, int ref, int params, const char **param);
@ -296,11 +297,13 @@ void debug_command_init(running_machine &machine)
debug_console_register_command(machine, "ignore", CMDFLAG_NONE, 0, 0, MAX_COMMAND_PARAMS, execute_ignore); debug_console_register_command(machine, "ignore", CMDFLAG_NONE, 0, 0, MAX_COMMAND_PARAMS, execute_ignore);
debug_console_register_command(machine, "observe", CMDFLAG_NONE, 0, 0, MAX_COMMAND_PARAMS, execute_observe); debug_console_register_command(machine, "observe", CMDFLAG_NONE, 0, 0, MAX_COMMAND_PARAMS, execute_observe);
debug_console_register_command(machine, "comadd", CMDFLAG_NONE, 0, 1, 2, execute_comment); debug_console_register_command(machine, "comadd", CMDFLAG_NONE, 0, 1, 2, execute_comment_add);
debug_console_register_command(machine, "//", CMDFLAG_NONE, 0, 1, 2, execute_comment); debug_console_register_command(machine, "//", CMDFLAG_NONE, 0, 1, 2, execute_comment_add);
debug_console_register_command(machine, "comdelete", CMDFLAG_NONE, 0, 1, 1, execute_comment_del); debug_console_register_command(machine, "comdelete", CMDFLAG_NONE, 0, 1, 1, execute_comment_del);
debug_console_register_command(machine, "comsave", CMDFLAG_NONE, 0, 0, 0, execute_comment_save); debug_console_register_command(machine, "comsave", CMDFLAG_NONE, 0, 0, 0, execute_comment_save);
debug_console_register_command(machine, "comlist", CMDFLAG_NONE, 0, 0, 0, execute_comment_list); debug_console_register_command(machine, "comlist", CMDFLAG_NONE, 0, 0, 0, execute_comment_list);
debug_console_register_command(machine, "commit", CMDFLAG_NONE, 0, 1, 2, execute_comment_commit);
debug_console_register_command(machine, "/*", CMDFLAG_NONE, 0, 1, 2, execute_comment_commit);
debug_console_register_command(machine, "bpset", CMDFLAG_NONE, 0, 1, 3, execute_bpset); debug_console_register_command(machine, "bpset", CMDFLAG_NONE, 0, 1, 3, execute_bpset);
debug_console_register_command(machine, "bp", CMDFLAG_NONE, 0, 1, 3, execute_bpset); debug_console_register_command(machine, "bp", CMDFLAG_NONE, 0, 1, 3, execute_bpset);
@ -1130,7 +1133,7 @@ static void execute_observe(running_machine &machine, int ref, int params, const
execute_comment - add a comment to a line execute_comment - add a comment to a line
-------------------------------------------------*/ -------------------------------------------------*/
static void execute_comment(running_machine &machine, int ref, int params, const char *param[]) static void execute_comment_add(running_machine &machine, int ref, int params, const char *param[])
{ {
device_t *cpu; device_t *cpu;
UINT64 address; UINT64 address;
@ -1192,18 +1195,28 @@ static void execute_comment_list(running_machine &machine, int ref, int params,
debug_console_printf(machine, "Error while parsing XML file\n"); debug_console_printf(machine, "Error while parsing XML file\n");
} }
/**
* @fn void execute_comment_commit(running_machine &machine, int ref, int params, const char *param[])
* @brief Add and Save current list of comments in debugger
*
*/
static void execute_comment_commit(running_machine &machine, int ref, int params, const char *param[])
{
execute_comment_add(machine,ref,params,param);
execute_comment_save(machine,ref,params,param);
}
/*------------------------------------------------- /*-------------------------------------------------
execute_comment - add a comment to a line execute_comment - add a comment to a line
-------------------------------------------------*/ -------------------------------------------------*/
// TODO: needs an autosave option in debugger for this, or a direct comment add and save.
static void execute_comment_save(running_machine &machine, int ref, int params, const char *param[]) static void execute_comment_save(running_machine &machine, int ref, int params, const char *param[])
{ {
if (debug_comment_save(machine)) if (debug_comment_save(machine))
debug_console_printf(machine, "Comments successfully saved\n"); debug_console_printf(machine, "Comment successfully saved\n");
else else
debug_console_printf(machine, "Comments not saved\n"); debug_console_printf(machine, "Comment not saved\n");
} }

18
src/emu/debug/debughlp.cpp
View File

@ -227,6 +227,7 @@ static const help_item static_help_list[] =
" comdelete <address> -- removes a comment from the given address\n" " comdelete <address> -- removes a comment from the given address\n"
" comsave -- save the current comments to a file\n" " comsave -- save the current comments to a file\n"
" comlist -- print currently avaliable comments from file\n" " comlist -- print currently avaliable comments from file\n"
" commit[/*] <address>,<comment> -- gives a bulk comadd then comsave command\n"
"\n" "\n"
}, },
{ {
@ -1252,6 +1253,23 @@ static const help_item static_help_list[] =
" Adds the comment 'undocumented opcode!' to the code at address 0x10\n" " Adds the comment 'undocumented opcode!' to the code at address 0x10\n"
"\n" "\n"
}, },
{
"commit",
"\n"
" commit[/*] <address>,<comment>\n"
"\n"
"Adds a string <comment> to the disassembled code at <address> then saves to file. Basically same as comadd + comsave via a single line.\n"
"The shortcut for this command is simply '/*'\n"
"\n"
"Examples:\n"
"\n"
"commit 0, hello world.\n"
" Adds the comment 'hello world.' to the code at address 0x0\n"
"\n"
"/* 10, undocumented opcode!\n"
" Adds the comment 'undocumented opcode!' to the code at address 0x10\n"
"\n"
},
{ {
"comsave", "comsave",
"\n" "\n"