Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-07-04 17:38:08 +03:00
Code Issues Actions 36 Packages Projects Releases Wiki Activity

Call reset_partial_updates() at the end of vblank instead of at the end

Browse Source 
of the visible display. Fix an issue in screen->configure() to always
recalculate the vblank timing on screen changes.
This commit is contained in:
Dirk Best 2014-05-19 11:47:28 +00:00
parent 0d34890b08
commit edf3b6f5ca
2 changed files with 21 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/emu/screen.c
View File

@ -453,10 +453,10 @@ void screen_device::configure(int width, int height, const rectangle &visarea, a
// if there has been no VBLANK time specified in the MACHINE_DRIVER, compute it now // if there has been no VBLANK time specified in the MACHINE_DRIVER, compute it now
// from the visible area, otherwise just used the supplied value // from the visible area, otherwise just used the supplied value
if (m_vblank == 0 && !m_oldstyle_vblank_supplied) if (m_oldstyle_vblank_supplied)
m_vblank_period = m_scantime * (height - visarea.height());
else
m_vblank_period = m_vblank; m_vblank_period = m_vblank;
else
m_vblank_period = m_scantime * (height - visarea.height());
// start the VBLANK timer // start the VBLANK timer
m_vblank_begin_timer->adjust(time_until_vblank_start()); m_vblank_begin_timer->adjust(time_until_vblank_start());
@ -565,11 +565,25 @@ bool screen_device::update_partial(int scanline)
} }
} }
// skip if we already rendered this line
if (scanline == m_last_partial_scan - 1)
{
LOG_PARTIAL_UPDATES(("skipped because line was already rendered\n"));
return false;
}
// skip if outside of visible area
if (scanline < visible_area().min_y || scanline > visible_area().max_y)
{
LOG_PARTIAL_UPDATES(("skipped because outside of visible area\n"));
return false;
}
// skip if less than the lowest so far // skip if less than the lowest so far
if (scanline < m_last_partial_scan) if (scanline < m_last_partial_scan)
{ {
LOG_PARTIAL_UPDATES(("skipped because less than previous\n")); LOG_PARTIAL_UPDATES(("skipped because less than previous\n"));
return FALSE; return false;
} }
// set the start/end scanlines // set the start/end scanlines
@ -802,7 +816,7 @@ void screen_device::vblank_begin()
// reset the VBLANK start timer for the next frame // reset the VBLANK start timer for the next frame
m_vblank_begin_timer->adjust(time_until_vblank_start()); m_vblank_begin_timer->adjust(time_until_vblank_start());
// if no VBLANK period, call the VBLANK end callback immedietely, otherwise reset the timer // if no VBLANK period, call the VBLANK end callback immediately, otherwise reset the timer
if (m_vblank_period == 0) if (m_vblank_period == 0)
vblank_end(); vblank_end();
else else
@ -829,6 +843,8 @@ void screen_device::vblank_end()
// increment the frame number counter // increment the frame number counter
m_frame_number++; m_frame_number++;
reset_partial_updates();
} }

3
src/emu/video.c
View File

@ -644,10 +644,7 @@ bool video_manager::finish_screen_updates()
screen_device_iterator iter(machine().root_device()); screen_device_iterator iter(machine().root_device());
for (screen_device *screen = iter.first(); screen != NULL; screen = iter.next()) for (screen_device *screen = iter.first(); screen != NULL; screen = iter.next())
{
screen->update_partial(screen->visible_area().max_y); screen->update_partial(screen->visible_area().max_y);
screen->reset_partial_updates();
}
// now add the quads for all the screens // now add the quads for all the screens
bool anything_changed = m_output_changed; bool anything_changed = m_output_changed;