Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-06-16 09:20:04 +03:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

-spg2xx: Scale SPU channel sum by a fixed 1/16 divider rather than by the active channel count. Fixes volume 'wobble'. [Ryan Holtz]

Browse Source
This commit is contained in:
MooglyGuy 2019-03-11 17:37:43 +01:00
parent 831108f49c
commit f5985ab869
1 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/devices/machine/spg2xx.cpp
View File

@ -2871,7 +2871,6 @@ void spg2xx_device::sound_stream_update(sound_stream &stream, stream_sample_t **
{ {
int32_t left_total = 0; int32_t left_total = 0;
int32_t right_total = 0; int32_t right_total = 0;
int32_t active_count = 0;
for (uint32_t channel = 0; channel < 16; channel++) for (uint32_t channel = 0; channel < 16; channel++)
{ {
@ -2897,8 +2896,6 @@ void spg2xx_device::sound_stream_update(sound_stream &stream, stream_sample_t **
sample = (sample * (int32_t)get_edd(channel)) >> 7; sample = (sample * (int32_t)get_edd(channel)) >> 7;
active_count++;
int32_t vol = get_volume(channel); int32_t vol = get_volume(channel);
int32_t pan = get_pan(channel); int32_t pan = get_pan(channel);
@ -2940,19 +2937,11 @@ void spg2xx_device::sound_stream_update(sound_stream &stream, stream_sample_t **
} }
} }
if (active_count) left_total >>= 4;
{ right_total >>= 4;
left_total /= active_count;
right_total /= active_count;
*out_l++ = (left_total * (int16_t)m_audio_regs[AUDIO_MAIN_VOLUME]) >> 7; *out_l++ = (left_total * (int16_t)m_audio_regs[AUDIO_MAIN_VOLUME]) >> 7;
*out_r++ = (right_total * (int16_t)m_audio_regs[AUDIO_MAIN_VOLUME]) >> 7; *out_r++ = (right_total * (int16_t)m_audio_regs[AUDIO_MAIN_VOLUME]) >> 7;
} }
else
{
*out_l++ = 0;
*out_r++ = 0;
}
}
} }
inline void spg2xx_device::stop_channel(const uint32_t channel) inline void spg2xx_device::stop_channel(const uint32_t channel)