Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-07-05 18:08:04 +03:00
Code Issues Actions 36 Packages Projects Releases Wiki Activity

Let's attack core_i64_format, too. This cleans up abuse of static buffers in the unmapped read/write reporters

Browse Source
This commit is contained in:
Vas Crabb 2016-03-01 22:27:30 +11:00
parent fee5fb55f9
commit f8f414c508
2 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/emu/machine.cpp
View File

@ -181,7 +181,7 @@ const char *running_machine::describe_context()
if (cpu != nullptr) if (cpu != nullptr)
{ {
address_space &prg = cpu->space(AS_PROGRAM); address_space &prg = cpu->space(AS_PROGRAM);
m_context = string_format("'%s' (%s)", cpu->tag(), core_i64_format(cpu->pc(), prg.logaddrchars(), prg.is_octal())); m_context = string_format(prg.is_octal() ? "'%s' (%*o)" : "'%s' (%*X)", cpu->tag(), prg.logaddrchars(), cpu->pc());
} }
} }
else else

20
src/emu/memory.cpp
View File

@ -673,10 +673,13 @@ private:
{ {
if (m_space.log_unmap() && !m_space.debugger_access()) if (m_space.log_unmap() && !m_space.debugger_access())
{ {
m_space.device().logerror("%s: unmapped %s memory read from %s & %s\n", m_space.device().logerror(
m_space.is_octal()
? "%s: unmapped %s memory read from %*o & %*o\n"
: "%s: unmapped %s memory read from %*X & %*X\n",
m_space.machine().describe_context(), m_space.name(), m_space.machine().describe_context(), m_space.name(),
core_i64_format(m_space.byte_to_address(offset * sizeof(_UintType)), m_space.addrchars(),m_space.is_octal()), m_space.addrchars(), m_space.byte_to_address(offset * sizeof(_UintType)),
core_i64_format(mask, 2 * sizeof(_UintType),m_space.is_octal())); 2 * sizeof(_UintType), mask);
} }
return m_space.unmap(); return m_space.unmap();
} }
@ -741,11 +744,14 @@ private:
{ {
if (m_space.log_unmap() && !m_space.debugger_access()) if (m_space.log_unmap() && !m_space.debugger_access())
{ {
m_space.device().logerror("%s: unmapped %s memory write to %s = %s & %s\n", m_space.device().logerror(
m_space.is_octal()
? "%s: unmapped %s memory write to %*o = %*o & %*o\n"
: "%s: unmapped %s memory write to %*X = %*X & %*X\n",
m_space.machine().describe_context(), m_space.name(), m_space.machine().describe_context(), m_space.name(),
core_i64_format(m_space.byte_to_address(offset * sizeof(_UintType)), m_space.addrchars(),m_space.is_octal()), m_space.addrchars(), m_space.byte_to_address(offset * sizeof(_UintType)),
core_i64_format(data, 2 * sizeof(_UintType),m_space.is_octal()), 2 * sizeof(_UintType), data,
core_i64_format(mask, 2 * sizeof(_UintType),m_space.is_octal())); 2 * sizeof(_UintType), mask);
} }
} }