Sprinter/mame
2
0
Fork 0
mirror of https://github.com/holub/mame synced 2025-04-24 17:30:55 +03:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

timer.cpp: Use siblingdevice instead of absolute tag lookup; add screen tag validation for scanline timers (nw)

Browse Source
This commit is contained in:
AJR 2018-05-21 10:15:00 -04:00
parent 6cd565fee5
commit fe342b9877
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/devices/machine/timer.cpp
View File

@ -81,6 +81,10 @@ void timer_device::device_validity_check(validity_checker &valid) const
osd_printf_warning("Scanline timer specified parameters for a periodic timer\n");
if (m_param != 0)
osd_printf_warning("Scanline timer specified parameter which is ignored\n");
if (m_screen_tag == nullptr)
osd_printf_error("Scanline timer has no screen specified\n");
else if (dynamic_cast<screen_device *>(siblingdevice(m_screen_tag)) == nullptr)
osd_printf_error("Scanline timer specifies nonexistent screen %s\n", m_screen_tag);
// if (m_first_vpos < 0)
// osd_printf_error("Scanline timer specified invalid initial position\n");
// if (m_increment < 0)
@ -103,7 +107,7 @@ void timer_device::device_start()
{
// fetch the screen
if (m_screen_tag != nullptr)
m_screen = machine().device<screen_device>(m_screen_tag);
m_screen = siblingdevice<screen_device>(m_screen_tag);
// allocate the timer
m_timer = timer_alloc();