Word around the campfire is this totally works and stuff. More technically, it eliminates a number of double-frees and also now cleans up the shadow mask PNG and hlsl_options allocations. (nw)
out of log:
This way it is possible to link two or more separated executables with different
copyright/xml out/name/... in one compilation, just one step closer...
No whatsnew: There is no creasing visible to me, using either -window -nomaximize or -nowindow on a 1920x1080 display. If someone can get me a consistently reproducible case, it will be fixed.
Country Entertainment]
- Created two flags, -hlsl_ini_write and -hlsl_ini_read. The former enables
custom HLSL INI writing explicitly, the other enables loading of the same.
- Fixed disappearing aperture effect when using custom INI files.
- Fixed diagonal seam on some games, for serious real this time
- Fixed phosphor simulation, now works as expected
Hand-checked the most popular English word misspellings and made the appropriate changes. Nearly all of the changes made were in commented areas. (no whatsnew)
- MAME will now save an HLSL INI file on the first run of a game that doesn't already have an INI file.
- HLSL INI files must have their parameters left in the order in which they are saved out.
- Fixed a diagonal 'crease' visible on the screen in HLSL mode.
- Fixed set_vector functionality and simplified shaders as a result
- Fixed HLSL presets, 0 to 3, in increasing level of terribleness
- Reduced options footprint from RGB triplets
Next plan: Separate INI writing.
out of whatsnew
remark 1- this is for MESS only to my knowledge, let me know if I should credit the change in MESS instead
remark 2 (mainly for Arbee) - sorry if I touched the SDL side of the source, but mizapf was eager to fix the ti99 issues
and since tlinder approved the change and you did not object on the MESS list, I think it was time to commit it ;)
- Reworked default shadow mask settings, eliminating rainbow banding and matching reference shots more closely
- Moved color power to occur after shadow mask, as it is intended to simulate nonlinear phosphor response
- Added a variable-width notch filter to the Y channel in NTSC post-processing, eliminating luma banding on e.g. CoCo 2 and Apple II
Attempting to fix the HLSL 'blurriness' reported by a few people. Now HLSL will auto-prescale to the nearest texture size that is greater than the target screen size on both axes and is also an even multiple of the raw bitmap's size.
- Added the ability to render screenshots at arbitrary resolutions.
- Added the ability to record AVI videos (albeit with no audio) at arbitrary resolutions.
- Added a 43-tap-wide FIR-based NTSC filter with tunable Y, I and Q frequency response.
- Updated scanlines to have a user-tunable pixel-height ratio in addition to the current screen-height ratio.
- Fixed a VRAM leak that was causing many dynamic-resolution drivers to run out of memory mid-run.
Low-level input upgrade. Classes now exist for input_codes, input_items,
input_devices, and input_seqs. Also created an input_manager class to
hold machine-global state and made it accessible via machine.input().
Expanded the device index range (0-255, up from 0-16), and the OSD can
now specify the device index explicitly if they can better keep the
indexes from varying run-to-run. [Aaron Giles]
Note that I've built and run SDL on Windows, but not all the code paths
were exercised. If you use mice/joysticks extensively double-check them
to be sure it all still works as expected.
This is mainly an OSD and core change. The only thing impacting drivers
is if they query for specific keys for debugging. The following S&Rs
took care of most of that:
S: input_code_pressed( *)\(( *)([^, ]+) *, *
R: \3\.input\(\)\.code_pressed\1\(\2
S: input_code_pressed_once( *)\(( *)([^, ]+) *, *
R: \3\.input\(\)\.code_pressed_once\1\(\2
- Created a new OSD function, osd_get_slider_list, which allows OS-specific slider controls.
- Plumbed new OSD-specific slider controls for HLSL parameters on Direct3D 9 targets. And there was much rejoicing.
- Re-worked render target handling to align pixels better, reducing unintentional blurring
- Made major fixes to CVBS simulation, significantly increasing color saturation
- The defocus pass is now switched off when defocus_x and defocus_y are zero, allowing finer-grained performance tuning.
- Removed YIQ convolution from the main color-convolution shader and replaced it with a full composite encode/decode pass. This is slower, but looks amazing(ly like a terrible TV) and can be turned off.
- More authentic NTSC dot crawl and bandwidth limiting.
- Potential fix for some crashing reported by John IV
- Split color convolution and deconvergence into separate shaders for potential GPU savings down the line
- Added light and heavy variants of the color convolution shader, the former with YIQ colorspace removed
- Re-worked defocus to occur prior to shadow mask application, as it would be on a real monitor.
- Removed Edge Detection, as it was just for fun and can easily be added in by users if desired.
- Split "pincushion" into "Pincushion" and "Screen Curvature", the former affecting the only the displayed image and the latter only affecting the shadow mask.
- 5-pass post-processing: Upscale, Post-Process, Store Last Frame, Defocus 1, Defocus 2
- Many tunable effects including: Scanlines, defocus, linear deconvergence, radial deconvergence, pincushion, RGB colorspace convolution, YIQ colorspace convolution, saturation, simulated dot crawl, simulated chroma subsampling, aperture masking, and more.
- Requires a GPU that supports Shader Model 3.0 to be enabled and a powerful GPU, the entire pipeline consists of approximately 30 texel fetches and approximately 230 arthimetic ops.
- Will supersample the framebuffer up to 9x in both X and Y, but this requires an enormously powerful GPU that has not been invented; users with Radeon 5000-class cards should limit themselves to 3x, Radeon 4000 to 1.5x.
- The default configuration will NOT appear to do anything; it requires tuning to the user's liking.
- Should nicely fall back in all cases except missing shaders, and it might fall back correctly in that case as well. Report any anomalies.
- For obvious reasons, the Direct3D8 renderer cannont support this.
- non-device timer callbacks
- machine state changing callbacks
- configuration callbacks
- per-screen VBLANK callbacks
- DRC backend callbacks
For the timer case only, I added wrappers for the old-style functions.
Over time, drivers should switch to device timers instead, reducing the
number of timers that are directly allocated through the scheduler.
existing modern devices and the legacy wrappers to work in this
environment. This in general greatly simplifies writing a modern
device. [Aaron Giles]
General notes:
* some more cleanup probably needs to happen behind this change,
but I needed to get it in before the next device modernization
or import from MESS :)
* new template function device_creator which automatically defines
the static function that creates the device; use this instead of
creating a static_alloc_device_config function
* added device_stop() method which is called at around the time
the previous device_t's destructor was called; if you auto_free
anything, do it here because the machine is gone when the
destructor is called
* changed the static_set_* calls to pass a device_t & instead of
a device_config *
* for many devices, the static config structure member names over-
lapped the device's names for devcb_* functions; in these cases
the members in the interface were renamed to have a _cb suffix
* changed the driver_enumerator to only cache 100 machine_configs
because caching them all took a ton of memory; fortunately this
implementation detail is completely hidden behind the
driver_enumerator interface
* got rid of the macros for creating derived classes; doing it
manually is now clean enough that it isn't worth hiding the
details in a macro
loader rewrite, which is still in progress....)
Replaced mamedriv.c with a new driver list mechanism that is generated
by the build tools. The emulator core now expects the presence of a
file called src/$(TARGET)/$(SUBTARGET).lst which is just a raw list of
driver names, one per line. C and C++ comments are still permitted.
This file is parsed by a new build tool makelist which extracts the
driver names, sorts them, and generates a file called drivlist.c, which
is consumed by the core. [Aaron Giles]
Added new osdcore function osd_malloc_array() which is identical to
osd_malloc() but obviously hints that the underlying allocation is for
an array. Updated all callers to use the appropriate form. Modified the
Windows allocator to only use guard pages for array-style allocations,
allowing us to enable them once again in debug builds. [Aaron Giles]
Created new static class driver_list to wrap accesses to the list of
available drivers. Improved speed of driver lookups by relying on the
presorting done by makelist. [Aaron Giles]
Created helper class driver_enumerator as a helper for iterating through
the list of drivers. This class supports basic filtering and iteration,
and also serves as a temporary cache of machine_configs. [Aaron Giles]
Created cli_frontend object to wrap all the CLI handling code in
clifront.c. Updated/simplified all the code to take advantage of the
driver_enumerator. [Aaron Giles]
Created media_auditor object to wrap all the auditing functions in
audit.c. Updated all users to the new interface. Note that the new
auditing mechanism is slightly out of sync with the romload code in
terms of finding ROMs owned by devices, so it may mis-report some
issues until the new ROM loading code is in. [Aaron Giles]
Added concept of a per-device searchpath. For most devices, their
searchpath is just the short name of the device. For driver_devices, the
searchpath is driver[;parent[;bios]]. This searchpath will eventually be
used by the rom loader to find ROMs. For now it is used by the media
auditor only. [Aaron Giles]
Created info_xml_creator object to wrap all the info generation functions
in info.c. Converted the file to C++ and cleaned up the input processing
code. [Aaron Giles]
(not for whatsnew ... Known issues: auditing of CHDs appears busted, and
debug builds report unfreed memory if you use the built-in game picker)
Remove redundant machine items from address_space and device_t.
Neither machine nor m_machine are directly accessible anymore.
Instead a new getter machine() is available which returns a
machine reference. So:
space->machine->xxx ==> space->machine().xxx
device->machine->yyy ==> device->machine().yyy
Globally changed all running_machine pointers to running_machine
references. Any function/method that takes a running_machine takes
it as a required parameter (1 or 2 exceptions). Being consistent
here gets rid of a lot of odd &machine or *machine, but it does
mean a very large bulk change across the project.
Structs which have a running_machine * now have that variable
renamed to m_machine, and now have a shiny new machine() method
that works like the space and device methods above. Since most of
these are things that should eventually be devices anyway, consider
this a step in that direction.
98% of the update was done with regex searches. The changes are
architected such that the compiler will catch the remaining
errors:
// find things that use an embedded machine directly and replace
// with a machine() getter call
S: ->machine->
R: ->machine\(\)\.
// do the same if via a reference
S: \.machine->
R: \.machine\(\)\.
// convert function parameters to running_machine &
S: running_machine \*machine([^;])
R: running_machine \&machine\1
// replace machine-> with machine.
S: machine->
R: machine\.
// replace &machine() with machine()
S: \&([()->a-z0-9_]+machine\(\))
R: \1
// sanity check: look for this used as a cast
(running_machine &)
// and change to this:
*(running_machine *)
to private member variables with accessors:
machine->m_respool ==> machine->respool()
machine->config ==> machine->config()
machine->gamedrv ==> machine->system()
machine->m_regionlist ==> machine->first_region()
machine->sample_rate ==> machine->sample_rate()
Also converted internal lists to use simple_list.
functionality in favor of alternate mechanisms. Errors are
now reported via an astring rather than via callbacks. Every
option must now specify a type (command, integer, float, string,
boolean, etc). Command behavior has changed so that only one
command is permitted. [Aaron Giles]
Changed fileio system to accept just a raw searchpath instead of
an options/option name combination. [Aaron Giles]
Created emu_options class dervied from core_options which wraps
core emulator options. Added mechanisms to cleanly change the
system name and add/remove system-specific options, versus the
old way using callbacks. Also added read accessors for all the
options, to ensure consistency in how parameters are handled.
Changed most core systems to access emu_options instead of
core_options. Also changed machine->options() to return emu_options.
[Aaron Giles]
Created cli_options class derived from emu_options which adds the
command-line specific options. Updated clifront code to leverage
the new class and the new core behaviors. cli_execute() now accepts
a cli_options object when called. [Aaron Giles]
Updated both SDL and Windows to have their own options classes,
derived from cli_options, which add the OSD-specific options on
top of everything else. Added accessors for all the options so
that queries are strongly typed and simplified. [Aaron Giles]
Out of whatsnew: I've surely screwed up some stuff, though I have
smoke tested a bunch of things. Let me know if you hit anything odd.
Also I know this change will impact the WINUI stuff, please let me
know if there are issues. All the functionality necessary should
still be present. If it's not obvious, please talk to me before
adding stuff to the core_options class.
to pass a core_options object to the constructor, along with
a search path. This required pushing either a running_machine
or a core_options through some code that wasn't previously
ready to handle it. emu_files can be reused over multiple
open/close sessions, and a lot of core code cleaned up
nicely as things were converted to them.
Also created a file_enumerator class for iterating over files
in a searchpath. This replaces the old mame_openpath functions.
Changed machine->options() to return a reference.
Removed public nvram_open() and fixed jchan/kaneko16 to
stop directly saving NVRAM.
Removed most of the mame_options() calls; this will soon go
away entirely, so don't add any more.
Added core_options to device_validity_check() so they can be
used to validate things.
- Rewritten some checks to be runtime instead of compile dependent
- Added winmenu.c and "menu" option in windows build
- winmenu.c provide just dummy implementation, and makes linking with actual menu implementation easier.
global functions which are now superceded by the operators and
methods on the class. [Aaron Giles]
Required mappings are:
attotime_make(a,b) => attotime(a,b)
attotime_to_double(t) => t.as_double()
double_to_attotime(d) => attotime::from_double(d)
attotime_to_attoseconds(t) => t.as_attoseconds()
attotime_to_ticks(t,f) => t.as_ticks(f)
ticks_to_attotime(t,f) => attotime::from_ticks(t,f)
attotime_add(a,b) => a + b
attotime_add_attoseconds(a,b) => a + attotime(0, b)
attotime_sub(a,b) => a - b
attotime_sub_attoseconds(a,b) => a - attotime(0, b)
attotime_compare(a,b) == 0 => a == b
attotime_compare(a,b) != 0 => a != b
attotime_compare(a,b) < 0 => a < b
attotime_compare(a,b) <= 0 => a <= b
attotime_compare(a,b) > 0 => a > b
attotime_compare(a,b) >= 0 => a >= b
attotime_mul(a,f) => a * f
attotime_div(a,f) => a / f
attotime_min(a,b) => min(a,b)
attotime_max(a,b) => max(a,b)
attotime_is_never(t) => t.is_never()
attotime_string(t,p) => t.as_string(p)
In addition, some existing #defines still exist but will go away:
attotime_zero => attotime::zero
attotime_never => attotime::never
ATTOTIME_IN_SEC(s) => attotime::from_seconds(s)
ATTOTIME_IN_MSEC(m) => attotime::from_msec(m)
ATTOTIME_IN_USEC(u) => attotime::from_usec(u)
ATTOTIME_IN_NSEC(n) => attotime::from_nsec(n)
ATTOTIME_IN_HZ(h) => attotime::from_hz(h)
Not for whatsnew: I added -Wno-conversion unconditionally to disable the
warnings Thomas reported. That setting is the default for GCC out-of-the-box
but apparently not on NetBSD. As far as I know it shouldn't cause a problem
with any GCC version back to at least 4.0.0 so we're safe even on PPC OSX,
but do let me know if hilarity ensues.
Yes, it is intentional that the x86/x64 backends compile everywhere.
Backends are now derived from drcbe_interface and implement several
required overrides.
x86emit.h now uses namespaces so that the x86/x64 emitters can co-exist.
New file uml.h/uml.c actually describes the UML language, separating
out several concepts from drcuml.c.
Lots of other changes/fixes.
by preceding it with "0x". This allows F4 to work properly, for
example, on the 68000 stepping to address a6, which also happens
to be a register name.
This takes full pathname/filename to the font, and the name can have styles
appended as in Windows: [b] for bold, [i] for italic, [s] for strikethrough,
and [u] for underlined. Fonts are rendered at a size of 120 points and scaled
down by the core, which looks superb on high-res displays. (Liberation Sans
that comes with most recent distros looks really good).
Warning: Linux/BSD builds now require SDL_ttf 2.x. On Fedora the required
package names are "SDL_ttf" and "SDL_ttf-devel".
if it owns a given font (based on the name), and if it does, it is
responsible for generating bitmaps on the fly as characters are requested.
Added new option -uifont to specify the UI font. It can be set to a filename,
in which case a BDF font will be loaded. It can also be set to a font name
(assuming the OSD support is present), in which case the OSD font by that
name is used. The default value is 'default' which can be used by the OSD
to substitute a default font or by the OSD, which will default to ui.bdf
as before. In all cases, it falls back to the built-in font by default if
none of the previous options works.
On Windows, the OSD will default to Tahoma as the font name. Also on
Windows, font names can be specified with [b] to indicate bold or [i] to
indicate italic.
module osdepend.c with default empty implementations. Changed
mame_execute() and cli_execute() to accept a reference to an
osd_interface which is provided by the caller.
Updated SDL and Windows OSD to create an osd_interface-derived
class and moved their OSD callbacks to be members.
Added explicit control handler for the console. Ctrl+C/Ctrl+Break now
explicitly terminate the process forcefully, rather than unwinding
through the system in an unexpected state. Other console events
(exit, shutdown, logoff) request a graceful exit.
Moved -effect implementation out of OSD code and into core since
the implementations were identical across Windows/SDL and implemented
in the core itself.
Log: Added preliminary support for saving debugger window locations. [Andrew Gardner]
(Notes)
* I only save the values for the SDL debugger for now.
* There is no loading of these values yet, but if this patch is confirmed good,
loading should be relatively straightforward to add.
* There is a slight chance this might not compile on OSes other than linux.
I will be available via e-mail for the next 10 hours and will assist
with any compilation problems if they occur.
* The patch seems like the "right way" to do things, but if I am doing anything
suspect, please feel free to make suggestions and corrections.
The purpose of making it const before was to discourage direct tampering,
but private/protected does a better job of that now anyhow, and it is
annoying now.
s/const[ \t]+address_space\b/address_space/g;
Is basically what I did.
devices. Debugger now creates one for each device. C++-ified most
debugger operations to hang off the debugging class, and updated
most callers. This still needs a little cleanup, but it fixes most
issues introduced when the CPUs were moved to their own devices.
Got rid of cpu_count, cpu_first, cpu_next, etc. as they were badly
broken. Also removed cpu_is_executing, cpu_is_suspended,
cpu_get_local_time, and cpu_abort_timeslice.
Some minor name changes:
state_value() -> state()
state_set_value() -> set_state()
DECLARE_LEGACY_CPU_DEVICE and DEFINE_LEGACY_CPU_DEVICE. Changed CPUs
to be their own device types, rather than all of type CPU with a
special internal subtype. Note that as part of this process I removed
the CPU_ prefix from the ALL-CAPS device name, so CPU_Z80 is just
plain old Z80 now. This required changing a couple of names like
8080 to I8080 so that there was an alphabetic first character.
Added memory interfaces to the list of fast-access interfaces. To do
this properly I had to add a separate method to devices which is
called immediately after construction, when it is possible to perform
dynamic_casts on fully-constructed objects. (This is just internal,
no changes necessary to the devices themselves.)
Some additional notes:
* SH2 and SH4 had typedefs that conflicted with their CPU_-less names
so I bulk renamed to structures to sh2_state and sh4_state; RB, feel
free to choose alternate names if you don't like 'em
* SCSP was caught doing something to the 3rd indexed CPU. Since several
systems that use SCSP don't even have 3 CPUs, I had no idea what
this was supposed to do, so I changed to it reference "audiocpu"
assuming that stv was the assumed target. This is really gross and
should be a configuration parameter, not a hard-coded assumption.
* created dynamic_bind<> template class to handle dynamically binding to
optionally-supported functions
* wrapped stack walking code in a class
* wrapped symbol lookup code in a class
* added support for parsing objdump-produced symbol dumps which include
non-global functions for much better stack dumps and profiling in gcc builds
Also: modified makefile for win32 targets to automatically run objdump and
produce a .sym file if SYMBOLS is enabled.
- always available now, just specify -profile <n> to enable it
- supports stack walking to uniquely identify call chains; the <n> parameter
to the -profile option specifies how deep to go
- automatically turns off throttling and multithreading, and sets the number of
processors available to 1 (since we only sample the main thread)
- output now uses the common symbol lookup, which actually uses the PDB for
MSVC builds and gives excellent results (may eventually figure out how to
extract gcc symbols someday)
- the top 30 unique call chains are output
running_machine definition and implementation.
Moved global machine-level operations and accessors into methods on the
running_machine class. For the most part, this doesn't affect drivers
except for a few occasional bits:
mame_get_phase() == machine->phase()
add_reset_callback() == machine->add_notifier(MACHINE_NOTIFY_RESET, ...)
add_exit_callback() == machine->add_notifier(MACHINE_NOTIFY_EXIT, ...)
mame_get_base_datetime() == machine->base_datetime()
mame_get_current_datetime() == machine->current_datetime()
Cleaned up the region_info class, removing most global region accessors
except for memory_region() and memory_region_length(). Again, this doesn't
generally affect drivers.
this object which can be called multiple times to append new devices
after the initial machine configuration is set up. Updated member
variables to match new naming convention.
Changed the running_machine to take a constructed machine_config
object in the constructor, instead of creating one itself, for
consistency. Also added machine->total_colors() as a shortcut to
machine->config->m_total_colors.
the device_config constructor. In situations where the proper name is not
known at construction time, a generic name can be specified and then
overridden later once the configuration is complete.
like them, but it's a start. Split implementation of individual view
types out to separate files. Updated all callers.
Also:
* fixed okim6295 memory view
* changed emualloc to free resource pools from earliest to latest
so that early objects can safely clean up stuff they allocated
atarijsa.c: just use a generic device for the tms5220 to handle variants until
we have a proper base class (fixes eprom, eprom2 - eprom.c
"assert: src/emu/emucore.h:328: dynamic_cast<_Dest>(src) == src")
decocass.c: invert sense of reset line to MCU (fixes All sets in decocass.c -
Games no longer begin loading (countdown))
metro.c: use generic device for the YM sound since multiple YM chips are used.
(fixes 3kokushi, blzntrnd, dharma, dharmak, dokyusei, dokyusp, gstrik2, gstrik2j,
karatour, ladykill, lastfort, lastforte, lastforte, lastfortg, lastfortk, skyalert,
toride2g, toride2gg, toride2j - metro.c
"assert: src/emu/emucore.h:328: dynamic_cast<_Dest>(src) == src")
mitchell.c: when swapping the OKIM6295 for an MSM5205, use a different tag.
(fixes pangba, spangbl - mitchell.c
"assert: src/emu/emucore.h:328: dynamic_cast<_Dest>(src) == src")
deco32.c: use a proper EEPROM device to fetch the space from.
(fixes tattass, tattassa - deco32.c - Crash while checking "Jack Ram" before start
"assert: src/emu/emucore.h:328: dynamic_cast<_Dest>(src) == src")
system1.c: use a proper z80pio_device (cleanup)
vconv.c: support -g* options for MSVC builds (cleanup)
m377101.c/g65816.c: fix fault logic for mapping icount (fixes
All sets in namcofl.c, namcona1.c, namconb1.c, nss.c, sfcbox.c, snesb.c
airco22b, cybrcycc, dirtdash, rrf, timecrs, timecrsa - namcos22.c
Hanging immediately or shortly after start.
"assert: src/emu/schedule.c:189: ran >= *exec->m_icount")
schedule.c/diexec.c/timer.c: add temporary logging to permit direct comparisons with
earlier games timing (cleanup)
generic.c: fix computation of time for turning off the IRQ when using
generic_pulse_irq() to account for CPU-local time (fixes
Any sets in bublbobl.c which use the which use m6801 - Frequent/Random watchdog resets.)
z80pio.c: convert internal line states to bool, and fix typo (control_write should have
been data_write in one place) (fixes Any system1.c games which use z80pio - No sound)
performance as a result of this change. Do not panic; report issues to the
list in the short term and I will look into them. There are probably also
some details I forgot to mention. Please ask questions if anything is not
clear.
NOTE: This is a major internal change to the way devices are handled in
MAME. There is a small impact on drivers, but the bulk of the changes are
to the devices themselves. Full documentation on the new device handling
is in progress at http://mamedev.org/devwiki/index.php/MAME_Device_Basics
Defined two new casting helpers: [Aaron Giles]
downcast<type>(value) should be used for safe and efficient downcasting
from a base class to a derived class. It wraps static_cast<> by adding
an assert that a matching dynamic_cast<> returns the same result in
debug builds.
crosscast<type>(value) should be used for safe casting from one type to
another in multiple inheritance scenarios. It compiles to a
dynamic_cast<> plus an assert on the result. Since it does not optimize
down to static_cast<>, you should prefer downcast<> over crosscast<>
when you can.
Redefined running_device to be a proper C++ class (now called device_t).
Same for device_config (still called device_config). All devices and
device_configs must now be derived from these base classes. This means
each device type now has a pair of its own unique classes that describe
the device. Drivers are encouraged to use the specific device types
instead of the generic running_device or device_t classes. Drivers that
have a state class defined in their header file are encouraged to use
initializers off the constructor to locate devices. [Aaron Giles]
Removed the following fields from the device and device configuration
classes as they never were necessary or provided any use: device class,
device family, source file, version, credits. [Aaron Giles]
Added templatized variant of machine->device() which performs a downcast
as part of the device fetch. Thus machine->device<timer_device>("timer")
will locate a device named "timer", downcast it to a timer_device, and
assert if the downcast fails. [Aaron Giles]
Removed most publically accessible members of running_device/device_t in
favor of inline accessor functions. The only remaining public member is
machine. Thus all references to device->type are now device->type(), etc.
[Aaron Giles]
Created a number of device interface classes which are designed to be mix-
ins for the device classes, providing specific extended functionality and
information. There are standard interface classes for sound, execution,
state, nvram, memory, and disassembly. Devices can opt into 0 or more of
these classes. [Aaron Giles]
Converted the classic CPU device to a standard device that uses the
execution, state, memory, and disassembly interfaces. Used this new class
(cpu_device) to implement the existing CPU device interface. In the future
it will be possible to convert each CPU core to its own device type, but
for now they are still all CPU devices with a cpu_type() that specifies
exactly which kind of CPU. [Aaron Giles]
Created a new header devlegcy.h which wraps the old device interface using
some special template classes. To use these with an existing device,
simply remove from the device header the DEVICE_GET_INFO() declaration and
the #define mapping the ALL_CAPS name to the DEVICE_GET_INFO. In their
place #include "devlegcy.h" and use the DECLARE_LEGACY_DEVICE() macro.
In addition, there is a DECLARE_LEGACY_SOUND_DEVICE() macro for wrapping
existing sound devices into new-style devices, and a
DECLARE_LEGACY_NVRAM_DEVICE() for wrapping NVRAM devices. Also moved the
token and inline_config members to the legacy device class, as these are
not used in modern devices. [Aaron Giles]
Converted the standard base devices (VIDEO_SCREEN, SPEAKER, and TIMER)
from legacy devices to the new C++ style. Also renamed VIDEO_SCREEN to
simply SCREEN. The various global functions that were previously used to
access information or modify the state of these devices are now replaced
by methods on the device classes. Specifically:
video_screen_configure() == screen->configure()
video_screen_set_visarea() == screen->set_visible_area()
video_screen_update_partial() == screen->update_partial()
video_screen_update_now() == screen->update_now()
video_screen_get_vpos() == screen->vpos()
video_screen_get_hpos() == screen->hpos()
video_screen_get_vblank() == screen->vblank()
video_screen_get_hblank() == screen->hblank()
video_screen_get_width() == screen->width()
video_screen_get_height() == screen->height()
video_screen_get_visible_area() == screen->visible_area()
video_screen_get_time_until_pos() == screen->time_until_pos()
video_screen_get_time_until_vblank_start() ==
screen->time_until_vblank_start()
video_screen_get_time_until_vblank_end() ==
screen->time_until_vblank_end()
video_screen_get_time_until_update() == screen->time_until_update()
video_screen_get_scan_period() == screen->scan_period()
video_screen_get_frame_period() == screen->frame_period()
video_screen_get_frame_number() == screen->frame_number()
timer_device_adjust_oneshot() == timer->adjust()
timer_device_adjust_periodic() == timer->adjust()
timer_device_reset() == timer->reset()
timer_device_enable() == timer->enable()
timer_device_enabled() == timer->enabled()
timer_device_get_param() == timer->param()
timer_device_set_param() == timer->set_param()
timer_device_get_ptr() == timer->get_ptr()
timer_device_set_ptr() == timer->set_ptr()
timer_device_timeelapsed() == timer->time_elapsed()
timer_device_timeleft() == timer->time_left()
timer_device_starttime() == timer->start_time()
timer_device_firetime() == timer->fire_time()
Updated all drivers that use the above functions to fetch the specific
device type (timer_device or screen_device) and call the appropriate
method. [Aaron Giles]
Changed machine->primary_screen and the 'screen' parameter to VIDEO_UPDATE
to specifically pass in a screen_device object. [Aaron Giles]
Defined a new custom interface for the Z80 daisy chain. This interface
behaves like the standard interfaces, and can be added to any device that
implements the Z80 daisy chain behavior. Converted all existing Z80 daisy
chain devices to new-style devices that inherit this interface.
[Aaron Giles]
Changed the way CPU state tables are built up. Previously, these were data
structures defined by a CPU core which described all the registers and how
to output them. This functionality is now part of the state interface and
is implemented via the device_state_entry class. Updated all CPU cores
which were using the old data structure to use the new form. The syntax is
currently awkward, but will be cleaner for CPUs that are native new
devices. [Aaron Giles]
Converted the okim6295 and eeprom devices to the new model. These were
necessary because they both require multiple interfaces to operate and it
didn't make sense to create legacy device templates for these single cases.
(okim6295 needs the sound interface and the memory interface, while eeprom
requires both the nvram and memory interfaces). [Aaron Giles]
Changed parameters in a few callback functions from pointers to references
in situations where they are guaranteed to never be NULL. [Aaron Giles]
Removed MDRV_CPU_FLAGS() which was only used for disabling a CPU. Changed
it to MDRV_DEVICE_DISABLE() instead. Updated drivers. [Aaron Giles]
Reorganized the token parsing for machine configurations. The core parsing
code knows how to create/replace/remove devices, but all device token
parsing is now handled in the device_config class, which in turn will make
use of any interface classes or device-specific token handling for custom
token processing. [Aaron Giles]
Moved many validity checks out of validity.c and into the device interface
classes. For example, address space validation is now part of the memory
interface class. [Aaron Giles]
Consolidated address space parameters (bus width, endianness, etc.) into
a single address_space_config class. Updated all code that queried for
address space parameters to use the new mechanism. [Aaron Giles]
While at it, I also associated ESC to Menu bar toggling when in newui (like many other emulators for Windows), given that user would quit MESS with File > Exit in the menu bar.
split.c: made the "split" return the actual result instead of just 0. [Oliver Stöneberg]
clifront.c: made the identation of the CPU device in -listdevices the same like the others [Oliver Stöneberg]
i386.c: gave some fatalerror() calls in the i386 proper messages [Oliver Stöneberg]
ssem.c: fixed compilation of SSEM core with SSEM_DISASM_ON_UNIMPL [Oliver Stöneberg]
srcclean.c: small wording change in the srcclean summary [Oliver Stöneberg]
sdl/window.c: fixed a potential memory leak in sdlwindow_video_window_create() [Oliver Stöneberg]
- removed ui_use_new_ui check used by MESS code
- moved ui_mess_handler_ingame call in proper place, so device UI callbacks works again
- removed toggle of menu bar (MESS related)
- Moved "known bugs" to README_SDL13.txt
This is what has been there:
- fixed returning (w,h) = (0,0) in get_max_bounds
- new video driver "sdl13" utilitizing SDL texture and line
drawing support. Accelerated drivers like directfb now
may attain opengl speed. DirectFB does with a radeon card.
The driver determines which pixel formats perform best and
converts textures to these pixel formats.
Supported options:
-waitvsync
-filter
-prescale
Supported renderdrivers:
X11: opengl, software, x11 (no artwork!)
DirectFB: directfb, software, opengl (special setup, slow)
Windows: software, gdi (no artwork)
- SDL1.3: Clear bck when moving
- SDL1.3: now compiles on win32
- SDL1.3: Support screen refresh rates, provided the sdl video
layer supports them (e.g. X11).
- Use video_config.waitvsync (previously option was queried)
- -video soft / -sm now supports -prescale
- removed reqwidth, reqheight from sdl_monitor_info; not used anywhere
- removed layerconfig from sdl_video_config; not used anywhere
- fixed yuv issues (firefox) / this was a bug I introduced
- removed deprecat.h from output.c
- Separated keyboard and mouse initialization into separate functions
- added _FORTIFY_SOURCE to verbose compiler define output.
- remove MAX_CPU from debugwin.c
- fixed vsync handling in SDL1.3 in soft/opengl drivers
- "waitvsync" also supported by "soft" driver in SDL1.3
- multiple mice and keyboards supported in SDL1.3
- support for DISTRO= make option
- got rid of "-joymap" and "-joymap_file"
- add -joy_idx[0-7] -keyb_idx[0-7] -mouse_idx[0-7] which
specify, which device is allocated to to e.g. Mouse 1, Mouse 2, ...
- moved define of THREAD_COOPERATIVE into sdl.mak and renamed to
NO_THREAD_COOPERATIVE. Changed references to #ifndef
- define NO_DEBUGGER in sdl.mak
- Solaris now uses -DNO_AFFINITY_NP
- added machine to window_info, removed deprecat.h from drawogl.c
- For DEBUG=1 builds, disable input grapping while windowed
- Fixed WIN32 compile
Wrote setenv function since mingw does not provide one.
Implemented osd_event_* as inline functions for win32 build.
We should at some point merge sdlwork.c and winwork.c and push it
to the core, letting sdlsync.c provide the necessary details.
- Removed keybled.c and references
- Added output.c and output.h. These will look for a fifo or file
/tmp/sdlmame_out and write output notifiers to it.
Added a sample client ledutil.sh to src/osd/sdl which turns
leds on and off and provides a debug (log) facility.
- removed os2work.c
- replaced window->render_lock with event window->rendered_event
For multiple windows and "-mt", the old code would allow filling up
the workqueue with 1000s of entries, since the lock would not block while
another window is rendered. The osd_event establishes a barrier which
is only freed if the last window blit operation has finished.
- Set SDL_VIDEO_GL_DRIVER if -gl_lib is given. The SDL directfb driver is picky about
this. Added reminder: FIXME: move lib loading code from drawogl.c here. This may be
used to disable opengl if no library was loaded.
- SDL1.3/video=opengl: Fixed windows not being updated after another window was resized
- for -verbose, output some information about renderer (-video soft)
- initialize mouse_enabled with option "-mouse". Affects both SDL1.2 and SDL1.3
This will hide the mouse if you specify "-mouse".
- SDL1.2: added blitmode "async" which sets SDL_ASYNCBLIT
- SDL1.2: removed blitmodes "hwbest" and "hwblit"
- added blitmode "hwbest" for antialiased and smoothed scaling now that the
directfb driver supports it. This is also supported by the 1.3 opengl
render backend
- added sdlinput_release_keys to cope with lost keyboard events in SDL1.3
- some identing in drawogl.c
- rename SDL_* macros to SDLMAME_* (avoid name clashes)
- got rid of VIDEO_SCALE_MODE constants. Scale modes are now handled in drawsdl.c.
Starting mame with eg. -video soft -sm yuy2 on X11 no longer crashes.
- some more changes to input.c to avoid resize loops (issue for directfb)
- working ui mouse inputs for SDL1.2 and SDL1.3 incl. yuv modes
- added blitmode "hwblit" (SDL1.3) for rgb hardware scaling
- rename "-yuvmode" option to "-scalemode"
- rename yuv_mode and derivatives to scale_mode
- moved extra_flags into sdl_info
- moved callbacks indow sdl_window_info
- made a number of flags (e.g. yuvmode) window relative
- changing of yuvmodes and opengl scale effects is working with SDL 1.3
- improved fullscreen handling
- removed HAS_WINDOW_MENU - this has no effect nowhere
- removed underscores in header defines, e.g. __SDL_SYNC__ ==> __SDLSYNC__
- added SDLMAME_HAS_DEBUGGER define
- removed #if 0 inw window.c
- added option "-audiodriver" to specify the SDL audio driver
- added option "-videodriver" to specify the SDL video driver
- added option "-renderdriver" to specify the SDL renderer driver
- changed environment SDLMAME_GL_LIB into option -gl_lib
- added some more SDL_ENV defines
- move keymap reading into separate function
- SDL_EnableUNICODE for all builds (not only MESS)
- SDL1.3 : Mouse & text input for ui
- removed osd_event_wait_multiple from sdlsync.h
- removed some includes not needed
- reorganized texcopy/scale2x
- removed effect.h
- removed effect_func.h
- indenting
- put osd_copyfile, osd_stat into #ifdef MESS
- added code which implements events without the need
for pthreads. This is commented out, since
owever, it horribly fails, if
threads > num processors as is the case if you
enable "-mt"
- rename mame_bitmap to bitmap_t
- introduced define OSDWORK_CALLBACK to prototype and
define functions to be passed to sdlwork.c
- fixes from judge for warnings / may reappear (glade)
- more warnings fixed / may reappear (glade)
- moved osdefs.h into sdlprefix.h
- removed osdefs.h
- finally removed sdlmisc.h
- create drawogl.c and moved ogl relevant stuff there
- draw.window_init() now called after window creation
- removed window.opengl flag
- added sdl_window_info as parameter to all functions in window.h
- rename SDL_VERSIONNUM to SDL_VERSION_ATLEAST
- removed all uclock stuff in sdlmisc.[ch]
- minor cleanups
- fixed compile issues against SDL13
- fixed input issues with SDL13
- stricter checks for USE_OPENGL, e.g. for options
- move sdlvideo_loadgl to window.c, rename it to sdlwindow_loadgl and make it static
- moved yuv_blit.c into drawsdl.c
- renamed compute_blit_surface_size to sdlwindow_blit_surface_size
- renamed drawsdl_destroy_all_textures to drawogl_destroy_all_textures and
moved it to _sdl_draw_callbacks
- removed print_colums
- rename misc.h to sdlmisc.h
- moved some includes from .h to .c
- rename led_init to sdlled_init for consistency
- rename sdl_init_audio to sdlaudio_init for consistency
- fixed some indentation issues
- removed ticker.h & dirty.h
- changed all [f]printf to mame_printf_verbose|error|warning
- removed obsolete frameskipping code
- removed obsolete throttle code
- removed fastforward
- removed framestorun
- introduced SDLOPTION constants for a number of options
- add more verbose info for YUV
- removed dirty.h
- removed ticker.h
- remove win_trying_to_quit
- changed win_use_mouse to static use_mouse
- removed win_key_trans_table
- removed keyboard typematic definitions from input.h
- made sdl_monitor_list static
- removed hwstretch (sdl_video_config)
- removed syncrefresh (sdl_video_config)
- removed triplebuf (sdl_video_config)
- removed sdl_has_menu
- fixed memory_leak (window.c)
- moved prototypes from drawsdl.c to window.h
- removed joystick calibration code
- "#if 0" code which is unreachable
- "#if 0" code which is never used
- moved pick_best_mode to window.c
- removed pause_brightness option
- added more SDLOPTION_ defines
- renamed void yuv_lookup_init to drawsdl_yuv_init (global namespace)
- rmoved some obsolete code
- add SDL1.3 compatibility
- fixed some compile issues
- moved clear_surface into window thread
- got SDL1.3 -mt working - still crashing on exit
- removed "digital" option
- removed device selection options
- added more SDLOPTION defines
Replaced all occurrences of OPTION_DEBUG in src/osd/* by checking machine->debug_flags
Replaced all occurrences of DEBUG_FLAG_ENABLED in src/osd/* by DEBUG_FLAG_OSD_ENABLED
For the time being, DEBUG_FLAG_OSD_ENABLED is default (set in mame.c)
Debugger: avoid clearing DEBUG_FLAG_OSD_ENABLED
- fix a compile warning for gcc-4.4 (not detected by gcc-4.2)
- Horizontal divider bar to individually size views.
- minimum height aligned to win32 debugger
39in1, raiden2, safarir, sbowling, shougi, skeetsht, skyarmy, sliver,
spoker, spool99, srmp5, srmp6, ssingles, sstrangr, sub, supdrapo,
superdq, supertnk, suprgolf.
---------- Forwarded message ----------
From: Atari Ace <atari_ace@verizon.net>
Date: Thu, Jan 21, 2010 at 1:53 AM
Subject: [patch] Additional driver_data conversions, PCTSTR => LPCTSTR
To: submit@mamedev.org
Cc: atariace@hotmail.com
Another driver_data patch, this one converting the following single
file drivers
39in1, raiden2, safarir, sbowling, shougi, skeetsht, skyarmy, sliver,
spoker, spool99, srmp5, srmp6, ssingles, sstrangr, sub, supdrapo,
superdq, supertnk, suprgolf.
I also tossed in a one line fix to winmain.c (PCTSTR => LPCTSTR). My
unofficial toolchain doesn't have a definition for PCTSTR, it
certainly looks like a typo.
~aa
