mirror of
https://github.com/holub/mame
synced 2025-04-23 08:49:55 +03:00
863a28e929
Subject: a few more read_indexed removed
Hi Aaron,
attached please find a few more patches to remove input_port_read_indexed, following the approach you suggested.
Once again, each patch covers 5/6 drivers to more easily avoid failures while applying them. Let me know if any patch fails to apply.
Also, I would like to ask some of you to take a look at bbusters.c: the behavior of the handler 'control_3_r' seems strange to me but I was not able to understand exactly which is its role in the driver. Currently, it reads one of the inputs "IN5", "IN6", "IN7" (because gun_select assumes values 0,1,2). If it's used to select the gun among the 3, shouldn't it read "IN5", "IN7" and "IN9"? anyway the current code works, so I only added a comment about this and I hope some of you can review this part of the driver to remove the remaining input_port_read_indexed.
A couple of additional notes (tag names refer to the ones I added in the patch):
* in bnstars.c, the input port tagged as "IN6" is never read. probably this is well known to the driver author but... I think there was no harm in pointing it out :)
* in bsktball.c, Start is mapped to both the start & p1 buttons (but it is hidden behind an hack, check src/mame/machine/bsktball.c). since you were removing a few of these duplications recently, maybe this one could go as well...
* in bwing.c, the input port tagged as "EXTRA" seems an hack, and maybe it could be removed
Regards,
Fabio
|
||
|---|---|---|
| docs | ||
| src | ||
| .gitattributes | ||
| makefile | ||