mame/src/devices/bus/plus4/exp.cpp
Nathan Woods afa6a83728 Changes to make get_default_card_software() less stupid
The goals with this change is to make get_default_card_software() a bit more standalone by making it a const method that does not mutate the state of the device_image_interface.  This is done by passing in a small structure that encapsulates the minimum of information that get_default_card_software() needs.

This also eliminates the need for device_image_interface::open_image_file()

I agree with Sarayan that get_default_card_software() is terrible and needs to ultimately go away.  This is a small step in that direction.

Lastly, I don't care for the name of get_default_card_software_hook (or get_default_card_software() for that matter).  If anybody has better ideas, let me know.
2017-04-10 20:47:40 -04:00

199 lines
5.4 KiB
C++

// license:BSD-3-Clause
// copyright-holders:Curt Coder
/**********************************************************************
Commodore Plus/4 Expansion Port emulation
**********************************************************************/
#include "emu.h"
#include "exp.h"
//**************************************************************************
// MACROS/CONSTANTS
//**************************************************************************
#define LOG 0
//**************************************************************************
// DEVICE DEFINITIONS
//**************************************************************************
const device_type PLUS4_EXPANSION_SLOT = device_creator<plus4_expansion_slot_device>;
//**************************************************************************
// DEVICE PLUS4_EXPANSION CARD INTERFACE
//**************************************************************************
//-------------------------------------------------
// device_plus4_expansion_card_interface - constructor
//-------------------------------------------------
device_plus4_expansion_card_interface::device_plus4_expansion_card_interface(const machine_config &mconfig, device_t &device)
: device_slot_card_interface(mconfig, device),
m_c1l(*this, "c1l"),
m_c1h(*this, "c1h"),
m_c2l(*this, "c2l"),
m_c2h(*this, "c2h"),
m_c1l_mask(0),
m_c1h_mask(0),
m_c2l_mask(0),
m_c2h_mask(0)
{
m_slot = dynamic_cast<plus4_expansion_slot_device *>(device.owner());
}
//-------------------------------------------------
// ~device_plus4_expansion_card_interface - destructor
//-------------------------------------------------
device_plus4_expansion_card_interface::~device_plus4_expansion_card_interface()
{
}
//**************************************************************************
// LIVE DEVICE
//**************************************************************************
//-------------------------------------------------
// plus4_expansion_slot_device - constructor
//-------------------------------------------------
plus4_expansion_slot_device::plus4_expansion_slot_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock) :
device_t(mconfig, PLUS4_EXPANSION_SLOT, "Expansion Port", tag, owner, clock, "plus4_expansion_slot", __FILE__),
device_slot_interface(mconfig, *this),
device_image_interface(mconfig, *this),
m_write_irq(*this),
m_read_dma_cd(*this),
m_write_dma_cd(*this),
m_write_aec(*this), m_card(nullptr)
{
}
//-------------------------------------------------
// device_start - device-specific startup
//-------------------------------------------------
void plus4_expansion_slot_device::device_start()
{
m_card = dynamic_cast<device_plus4_expansion_card_interface *>(get_card_device());
// resolve callbacks
m_write_irq.resolve_safe();
m_read_dma_cd.resolve_safe(0xff);
m_write_dma_cd.resolve_safe();
m_write_aec.resolve_safe();
// inherit bus clock
if (clock() == 0)
{
plus4_expansion_slot_device *root = machine().device<plus4_expansion_slot_device>(PLUS4_EXPANSION_SLOT_TAG);
assert(root);
set_unscaled_clock(root->clock());
}
}
//-------------------------------------------------
// device_reset - device-specific reset
//-------------------------------------------------
void plus4_expansion_slot_device::device_reset()
{
if (get_card_device())
{
get_card_device()->reset();
}
}
//-------------------------------------------------
// call_load -
//-------------------------------------------------
image_init_result plus4_expansion_slot_device::call_load()
{
if (m_card)
{
if (!loaded_through_softlist())
{
// TODO
}
else
{
load_software_region("c1l", m_card->m_c1l);
load_software_region("c1h", m_card->m_c1h);
load_software_region("c2l", m_card->m_c2l);
load_software_region("c2h", m_card->m_c2h);
}
}
return image_init_result::PASS;
}
//-------------------------------------------------
// get_default_card_software -
//-------------------------------------------------
std::string plus4_expansion_slot_device::get_default_card_software(get_default_card_software_hook &hook) const
{
return software_get_default_slot("standard");
}
//-------------------------------------------------
// cd_r - cartridge data read
//-------------------------------------------------
uint8_t plus4_expansion_slot_device::cd_r(address_space &space, offs_t offset, uint8_t data, int ba, int cs0, int c1l, int c2l, int cs1, int c1h, int c2h)
{
if (m_card != nullptr)
{
data = m_card->plus4_cd_r(space, offset, data, ba, cs0, c1l, c1h, cs1, c2l, c2h);
}
return data;
}
//-------------------------------------------------
// cd_w - cartridge data write
//-------------------------------------------------
void plus4_expansion_slot_device::cd_w(address_space &space, offs_t offset, uint8_t data, int ba, int cs0, int c1l, int c2l, int cs1, int c1h, int c2h)
{
if (m_card != nullptr)
{
m_card->plus4_cd_w(space, offset, data, ba, cs0, c1l, c1h, cs1, c2l, c2h);
}
}
//-------------------------------------------------
// SLOT_INTERFACE( plus4_expansion_cards )
//-------------------------------------------------
// slot devices
#include "c1551.h"
#include "sid.h"
#include "std.h"
SLOT_INTERFACE_START( plus4_expansion_cards )
SLOT_INTERFACE("c1551", C1551)
SLOT_INTERFACE("sid", PLUS4_SID)
// the following need ROMs from the software list
SLOT_INTERFACE_INTERNAL("standard", PLUS4_STD)
SLOT_INTERFACE_END