Commit Graph

82631 Commits

Author SHA1 Message Date
npwoods
97dcbb964e
Fixed some issues involving fs::meta_description construction (#9546)
* Fixed some issues involving fs::meta_description constructing

With the recent change to use std::variant more closely, I noticed a problem where meta_descriptions of type meta_type::String got defaults of type 't'.  This was because the templated ctor for meta_description would convert 'const char *' to 'bool'.  This change adds another overload to catch 'const char *', along with asserts to catch problems.

In the process I corrected a few meta_description ctors

It is possible that this change does not go far enough.  Perhaps the meta_type argument should be removed, and we should instead create distinct ctor types (rather than relying on templates) and specify the precise meta_type in the overload.  Or even go further and remove m_type from meta_description, and instead create an overload that calculates meta_type based on calling std::visit on the variant

* Taking this change a bit further, and removing m_type from fs::meta_description; it was superfluous.  Also doing some minor C++-ifications
2022-04-12 14:52:44 +02:00
Ivan Vangelista
ce68a1d711 New working clones
------------------
Blood Storm (v2.21) [coolmod]

angelkds.cpp, crgolf.cpp: finders and other small cleanups
2022-04-12 12:57:32 +02:00
angelosa
492b0e0df2 huc6272.cpp: don't return -1 when running out of nybbles in adpcm_update fn, fixes extremely overdriven PC-FX aliasing
huc6230.cpp: code review some dubious paths;
2022-04-11 18:46:05 +02:00
Ivan Vangelista
926e59db2b labyrunr.cpp, pcktgal.cpp: used finders and other small cleanups 2022-04-11 18:23:03 +02:00
angelosa
b51d40ffd6 hash/pcecd.xml: validate hucard requirements:
* fix most instances where the sharedfeat doesn't match what the description implies;
* fix Mahjong Vanilla Syndrome metadata;
* fix xak12 description;
* demote implode and meteorbl to baddump;
2022-04-11 13:47:43 +02:00
npwoods
b8758ed358
Consolidated floppy_image_device::m_create_fs and floppy_image_device::m_io_fs vectors (#9542)
* Consolidated floppy_image_device::m_create_fs and floppy_image_device::m_io_fs vectors

We had two separate members in floppy_image_device (m_create_fs and m_io_fs) that contained the same data.  Whether the file systems can be formatted or read can be identified by querying fs::manager_t.

For this reason, it seems bad to have these separate members, the seemingly only reason to make the UI code slightly less complicated.  For this reason I consolidated these two members and moved the burden of selecting which ones are creatable to the UI code.
2022-04-11 06:54:35 -04:00
0kmg
9ef4774f2e
nes.xml: Set correct board type for Qiwang Chinese Chess games. (#9547) 2022-04-11 06:52:59 -04:00
CanoeHope
d4d0554776
neogeo.xml - Fix moshougi and flipshot year (#9544) 2022-04-11 06:52:25 +02:00
Robbbert
dade85a724 init last bunch of vars for today 2022-04-11 01:48:18 +10:00
AJR
810fd2a951 apple1.cpp, microtan.cpp, mtx.cpp, vtech1.cpp: Eliminate use of device_image_interface::ptr() method
* vtech1.cpp: Correct fencepost error in snapshot loader
2022-04-10 11:13:18 -04:00
Robbbert
2509d8b900 init some more vars (includes) 2022-04-11 01:02:40 +10:00
Roberto Fresca
e1e78e34ed mame.lst: Changed Le Pendu manufacturer... 2022-04-10 16:53:31 +02:00
Roberto Fresca
8e419182ed Le Pendu: Changed manufacturer according to the shown in the title screen. 2022-04-10 16:50:20 +02:00
hap
5f8a1a39c5 goldnpkr: relocate namespace closing brace 2022-04-10 16:26:28 +02:00
hap
eb7644fae5 lependu: small adjustment to comment block align 2022-04-10 16:19:59 +02:00
hap
bc8156ac68 hh_sm510: move variables init to class body 2022-04-10 16:15:29 +02:00
hap
a6ae36b47e lependu: remove floating point math for binary logic, remove hardcoded keycodes where MAME already has the same defaults 2022-04-10 15:58:11 +02:00
Robbbert
1873823a53 init even more vars (includes) 2022-04-10 23:48:13 +10:00
AJR
1871bcfff0 cp1: Eliminate fgets in quickload parsing 2022-04-10 09:05:06 -04:00
hap
32c48d2e16 b5500: subclass of a5500 instead of b5000 2022-04-10 14:35:09 +02:00
Robbbert
0112f18775 more init vars (includes) 2022-04-10 22:06:24 +10:00
hap
efb0ba9dcd cpu.lua: fix typo from prev commit 2022-04-10 13:51:09 +02:00
hap
eca441adc1 New working clones
--------------------
30R: Slide Rule Memory (B5500 version) [hap, Sean Riddle]
2022-04-10 13:49:50 +02:00
hap
cd52b38151 rw5000: added b5500 2022-04-10 13:25:02 +02:00
Robbbert
f768e0565e init vars (includes) 2022-04-10 20:28:32 +10:00
Robbbert
e4c65de6ed init vars for broken apples 2022-04-10 19:08:20 +10:00
Robbbert
6b26c03867 init vars found from regression testing 2022-04-10 18:46:08 +10:00
Robbbert
3b180da4e1 init vars on some includes 2022-04-10 17:45:49 +10:00
Roberto Fresca
c1e7753b0a Le Pendu: More realistic button-lamps, and closer to the originals. 2022-04-10 08:48:51 +02:00
Robbbert
a879b3e1a8 pmd85: init vars, coverity 316086 2022-04-10 16:29:53 +10:00
Robbbert
7ac35ce393 megacdcd.cpp: check for cd before last track, coverity 351399,351404 2022-04-10 15:36:16 +10:00
Robbbert
a16a35c5aa mbee: coverity 333015 2022-04-10 15:23:10 +10:00
Roberto Fresca
b2a289ecb4 Le Pendu driver: Tag lookups, arrays, data, docs, blah blah. 2022-04-10 07:09:23 +02:00
Roberto Fresca
d010cd1c72 Funworld Quiz: Dumped and added the missing geo3 questions bank ROM.
Rearranged the remaining banks accordingly. [Team Europe, Roberto Fresca]
2022-04-10 06:49:39 +02:00
Robbbert
d46f641e59 315-5838_317-0229_comp: buffer overflow, coverity 183518 2022-04-10 14:31:50 +10:00
AJR
6fc03d481b midiin: Use util::random_read rather than buffer pointer in MIDI file parser 2022-04-09 22:35:58 -04:00
Robbbert
60165fb410 royalmah.cpp: coverity 345004 2022-04-10 11:07:19 +10:00
0kmg
0270ca721b
bus/nes: Added support for Sachen's Zhōngguó Dàhēng cartridge. (#9540) 2022-04-09 20:51:16 -04:00
Robbbert
07b5dc9d47 queen: coverity 176488 2022-04-10 10:43:11 +10:00
Robbbert
120388363e nc.cpp: coverity 138975
Note says nc200 hang at start, but when tested it works, so...
Machines promoted to working
----------------------------
NC200
2022-04-10 10:02:03 +10:00
Robbbert
0e804f50cd ibm6580: coverity 349280 2022-04-10 09:30:20 +10:00
Robbbert
ec30abcbb9 acefruit: placate coverity (251457,251459,251461) 2022-04-10 08:51:19 +10:00
Vas Crabb
8a31f29812 Revert "igs017.cpp: Improved protection and decryption [Luca Elia]"
This reverts commit ec3cd170e7.

This is problematic in several ways:
* Substantial protection data in source.
* Non-portable code doesn't build with clang.
* General quality issues.
2022-04-10 03:47:50 +10:00
987123879113
c161f61973
osd: Added multibyte check to osd_uchar_from_osdchar to fix decoding ASCII text. (#9536)
This allows ASCII INI files to be parsed on Windows systems set to use a double-byte code page.  It should also work with correctly-encoded Shift-JIS, GB2312, Big5 and EUC-KR.  It won’t work for more complex variable-length encodings, or when the input is not correctly encoded.
2022-04-10 02:48:27 +10:00
Luca Elia
ec3cd170e7 igs017.cpp: Improved protection and decryption [Luca Elia]
- Implemented "magic" i/o as a memory map (IGS_MUX) for added flexibility
- Hooked up IGS_INCDEC protection to cpoker2, tarzanc, spkrform, starzan
- Implemented specific IGS_INC protection in cpoker2
- Hooked up improved IGS022 protection to lhzb2, sqlz2
- Added IGS025 string protection to lhzb2, lhzb2a, mgcs, spkrform, slqz2, starzan, tarzanc, tjsb
- Palette scramble and tweaked tiles decryption in tarzanc (used also by starzan, happyskl, cpoker2)
- Decrypted sprites in tarzanc and starzan (used also by happyskl)
- Lamps and layout for starzan, happyskl, cpoker2
- Cleaned up/finished hopper emulation, added diplocations
- Joystick inputs in mgcs
- Finished inputs in spkrform. Allow hiding gambling (switching to Formosa and back)

igs022.cpp: Fixes for igs017.cpp games [Luca Elia, RockyWall]
- Fixed initial auto-DMA mode
- Enlarged internal RAM. Added stack
- Fixed command 12: Copy -> Stack Push
- Added command 45: Stack Pop
- Fixed command 6d opcode 1: Add Imm -> Sub Values
- Added command 6d opcode 0: Add Values
- Extended logging

Machines promoted to working
----------------------------
Tarzan Chuang Tian Guan (China, V109C, set 1) [Luca Elia, iq_132, Ivan Vangelista, Guru, Dyq, bnathan]
Super Tarzan (Italy, V100I) [Luca Elia, iq_132, Ivan Vangelista, f205v, Mirko Buffoni]
Happy Skill (Italy, V611IT) [Luca Elia, Ivan Vangelista, Caius, The Dumping Union]
Champion Poker 2 (V100A) [Luca Elia, Ivan Vangelista, Jorge Silva, Fernando Oliveira]
Long Hu Zhengba 2 (China, set 1) [Luca Elia, RockyWall, David Haywood, iq_132, Pierpaolo Prazzoli, XingXing]
Shuang Long Qiang Zhu 2 VS (China, VS203J) [Luca Elia, RockyWall, David Haywood, iq_132, Pierpaolo Prazzoli, XingXing]

Clones promoted to working
--------------------------
Super Poker (V100xD03) / Formosa [Luca Elia, ANY]
2022-04-09 17:46:18 +02:00
987123879113
1d19337feb
xvd701, twinkle: Implemented commands required for Twinkle DVD player. (#9114) 2022-04-10 01:45:06 +10:00
ClawGrip
cf2982a769
New NOT_WORKING machines (#9531)
* New NOT_WORKING machines
---------------------------------------
Sport Damjes 1 [Sergio de electronicaVyS, ClawGrip]
2022-04-09 16:36:39 +02:00
Robbbert
175fcca31a cps1: init vars; coverity 351281; use standard variable names. 2022-04-10 00:14:27 +10:00
Robbbert
a65cbf6443 chinagat: coverity 315292 2022-04-09 23:49:30 +10:00
hap
6e2cedc937 screen.h: set_clock(x) instead of m_clock=x 2022-04-09 14:04:01 +02:00