mirror of
https://github.com/holub/mame
synced 2025-04-21 07:52:35 +03:00
6888293791
Sent: Saturday, July 19, 2008 7:46 AM To: submit@mamedev.org Subject: a few bugfixes (or at least proposals of fix) Hi, enclosed please find the following patches for bugs currently in MAME (sorry for the verbose explanations, but I hope it makes faster the verification and not to steal too much time to the reviewer) correct fixes (IMHO) * harddriv.diff : Fixes a bug introduced in u7 which broke racedrvc, hdrivair and their clones (due to some tags not being renamed). Strange no one has noticed this (not even Firevawe when he ran its regtest before 0.126!), anyway now it's fixed... * gstrik2.diff : This patch fixes bug 1568. One of the two service mode keys doesn't give access to the service mode (and in fact it's not read at all in the input test in service mode). I changed it to an unknown dipswitch * atarijsa.diff : This changes the ports #defined in src/mame/audio/atarijsa.h to be EXTERNAL_INPUTS (and modifies accordingly the drivers using them). It allows to remove the SWAPPED version (modified locally in xybots.c) and it allowed me to fix half of bug 818 (duplicated coins in stunrun). Indeed, stunrun and steeltal use their own coin input and the jsa ones are not recognized in Service Mode. Therefore, I removed them through PORT_MODIFY. @Aaron: I left in COIN3, even if those games do not use it, maybe it can be made UNUSED as well proposals: * leland.diff : I noticed that the SERVICE MODE key in leland.c games doesn't do anything service related, but it simply adds a coin. This patch changes them to IPT_COIN3 (because this is the mapping of the same inputs for offroad and pigout). Actually, it could be an IPT_SERVICE1 (but I don't have currently access to any manual to verify it) or there could be a different bug in the driver causing the input to be read as a coin... If one of the latter options sounds more correct to you, please change the IPT or ignore this patch. [Note: this was changed to IPT_SERVICE1] * pc10.diff: This one fixes bug 595, i.e. Start button in playch10.c is currently mapped to key "2". This could be by design, but it's a bit confusing since it works the other way around in vsnes.c. If it was by design and you don't plan to change it, please post at MameTesters so that we can close the report as Not-a-bug. * twotiger.diff : This addresses bug 1448. The wheel is completely centered for any value in the (closed) interval [0x64, 0x69] (goes to left for 0x63 and to right for 0x70). I've chosen 0x67 because it's in between, but I'm not sure 100% about the way analog inputs are managed in the core, so feel free to use another value in that range if it m akes more sense than 0x67. That's all. Thanks for the atention Regards, Fabio |
||
|---|---|---|
| docs | ||
| src | ||
| .gitattributes | ||
| makefile | ||