mirror of
https://github.com/holub/mame
synced 2025-06-03 19:36:26 +03:00
ef0a31ca13
Sent: Sunday, June 07, 2009 9:54 AM To: submit@mamedev.org Cc: atariace@hotmail.com Subject: [patch] "Regularize" some interfaces in MAME Hi mamedev, This patch adjusts the code in a few places to be more regular in it object approach. It recognizes five idioms. 1. device_configs should be passed const. dsp56k.h took a non-const device_config for no particular reason, necessitating casting where used. A few other places cast to non-const, in most cases unnecessarily. 2. running_machines should be passed non-const. A few places used const in different ways on running_machines, instead of the idiomatic non-const running_machine. 3. Eliminate passing running_machine explicitly where it can be computed. esrip.c, m37710.c, sfbonus.c had cases where the machine could easily be eliminated. 4. Pass the object machine/config first. In some cases this makes the interface object oriented, in some cases it simply makes it more idiomatic with the rest of MAME. 5. Prefer (screen, bitmap, cliprect) to (machine, bitmap, cliprect). Fully implementing this would be a large patch, this patch simply does it for the one core 'device', tms9928a.c. |
||
|---|---|---|
| .. | ||
| m7700ds.c | ||
| m7700ds.h | ||
| m37710.c | ||
| m37710.h | ||
| m37710cm.h | ||
| m37710o0.c | ||
| m37710o1.c | ||
| m37710o2.c | ||
| m37710o3.c | ||
| m37710op.h | ||