Subject: [patch] Conditional code cleanup resubmit
Hi mamedev,
This is a resubmit of a previous patch. The earlier version would not
compile with 32-bit MSVC, due to the fact that its linker required
external dependencies in dead code to be met before dead code
elimination was done, causing linker errors. The proper fix for this
would be to add the necessary dependencies, so I instead simply left
the conditional code in place in winalloc.c and chd.c.
~aa
Original submission email below:
----
Conditionally compiled code tends to bitrot, so MAME should try to
avoid it as much as possible. I sent a patch six months ago to
eliminate conditional code associated with logging, here's another
patch that does more of this. Some notes:
1. drc_ops.c: I couldn't find a LOG_CODE anywhere, so I used if (0).
2. romload.c: I converted all the users of debugload to use
LOG((...)) instead, following the traditional conditional logging
pattern.
3. windows/sound.c: I eliminated the separate sound log and directed
the few outputs to the error log.
~aa
Subject: [patch] .data removals to fix reset/multisession bugs
Hi mamedev,
One nice artifact of properly constifying data structures in MAME is
that it makes it relatively easy to spot a class of reset/multisession
bugs, namely that almost any object in .data is probably in error.
Unless the value is properly initialized in a reset routine the
initial non-zero value can't be relied upon, so there's no need to
have a non-zero value to begin with.
With that in mind, here's a patch to move more items out of .data by
either applying const, removing the non-zero initializer (if its
overwritten by init/reset) or by adding appropriate initialization
code. In most cases I tried to add initialization code to a reset
routine, but in some cases I chose an init routine, possibly leaving a
reset bug intact.
Some interesting bits:
1. tms9900 core. The use of .data to initialize the irq_level wasn't
correct in some cases as the layout of the structure was core
dependent.
2. bfcobra.c. By introducing a VIDEO_START routine a hack in
VIDEO_UPDATE could be removed.
~aa
Sent: Wed 7/23/2008 8:15 AM
To: submit@mamedev.org
Subject: more input patches
Hi,
with the attached diff I started drivers with C. Added all the missing
tags, made more extensive use of PORT_INCLUDE where possible and added
AM_READ_PORT where suitable. I also added dip locations for: cabal,
canyon, cbuster, cclimber, swimmer and guzzler.
Patch for cave.c is separated in case fix for bug 1681 has been submitted
and accepted (changing maybe the driver)
Regards
Fabio
Sent: Tue 7/22/2008 11:30 AM
To: submit@mamedev.org
Subject: Demon's world set 5
Enclosed another revision of Demon's World (my pcb has the jumpers set
to japan).
I renamed the other sets because in my opinion the code needs to be
studied before saying what's older and newer revisions.
Demon's World / Horror Story (set 5)
Sent: Tue 7/22/2008 11:30 AM
To: submit@mamedev.org
Subject: more tags and AM_READ_PORT
Hi,
with the following patches I added tags to all ports (and used AM_READ_PORT
in the memory maps of all the drivers which didn't) in drivers starting with
B. I also added diplocations and factory settings for the games which had
either a manual or a dips listing at crazykong (and to squaitsa, thanks to
a scan from f205v) [1]. A couple of patches are separated from the main ones
because they contain changes which could need additional review
In details:
* diffB01->diffB07 contains standard addition of tags and AM_READ_PORTS to
driver starting with B (a diff each 4/5 drivers).
* bsktball.diff adds diplocations to the driver, but also removes the fake
handling of P1 Start/P1 Button1. Since other games have no separate P1 Start
in MAME (e.g bagman, or joust2 as noticed in the invalid bug 1734), I
personally see no reason to duplicate inputs in this game.
[1] In details, I added locations to: bwidow.c & bzone.c games, bestleag,
blackt96, bogeyman, bombjack, boogwing, bottom9, brkthru, darwin, buggychl,
squaitsa, btime, bnj, lnc, zoar and disco
Sent: Monday, July 21, 2008 2:16 PM
To: submit@mamedev.org
Subject: fix for MT 2029
I noticed only today the silly mistake which produced the bug passing from 126 to 126u1. Stupid typo.
Attached you find the fix.
Regards,
Fabio
Sent: Monday, July 21, 2008 9:16 AM
To: submit@mamedev.org
Subject: Plotting/Flipull pal dump
The pal was dumped by Charles Mcdonald, I enclose the raw dump, pld and
jed files.
It works perfectly as a replacement on the pcb
Sent: Sunday, July 20, 2008 5:46 AM
To: submit@mamedev.org
Subject: last batch of misc. diffs
Hi,
attached please find a few patches to fix some (trivial) mametesters' bug
and a patch to use whenever possible AM_PORT_READ in drivers starting with
# or A. More in detail
* hypreact.diff 'fixes' bug 1572 on MT (not really a bug, in fact), adding
a better description to inputs only used in Joystick Mode
* alleymas.diff 'fixes' bug 1565 on MT. In this case I'd like some dev to
review the patch: the two duplicate inputs in alleymas are properly detected
also in service mode, so MAME is not wrong as is. Nevertheless, inspired to
the common habit of commenting out duplicate coinage inputs, I decided to
comment them out but leaving them in the source for documentation purpose
* bishi.diff fixes bug 1718 on MT. Duplicate inputs did nothing and the new
inputs are now correct both during the game and in Service Mode
* Finally, portA.diff is a bit more interesting and converts a few driver to
use AM_READ_PORTs and tags. Here and there, I also changed a few tags to e.g. s
tress similarities in the handling which were hidden by anonymous "INn" tags
(see atarifb & atarifb4 for instance)
Regards,
Fabio Priuli
Sent: Saturday, July 19, 2008 7:46 AM
To: submit@mamedev.org
Subject: a few bugfixes (or at least proposals of fix)
Hi,
enclosed please find the following patches for bugs currently
in MAME (sorry for the verbose explanations, but I hope it makes
faster the verification and not to steal too much time to the
reviewer)
correct fixes (IMHO)
* harddriv.diff : Fixes a bug introduced in u7 which broke racedrvc,
hdrivair and their clones (due to some tags not being renamed).
Strange no one has noticed this (not even Firevawe when he ran its
regtest before 0.126!), anyway now it's fixed...
* gstrik2.diff : This patch fixes bug 1568. One of the two service
mode keys doesn't give access to the service mode (and in fact it's
not read at all in the input test in service mode). I changed it to
an unknown dipswitch
* atarijsa.diff : This changes the ports #defined in
src/mame/audio/atarijsa.h to be EXTERNAL_INPUTS (and modifies
accordingly the drivers using them). It allows to remove the SWAPPED
version (modified locally in xybots.c) and it allowed me to fix half
of bug 818 (duplicated coins in stunrun). Indeed, stunrun and steeltal
use their own coin input and the jsa ones are not recognized in
Service Mode. Therefore, I removed them through PORT_MODIFY. @Aaron: I
left in COIN3, even if those games do not use it, maybe it can be made
UNUSED as well
proposals:
* leland.diff : I noticed that the SERVICE MODE key in leland.c games
doesn't do anything service related, but it simply adds a coin. This
patch changes them to IPT_COIN3 (because this is the mapping of the same
inputs for offroad and pigout). Actually, it could be an IPT_SERVICE1
(but I don't have currently access to any manual to verify it) or there
could be a different bug in the driver causing the input to be read as a
coin... If one of the latter options sounds more correct to you, please
change the IPT or ignore this patch.
[Note: this was changed to IPT_SERVICE1]
* pc10.diff: This one fixes bug 595, i.e. Start button in playch10.c is
currently mapped to key "2". This could be by design, but it's a bit
confusing since it works the other way around in vsnes.c. If it was by
design and you don't plan to change it, please post at MameTesters so
that we can close the report as Not-a-bug.
* twotiger.diff : This addresses bug 1448. The wheel is completely
centered for any value in the (closed) interval [0x64, 0x69] (goes to
left for 0x63 and to right for 0x70). I've chosen 0x67 because it's in
between, but I'm not sure 100% about the way analog inputs are managed
in the core, so feel free to use another value in that range if it m
akes more sense than 0x67.
That's all. Thanks for the atention
Regards,
Fabio
Subject: [patch] Fix zr107 multisession issues
Hi mamedev,
The attached patch makes the initialization of various Konami PPC
drivers consistent from run to run, hopefully fixing most multisession
issues. I confirmed that this resolves running midnrun multisession,
but it is possible other issues remain.
The patch also moves some allocations from static to dynamic storage.
~aa
Subject: a last bunch of patches
Hi,
attached please find a last block of diffs which completely removes
every explicit use of input_port_read_indexed from src/mame/ (it
remains in the various input_port_N_r, but I'll move to those later
:) ) and fixes a small input bug
Namely:
nbmj_fix.diff: fixes bug MT 479. livegal turns out to use in a
slightly different way the nichibutsu mahjong panel and inputs in
test mode confirms that my change is correct ;)
patch01.diff -> patch03.diff: convert to use tagged inputs and
handlers the remaining drivers (U to Z and a few others)
taito.diff: converts taitoic.c handlers to use tags (this required
some more re-tagging in a few taito drivers, which I overlooked previously)
namcos22.diff: converts namcos22 read handlers to use tags. I have
been very carefully about where each read handler is used (and adopted
read_safe where necessary), so there shall be no problem with this
(despite the complexity of the driver)
mediagx.diff: finally, I re-submit this patch about mediagx.c. Much more
work would be needed to correctly map inputs for this driver, but I fear
is still a bit beyond my current skills. However, from inspection through
the debugger and from error.log, you can notice that the variable
parallel_latched (used to read inputs) takes values 0,...,23 so this diff
does no harm to the driver and allows to remove also the last occurrence
of input_port_read_indexed!
As usual, I tested as much as I could the changes and I expect no
regressions is introduced
Regards,
Fabio Priuli
Subject: 8257dma
Hi Aaron,
Small changes for 8257.
Fixed terminal count stop for autoload mode and added callback function existance check [Miodrag Milanovic]
Regards,
Miodrag
convert between attotimes and a clock tick at an integral frequency.
Changed the 6532 RIOT device into a proper device. Rewrote the
logic to be simpler and leverage the new attotime functions. Changed
the I/O port setters to specify a mask, and changed the I/O port
callbacks to pass in the previous value. Updated tourtabl and
gameplan drivers to use the new device interface.
Converted audio/starwars.c, audio/exidy.c, and audio/gottlieb.c to
use the new RIOT implementation instead of rolling their own.
Began gottlieb.c cleanup. Converted palette calculations to resistor
weights. Corrected video timing. Reduced the number of separate
machine drivers. Fixed incorrect spriteram sizes. Populated full
memory maps for the main CPU and the rev 1 sound board. More to
come.
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Shinobi III (Mega Play) [Tomasz Slanina, Kowal]
- Rearranged decoding behavior.
- Updated code style to MAME standards.
- Tested each single-word opcode with custom ROMs.
(This is a precursor to other major dsp56k changes I have made. I just gotta' get plygonet commanders up and running to do some tests)
- TGP now correctly uses table roms (model1/2 updated accordingly)
- removed FIFO hack on srallyc (game now runs)
- added analog ports reading for model 2A/B/C
- fixed some loading instructions in the TGP. that fixes srallyc automatic transmission bug
Added validity checks to ensure no duplicate sound or CPU tags.
Fixed several duplicate sound tags from the last checkin.
-listxml now outputs the tag names for CPUs and sound chips.
well, the fix is not that but changing them this way:
program_write_dword_32le(i960.r[I960_FP]-16, i960.PC);
program_write_dword_32le(i960.r[I960_FP]-12, i960.AC);
in take_interrupt.
It seems it came from a partial fix in the ret instruction. the manual says that PC is saved at FP-16 and AC at FP-12
it was reversed in mame, so when trying to fix it, i suppose Ernesto forgot to change the push too.
I've tested this fix and apart from having daytona working, pilot kids 2A works too (that I think has been broken for ages).
MDRV_SOUND_ADD. All sound chips must now include a tag.
Laboriously changed all existing drivers to define a
unique tag for each sound chip.
CPUs are next, but will require a more hands-on manual
process to produce reasonable tags.
properly ignore the "break into debugger" keypress and not allow
related characters to filter through. Removed some hacks related to
making that work in the past.
Changed osd_wait_for_debugger() to take a machine parameter and a
"firsttime" parameter, which is set to 1 the first time the function
is called after a break. The Windows debugger uses this to ensure
that the debugger has focus when you break into it.
