AICA: fix missing instruments in DTPK driver games [R. Belmont, Deunan Knute, kingshriek]
Naomi: unmapped words in the AICA address range must read as zero [R. Belmont]
With these changes Toy Fighter's music is much better.
Sent: Saturday, November 01, 2008 4:14 PM
To: submit@mamedev.org
Cc: atariace@hotmail.com
Subject: [patch] Toaplan2 save state fix
Hi mamedev,
I realized after sending my toaplan2 save state patch that I had
ignored the implications of memory_set_bankptr (grrr). This followup
patch fixes the most significant case of that, I'll fix up the
remaining ones later. Alternately, you can drop the patches for now
and I'll resubmit them later.
~aa
Sent: Saturday, November 01, 2008 11:29 AM
To: submit@mamedev.org
Cc: atariace@hotmail.com
Subject: [patch] State save support for toaplan2
Hi mamedev,
Attached is a small patch to add a toaplan2.h include file and save
state support for the driver. A number of variables changed from int
to specific sizes to support this, and I also fixed a harmless typo in
the mem_mask size.
~aa
Sent: Sunday, October 26, 2008 3:01 PM
To: submit@mamedev.org
Subject: expro02
Hi folk!
Another work in expro02 drive:
- Fixed dips in all galsnew sets and fantasia.
- Added dips location.
- A little drive clean up.
Bye Sonikos
adds/removes entries in header files, and fixes a few potential
multisession issues by explicitly adding initializers. asic65.c has
significant changes to accomodate using a struct instead of 16
variables, otherwise the changes in this patch are modest and obvious.
[Atari Ace]
There's an issue with the debugger handling of the 6502 instructions as
there's a mismatch between the core and what the debugger shows.
The changes are detailed in the spreadsheets that I've attached that
compares the core to the dasm.
Attachments:
m6502fix.zip contains the diff file
6502 debugger disassembly changes.zip contains an excel spreadsheet
(in both xls and xml formats) detailing the reasons/changes.
* bbusters.diff:
- Fixed service mode issues enabling extra RAM that was previously unmapped.
- Properly implemented all sound communications.
- Fixed ID 00387. (there are no sound issues, the bug in my opinion is no more valid)
* nmk16.diff
- Fixed ID 00224. (PCB behaviour verified by Corrado Tomaselli)
* renegade.diff
- Fixed ID 01679. (old code was an hack, cpu_getiloops is more acceptable)
* suprnova.diff
- Fixed ID 02042. (no other games are broken)
* twin16.diff
- Cleaned up a bit code to make it more readable.
- Reorganized CPUs order in all games. (main, sub, audio)
- Fixed ID 02268. (guesswork, a PCB is needed to understand how priorities work)
and removed an unnecessary hack from the driver.Probably one of Arbee's SCSP changes fixed it.
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Virtual Mahjong 2 - My Fair Lady
(i.e. Do not credit me on this)
- Reworked inputs to allow 6 players through a selector.
- Hooked all lamps (even the ball simulator array).
- Added a internal layout and support for external artwork.
- Extended the hardware to support Buena Suerte '94.
- Cleaned up the driver.
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Buena Suerte '94 [Grull Osgo, Roberto Fresca]
Hello, with this patch finally cvs2gd stops looping forever. However with
no 3d emulation nothing is shown on the screen.
Then i have implemented the naomi RTC and there are a few verbose messages
about transfers not implemented yet.
* improved prefetch timing calculation
* prefetch timing now also used by V20 and V33
* moved some static variables into cpu context
* nec_reset now explicitly clears context variables
* all cpus now share nec_execute
Would whoever checked this in double-check my change? I believe I got the intent of the code (which is not how it was written ;-) but I could be wrong.
--This line, and those belo
M disc_flt.c
* The whole startup cycle now works. No more timeouts and erratic behavior.
* lohtb2 will however not display the "Warning" screen due to a priority issue. With color/attribute of 0x80 in videoram at 0xd0000 and 0xd8000, videoram at 0xd80000 will be displayed. Some tilemap guru has to look into this.
Credit Jim (or however he wants his name listed ;-)
Also specifies the difference between the two Ghox sets (in toaplan2.c). One set is 8-way joystick controls and the parent is a spinner with forward/backward single axis control
* Fixed tilemaps paging / tilemap positioning;
* Fixed a protection issue in Mahjong Daireikai,not giving correct colors for the girls in-game;
* Fixed a rom-loading issue in Mahjong Daireikai;
* Fixed 'ZA' sound banking behaviour,this fixes at least the sound in kakumei2;
* Removed VIDEO_EOF and added a TIMER_DEVICE_CALLBACK function for MCU simulations;
* Added WIP code for the priority system;
* Added a NO_DUMP for the MCU for all the sets;
- emulates Braze Technologies addon board
- eeprom hooked up
- implemented bank switching
I am still unsure about whether this should be added or not.
Interestingly, D2K shows a "(C) 1981 Nintendo" copyright message.
Still, it is actively marketed.
Putting this up for discussion again.
- Added sound support to magicfly and 7mezzo.
- Hooked coin counters to magicfly and 7mezzo.
- Inverted the graphics banks to be straight with the hardware accesses.
- Updated the memory map description and technical notes.
- Added game notes and documented the test/settings/bookkeeping modes.
Ruleta RE-900 from Entretenimientos GEMINI.
Is a roulette game based on i8051 and TMS9928, that has a phisical roulette with leds simulating the ball.
Game is working properly with full sound support.
Need better inputs implementation, leds, external artwork for the roulette and technical notes (I'm taking care of them).
If someone want to give a try, turn the operator key to allow enter credits.
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Ruleta RE-900 [Grull Osgo]
Sent: Sunday, October 19, 2008 9:01 AM
To: submit@mamedev.org
Subject: Sound Support for Cosmic Alien
Hello,
I own a cosmic alien PCB and so I thought it would be a good idea to add
sound support
to this game by changing the corresponding driver ("drivers\cosmic.c").
I also have recorded the different sound effects as wave - files.
I have attached two files to this mail. The file "cosmica.zip" contains
the samples
(so it can be simply copied to the "samples" folder) and
the other one "cosmica_diff.zip" contain the "diff" file taken against
the 0128 sources.
So you can check it and maybe you want to implement the changes in a
further release?
best regards
T.Bellm
Sent: Mon 10/20/2008 9:45 AM
To: submit@mamedev.org
Subject: fix for mt 2577
the wrong tags were used for maketrax when indexed inputs were converted to tagged ones (0.125u7): input 2 was 'dsw1' but 'in1' was used. probably a mistake I made. sorry.
regards
Fabio
Sent: Fri 10/17/2008 11:45 AM
To: submit@mamedev.org
Subject: 65c02 core bugfix
Hi,
This patch fixes a subtle bug in the 65c02 emulation where the result of
the BIT instruction differs on the 65c02 (from the 6502), when executed
in immediate mode.
Cheers,
Phill.
Sent: Sunday, October 12, 2008 1:15 PM
To: submit@mamedev.org
Subject: dakkochn gfx improve
Improve dakkochn gfx, the priority are ok but there are various offset so i marked also the game as "inperfect gfx".
Bye Sonikos
Game is now working
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Mirage Youjuu Mahjongden [Angelo Salese]
Created default EEPROM which is required to get it going.
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Super Megatouch IV (9255-41-07 ROG, New Jersey version) [Mariusz Wojcieszek]
Game is now playable
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Double Dealer [Angelo Salese,David Haywood]
* Remaining games checked and adapted to changes in cpu core
* Cardline still broken. I need the exact and complete cpu name.
* Added more variants 803X, 80CXX, AT89C4051
* Fix segas18.c (segaic16.c) mcu maps.
* Fix sslam.c
* Fix limenko.c videopkr.c : Issue with core allocation of ram (duplicate savestate)
Yet another 8-bit Incredible Technologies board. Different in several
significant ways from previous models:
* YM2608B for audio, replacing YM3812+OKI6295
* TMS34070 for palettes instead of PC RAMDAC
* Different video memory layout
* improved serial port timing (f15se (micro3d.c) sound board now works)
* better infrastructure for adding more variants like DS5002
* Fixed port reading
* Rewrote Macros for better readibility
* Fixed and rewrote Interrupt handling
* Now returns INTERNAL_DIVIDER, adjusted cycle counts
* Remove unnecessary and duplicated code
* Remove unnecessary functions
* Rewrite to have sfr-registers stored in int_ram.
* Debugger may now watch sfr-registers as well.
* implemented interrupt callbacks (HOLD_LINE now supported)
* Runtime switch for processor type - remove ifdefs
* internal memory maps for internal rom versions (internal ram now displayed in debugger)
* more timer cleanups from manual
micro3d:
* serial port communication between main cpu and sound board works
* sound board now works
m72 - lohtb2:
* full emulation of protection device
* Samples are now piped through the mcu
* Added additional branch, move and bitfield ops.
* Plygonet now passes its memory test and uploads a new program.
[[Next step is to install an opbase handler and let the dsp56k run further into its new proggie.]]
Game is now playable
New games added or promoted from NOT_WORKING status
---------------------------------------------------
(Medal) Yumefuda [Bet] [Angelo Salese]
* Complete rewrite focusing on legibility and extensibility.
* 27/121 opcodes (mostly) implemented.
* Bugfix for reset status of interrupt priority bits.
* Bugfix for disassembly of register-to-register parallel data move.
[[These changes bring the driver up to the point where the plygonet hardware begins banking memory. The behavior is understood, so I should have the driver back to where it was before the rewrite soon. Then real progress can be made.]]
(also added a to-check note, 16-bit wide DMA is currently using 32-bit functions, is this correct?)
Removed Speedups from CPS3 / PsikyoSH, while they do still give a decent speed boost they're not really needed with the DRC and just clutter the code.
Sent: Saturday, October 11, 2008 12:01 PM
To: submit@mamedev.org
Subject: 6821 PIA changes
Hi,
Can this change be added to the 6821 pia code, it adds a function that
allows the client code to get the status of CA2, taking account of the
internal pull up resistor. This code only adds a function and does not
change any existing code so should not have any impact on existing
drivers.
This change is needed for a couple of the mess drivers.
Thanks.
Phill.
--
Phill Harvey-Smith, Programmer, Hardware hacker, and general eccentric !
Game is now playable.
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Good [David Haywood,Angelo Salese]
comments mentioning duplicate dips configurations. Not fully understanding
how the FREE PLAY was implemented, I left that not to show a location.
This .DIFF is based on 0.127u7 sources.
Tafoid
tafoid@yahoo.com
- Added discrete sound support to Golden Poker hardware games based on schematics.
- Added discrete sound support to Potten's Poker hardware games based on PCB analysis.
- Added discrete circuitry diagrams for both hardware types.
- Adjusted the CPU adressing to 15 bits for pmpoker/goldenpkr hardware.
- Adjusted the CPU adressing to 14 bits for pottnpkr hardware.
- Rewrote all the ROM loads based on these changes.
- Defined MASTER Xtal & CPU clock.
- Fixed the visible area based on M6845 registers.
- Improved the lamps layouts to be more realistic.
- Added Good Luck (potten's poker hybrid running in goldnpkr hardware).
- Added Buena Suerte (spanish) x 2 sets.
- Added set Royale.
- Added Witch Card and spanish variants.
- Added Super Loco 93 (spanish) x 2 sets.
- Renamed set goldnpkc to pottnpkr (parent Jack Potten's Poker set).
- Renamed set jokerpkr to potnpkra, since is another Jack Potten's Poker set.
- Added other 2 clones of Jack Potten's Poker.
- Renamed/cleaned all sets based on code/hardware analysis.
- Added intensity bit to the color system.
- Implemented the blue killer bit for Witch Card hardware.
- Implemented the extended graphics addressing bit for Witch Card hardware.
- Added proper visible area to sloco93.
- Rewrote the graphics & color decode system based on schematics. No more patched codes.
- Changed the char gfx bank structure and rom load according to the new routines.
- Adjusted the amount of color codes and PROM region size accordingly.
- Updated all notes.
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Good Luck! [Roberto Fresca]
Buena Suerte! (spanish) [Roberto Fresca]
Witch Card (english) [Roberto Fresca]
Super Loco 93 (spanish) [Roberto Fresca]
New clones added
----------------
Jack Potten's Poker (2 sets) [Roberto Fresca]
Witch Card (spanish)(2 sets) [Roberto Fresca]
Buena Suerte (spanish, set 2) [Roberto Fresca]
Super Loco 93 (spanish, set 2) [Roberto Fresca]
New games marked as GAME_NOT_WORKING
------------------------------------
Royale [Roberto Fresca]
added comment about other roms on this hardware. (anonymous)
-----------
(testing the water, if Arika aren't happy with comments mentioning them, then there isn't much chance of them ever being supported, seems smarter than just adding them outright)
Affected files:
mame\src\mame\drivers\neodrvr.c
mame\src\mame\includes\neogeo.h
mame\src\mame\machine\neoboot.c
mame\src\mame\machine\neoprot.c
Changes:
. Completed general cleanup
Sorting OEM / bootleg sets
Renaming roms on non OEM / bootleg sets to ONE naming sheme
Renamed functions
Cleaned up bootleg sets
Added some comments
Renamed sma in garou/garouo, added comment
Fixed several things in the jalmah.c driver:
*Fixed Mahjong Daireikai pseudo-random number generator;
*Fixed Otogizoushi Urashima Mahjong to make it playable;
*Fixed a start-up crashing bug in mjzoomin/urashima/daireika
MAMETesters Bugs Fixed
----------------------
- 01820: [Crash/Freeze] mjzoomin: Game stops at PCB test (Angelo Salese)
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Mahjong Daireikai [Angelo Salese]
Otogizoushi Urashima Mahjong [Angelo Salese]
Sent: Tue 10/7/2008 10:45 AM
To: submit@mamedev.org
Subject: snes special chips emulation
Hi,
the attached patch adds emulation for snes special chips DSP-2 & OBC-1. Changes:
- added sources snesdsp2.c & snesobc1.c (directly included in machine/snes.c as per Arbee's guidelines). credits mostly goes to byuu, which released to Public Domain his sources
- removed special chips detection from MAME (no nss / bootleg carts have special chips so far) and only left a variable has_addon_chip whose possible values are in includes/snes.h (it is initialized to HAS_NONE for MAME games)
- modified memory handlers to account for the new chips
Regards
Fabio
Sent: Sunday, October 05, 2008 1:46 PM
To: submit@mamedev.org
Subject: 2 small patches
Here are two small patches.
The first one remove a profiler_mark that has been forgotten in one of
the
last update in the tx1.c video driver.
The second is a small speed up in the neo-geo driver which gives a 0.5%
speed up on my machine.
- replace a loop with an equivalent memset
- remove a useless parameter I forgot to remove in a previous patch
Hope this help.
Best regards,
CJ
- Reworked the button-lamps matrix system.
- Documented both output ports.
- Connected coin in, key in and payout counters.
- Improved the lamps layout to be more realistic.
- Updated technical notes.
Sent: Sunday, October 05, 2008 3:46 AM
To: submit@mamedev.org
Subject: Delete previous submission! Space Duel: Add the P10/11 dip
switch
Delete previous submission! Functionally the same, just reordered
some source and added a comment. Thanks!
Space Duel: Add the P10/11 dip switch (only 4 switches instead of the
standard 8)
Let me know if you have any questions.
Franklin
> Sent: Saturday, October 04, 2008 10:16 PM
> To: submit@mamedev.org
> Cc: ANY
> Subject: Some stuff
>
> Diff aganist 127u6
>
> New stuff
>
> Mk3 p4.0 (revision 1.0 in test menu, but marked P4.0 on chip label)
> Decathlete V1.001
>
> revisited stuff
>
> Gpworld brake-gas issue should be fine, I cannot enter into the test
> menu to
> find out is gas is gas and brake is brake or swapped
>
> Thanks Andrea
Note that this is caused by leaving entries in the bitmap
with an index larger than the palette size. This is forbidden
and now can lead to a crash in debug builds.
Added preliminary LD-V1000 emulation. Not fully working yet, but mostly
there.
Cleaned up and normalized the three existing laserdisc emulations.
Removed obsolete code from the laserdisc core.
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Sonic Blast Man 2 Special Turbo (SNES bootleg) [Andreas Naive, Tomasz Slanina]
- Added Baby Poker Game.
- Added sound support to Baby Poker Game.
- Reworked the color routines.
- Added Baby Dado Game.
- Added new color routines for Baby Games.
- Redumped the videocba color PROM.
- Added color switch. (It changes background color in some games).
- Added "hopper full" switch support (for diverter function).
- Added diverter function decoder.
- Added full functional mechanical counters decoding.
- Added 7 Segment decoder and 7 Digit Counter functions.
- Added button-lamps layout & mechanical counters simulation on layout.
Mechanical counters to layout: Coin-In, Coin-Out and Coin to Drop.
- Added NVRAM support to mechanical counters.
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Baby Poker [Grull Osgo, Roberto Fresca]
Baby Dado [Grull Osgo, Roberto Fresca]
still not really convinced by this conditional dip stuff.. it stands no chance of working on games where the coinage mode is in eeprom... (but i have no better suggestions)
02483: gunlock, rayforcj: Title screen trouble
02482: bubblemj: Demonstration screen trouble
* Check for whether tile is opaque must honour extra planes.
- added rom decryption
- patched protection checks
- mapped extra inputs
Game is not playable due to heavy gfx glitches caused by bugs in SNES hw emulation.
[Andreas Naive, Tomasz Slanina]
* added missing button mappings
* corrected dip switch
This seems to be a prototype. The number of remaining ships displayed is not correct.
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Astropal (Sidam?) [Couriersud]
Affected files:
mame\src\mame\drivers\neodrvr.c
mame\src\mame\includes\neogeo.h
mame\src\mame\machine\neocrypt.c
mame\src\mame\machine\neoboot.c
Changes:
. Begin of a general cleanup
Sorting OEM / Bootleg sets
Renaming roms on non OEM / Bootleg sets to ONE naming sheme
Renaming functions
Added some comments
Cleanup is not completed.
configuration builder to use these functions. Also changed the laserdisc
player devices to use them. Updated Z80 CTC/SIO code to assume that the
CPU provided for the clock is relative to the device that the CTC/SIO
belong to. Updated memory code to assume that regions and devices
referenced by the memory map are relative to the device the associated
CPU belongs to.
Readded UI_ON_SCREEN_DISPLAY to be changed again in the "Inputs" menu as per Aaron's request.
A clean build is required and cfg/default.cfg has to be deleted !
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Megatouch 5 (9255-60-07 RON, New Jersey version) [Brian Troha]
New clones added
----------------
Megatouch III (9255-20-07 ROG, New Jersey version) [Brian Troha]
Super Megatouch IV (9255-41-07 ROG, New Jersey version) [Brian Troha] (Not Working)
Sent: Mon 9/29/2008 9:45 AM
To: submit@mamedev.org
Subject: Small SNES changes
Hi,
enclosed please find a patch which changes a bit the way SNES
carts (NSS & bootlegs) are loaded at init time. Currently, data
are loaded once at start and then the read handlers perform various
mirroring tricks. With the attached patch, the cart is loaded at
init and mirrored as many times as it is necessary, while handlers
simply read from the plain offset. Also, blocks of data are mirrored
until they fill all the available banks. Implementing this behavior
both simplifies the handlers code and is more faithful to the hardware
(see mirroring note included in the DRIVER_INIT).
I also slightly changed some handlers to take into account the new
mirroring system. OTOH sram_handlers haven't been updated (they will
be eventually) because with carts as small as the ones in nss.c and
snesb.c, they basically have no overlapping with the new mirroring
approach... as soon as I come up with a satisfactory implementation
that works in MESS (which has to deal with much larger carts), I will
also submit the MAME side.
No regressions appear with the patch, as far as I could test.
Regards
Fabio
--
From: Fabio Priuli [mailto:doge.fabio@gmail.com]
Sent: Wednesday, October 01, 2008 12:01 AM
To: submit@mamedev.org
Subject: further snes changes
Hi,
enclosed please find a patch which rewrites memory handlers in
machine/snes.c to take into account the additional cart/memory layouts
(mode 22 & 25) which were available for the home console (almost no
impact on nss.c & snesb.c, which only use mode 20 & 21). rather than
only add a bunch of if(snes_cart.mode == XXXX), I preferred to slightly
rewrite the handlers. main changes on the MAME side are:
* merged regions 0x700000 up to 0x7dffff in snes_map (this allows to
make memory maps in nss.c and snesb.c identical: the zone previously
NOPed in nss.c is now handled by snes_r_bank5, because it was not
reserved for all cart types)
* split region 0x800000-0xbfffff from 0xc00000-0xffffff in snes_map.
This simplifies a bit handlers used by MAME and it will be necessary
when MESS supports special chips like SDD-1 (which dynamically changes
the part of cart loaded in the latter region)
* slightly enlarged SRAM regions (in this case, it only affects what
happens inside the handler, NOT snes_map) to support carts with 512kbits
of SRAM (e.g. Thoroughbred Breeder III for MESS). I'm still not 100%
satisfied with SRAM mirroring, but this is closer to the real thing
than the previous way to handle it
No regressions are present, neither in MAME nor in MESS, as far as I
could test (well, for MAME weren't expected, since most changes affected
mode 22 & 25).
Regards,
Fabio
Sent: Sunday, September 28, 2008 6:01 AM
To: submit@mamedev.org
Subject: System1 Dips Location
Hi folk!
I continuing the work on System1
- Added dips location in all game
- Moved in generic Cabinet dip for eliminate the redundancy
- Better implementation of generic input
Bye Sonikos
Sent: Friday, September 26, 2008 11:01 PM
To: submit@mamedev.org
Subject: fix for sbasketb
As pointed out by ShimaPong on mameworld forums, dips are
read in the wrong way in sbasketb.c. It seems that when
DipLocations were added, the tags were changed in the input
ports but not in the memory map.
The enclosed patch fixes this regression
Regards,
Fabio
Sent: Fri 9/26/2008 10:15 AM
To: submit@mamedev.org
Cc: Philip Bennett
Subject: fix for Cube Quest Line CPU emulation
I found a bug in the emulation of the Cube Quest Line CPU.
Proof of bug:
After looking at .diff,
Assume 'ci' is 1, and assume 'r' and 's' are both 0xFFF
(0xFFF equals -1, as these numbers are 12-bit signed).
The result should be mathematically equivalent to -1 - (-1)
which is 0.
~0xFFF is 0xF000, so you'd have 0xF000 + 0x0FFF + 1 which equals
0x10000 but since 'res' is 16-bits this is truncated to 0x0.
'C' then becomes 0 and 'V' becomes 1 (as I recall). The result of
0 is correct, but the flags are wrong; V should be 0 and C should
be 1.
Under my proposed fix, you'd have 0x000 + 0x0FFF + 1, which equals
0x1000, so the lower 12 bits are 0 (correct) and C is 1 and V is 0
(correct).
I discovered this bug while disassembling the line CPU's ROM.
means that multiple changes without any execution will be seen as
atomic. It also means that PULSE_LINE no longer works for signalling
IRQs.
Added checks in the debug build to catch people who try to use
PULSE_LINE for non-NMI and non-RESET input lines on CPUs that no
longer support direct interrupt generation. Over time expect this
list to increase.
machine/device handlers. Unfortunately, the implementation relies on
sentinel values to distinguish a port tag versus a pointer to function
code. However, since this is a very common situation, it will hopefully
be worth the slight grossness. New macros are defined in inptport.h:
DEVICE8_PORT(name) - use this to specify the name of a port to read
wherever a read8_device_func would normally be used
MACHINE8_PORT(name) - same as DEVICE8_PORT except it can be used
wherever a read8_machine_func would normally be used
IS_HANDLER_PORT(ptr) - accepts a read8_device_func or read8_machine_func
and determines if it is an actual function or a reference to a port;
intended for use by devices that accept DEVICE8_PORT-style functions
CALL_DEVICE8_READ(ptr,device,offset) - either calls through the given
read8_device_func, or calls input_port_read with the appropriate
tag, depending on the result of IS_HANDLER_PORT; intended for use
by devices that accept DEVICE8_PORT-style functions
CALL_MACHINE8_READ(ptr,machine,offset) - same as CALL_DEVICE8_READ
except for read8_machine_func
Note that in order for these to be useful, the consumer of the function
pointer must be enhanced to use the CALL_* macros above instead of directly
calling through the function. So far, only the 8255 PPI is set up to do
this, as part of the cleanup below. Also note that the sentinel value is
currently 4 consecutive 0 bytes; this may need to change in the future, in
either length or value, so it is important to stick to the macros above.
8255 PPI interface cleanup:
- added MDRV_PPI8255_ADD, MDRV_PPI8255_RECONFIG and
MDRV_PPI8255_REMOVE macros; updated all drivers to use them
- changed callbacks to device read/write handlers intead of
machine read/write handlers; updated all drivers accordingly
- normalized function and variable names to be lower_under
- removed a number of redundant interfaces from the galaxian/
scamble line of games
LD-V1000: added some (compile-time removed) information about the
ROM and memory map
* Hooked up 6845
* Hooked up lscnblk line
* Fixed Phraze Craze gfx rom ordering
* Clocks from schematics
* Ram palette moved to static var. This should not be in RAM.
* Added save state support
New Clones
----------
Capcom Sports Club (EURO 971017) [Corrado Tomaselli]
This is newer than any of the other sets, it probably fixes the euro specific crash in the special extended bonus round (at a guess)
expro02.c
- fixed DIPSW
- added graphics decode routine (probably it can be simpler)
video/kaneko16.c
- tilemap scroll position is different for expro02, so added new
function (is it better to fix current one?)
TODO
- in gfx data banking function (newly added), some strange gfx are shown.
Timing issue?
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Gals Panic (US, EXPRO-02 PCB)
Added new item to the interface which is the tag of a CPU
to take the base clock from. Are there any known cases
where the base clock does NOT come from the CPU directly?
Changed Z80 daisy chain interface to simply be a list of
devices in the chain. Interrupt callback functions are now
fetched via the standard device interface and referenced by
the daisy chain code.
Changed Z80 PIO interrupt callback to pass a device instead
of the machine. All device callbacks should provide the
device.
decoded VBI data. Added plumbing for allowing for overall brightness/
contrast/gamma corrections on laserdisc video. Fixed bug when combining
brightness values in the palette logic.
deprecat.h.
Changed render_texture_set_bitmap() to accept a palette object
instead of a palette index. The renderer remains optimized for the
system palette but will work if objects have their own palette as
well.
Changed renderer to permit palettes for RGB and YUY textures. If
specified, these palettes specify a 32-entry (RGB15) or 256-entry
(others) lookup for applying additional brightness/contrast/gamma
on a per-texture basis.
Removed rescale notification. It never really worked that well and
violated proper layering.
Renamed palette_set_brightness() to palette_set_pen_contrast() for
clarity.
Changed palette objects to support global brightness/contrast/gamma
in addition to per-group and per-entry controls.
- uses back-end decoding for CHDs directly to bitmaps
- changed min/max detection to only check 0/255
- fixed off-by-one bug in min/max computation
- separated white code detection from frame number detection
- track cadence with frame numbers as well as white codes
- use vbiparse.h constants where appropriate
- UI_ON_SCREEN_DISPLAY (there is now a "Slider Controls" menu)
- UI_ADD_CHEAT, UI_DELETE_CHEAT, UI_SAVE_CHEAT, UI_WATCH_VALUE, UI_EDIT_CHEAT, UI_RELOAD_CHEAT (these keys belonged to the old cheat engine)
A clean build is required and cfg/default.cfg has to be deleted !
- fix Mantis bug ID 02323 (this might not be the best way though).
- reworked 'geebee', 'navarone' and 'warpwarp' INPUT_PORTS definitions by using conditional Dip Switches.
- added 'geebeeb' INPUT_PORTS definition (this game has specific "Replay" settings).
palette.c to preserve the alpha when transforming palette values.
These changes should be transparent to almost all drivers and rendering
(ha-ha), but there may be an occasional instance where a driver relied
on the alpha being 0 in the system palette. This also means that the
palette_set_color() function preserves any alpha value that is set.
Changed Firefox to RGB32 to allow for mid-screen palette changes. Because
of the above change, the hacky alpha manipulation that was previously
required is no longer necessary; the alpha is set directly in the palette
entry.
(Guru, can you check that ms5pcb you have, the roms in MAME are now marked as NO DUMP)
Updated Neo-Geo game pcb infos
2020bba: Marked MVS and AES version
sonicwi2: Added correct sized v2
kof95 / kof95a:
. Renamed kof95 to kof95h
. Renamed p1 to correct chip label
. Added note
. Renamed kof95a to kof95
. Renamed p1
samsho3 / samsho3a:
. Renamed samsho3a to samsho3
. Renamed samsho3 to samsho3h
. Renamed p1 to correct chip label
. Marked AES version
kof98 / kof98n:
. Renamed m1 in kof98 to correct chip label
. Renamed m1 in kof98n to correct chip label
(kof98n should be latest revision, cart had very high SN 1xx.xxx)
kof97: Marked MVS version
samsho5 / samsho5h:
. Correct text layer size
. Marked samsho5h AES version
neogeo:
. Updated system set to what is found on NEO-MVH MV1FS
. Added note
ms5pcb:
. Hooked up bios dip
. Renamed bios to correct chip label
. Renamed p1 / p2 to correct chip label, marked NO_DUMP
. Added note
compared to other emulator (i.e. kawak), mame does not perform very well in
terms of speed of emulation against Neo Geo games.
Looking at profiling data for these neo geo games, we can see :
---------------------------------------------------------
% cumulative self self total
time seconds seconds calls s/call s/call name
18.40 18.80 18.80 971070 0.00 0.00 video_update_neogeo
10.42 29.45 10.65 4416 0.00 0.00 texture_set_data
10.06 39.73 10.28 1144463 0.00 0.00
sprite_line_timer_callback
6.24 46.10 6.37 187970965 0.00 0.00 astring_cmpc
3.77 49.95 3.85 35732143 0.00 0.00 memory_region
---------------------------------------------------------
I was wondering why functions like 'astring_cmpc' and 'memory_region' where
in the top 5 of the most time consuming functions.
The answer is found in the function 'draw_sprites' from
'mame/video/neogeo.c' where 'memory_region' is called for each sprites for
each VIDEO_UPDATE.
I patched mame in order to keep track of this 'memory_region'. This is done
in VIDEO_START via a global variable (region_zoomy) just like in some other
drivers.
Sent: Thursday, September 25, 2008 3:15 AM
To: submit@mamedev.org
Subject: using macros in UI message
This patch changes the message, that appears when no roms have been
found, to use the macros instead of hard-coded strings
Sent: Wed 9/24/2008 2:00 PM
To: submit@mamedev.org
Subject: Speed up fillbitmap
Hi,
there are many places in mame which make use of "fill_bitmap" or the
equivalent "fillbitmap"
An optimisation is done when the depth of the bitmap is 16 or 32 bpp and
when the UINT16 or UINT32 corresponding to the color is composed of same
bytes (i.e 0xffff for example). This is usefull because most of the calls
are for color 0 (black).
In all other cases, the bitmap is filled one pixel at a time using a loop
with a code like :
================
for (y = fill.min_y; y <= fill.max_y; y++)
{
UINT16 *destrow = BITMAP_ADDR16(dest, y, 0);
for (x = fill.min_x; x <= fill.max_x; x++)
destrow[x] = (UINT16)color;
}
================
However, each rows of the final bitmap will be the same. So I modified this
simple assigned to work as follow :
1) fill the first row one pixel at a time
2) fill all the other rows by copying the first one.
This makes us use memcpy instead of a hard coded loop for most of the
filling process.
Sent: Tue 9/23/2008 1:16 PM
To: submit@mamedev.org
Subject: More naomi ...
Hi.
This patch shows the contents of the framebuffer if the 3d accelerator is
not used so that now the atomiswave logo and messages are shown (if you
wait enough).
Removes a maple bug (no more strange messages in cvs2gd).
Improves documentation of the communication registers with the dimm board.
And if DEBUG_VERTICES is defined as 1 the vertices sent to the tile
accelerator are collected and then drawn connected by a segment to give a
wireframe-like view of the scene.
Bye,
Samuele Zannoli
Sent: Tuesday, September 23, 2008 4:46 AM
To: Aaron Giles
Subject: 8080 bug
To fix this bug : http://mametesters.org/mantis/view.php?id=2322
a part of my code should be removed.
It seams that this feature I have added is only available on KP580BM80A (Russian clone of this processor).
So until I make a new patch (that support this clone processor) please apply this to fix MAME drivers.
Thanks,
Miodrag
Sent: Mon 9/22/2008 3:15 PM
To: submit@mamedev.org
Subject: Better Input clean in system1
I've re-made the job better than last time (i hope), clean up the inputs in system1, next time i'll fix all dips location.
Bye Sonikos.
Sent: Sunday, September 21, 2008 10:45 AM
To: submit@mamedev.org
Cc: atariace@hotmail.com
Subject: [patch] More static qualifiers
Hi mamedev,
Another static function update from yours truly, almost entirely
affecting code added in the last few months to MAME. The fixes are
the usual lot, changing enum definitions so they aren't declared,
decorating dead code/declarations with #if...#endif, and of course,
adding static where appropriate. In addition, I fixed a bunch of
UNUSED_FUNCTON symbols to be spelled correctly (I didn't introduce
this).
~aa
Sent: Thursday, September 18, 2008 6:01 AM
To: submit@mamedev.org
Subject: fix for MT 2252
1 line fix (silly mistake that I was sure I had fixed BEFORE sending the patch) :(
Regards,
Fabio
---
From: Fabio Priuli [mailto:doge.fabio@gmail.com]
Sent: Friday, September 19, 2008 1:15 AM
To: submit@mamedev.org
Subject: Fix for MT 2258
Regressed in 126u3 due to a wrong tag. Fixed.
Fabio
---
enclosed please find a patch which makes non-static two pointers to i/o handlers and includes them in megadriv.h. This makes possible for external drivers (in particular MESS genesis emulation) to define elsewhere their own input handlers and to feed them to the megadriv.c routines.
---
From: Fabio Priuli [mailto:doge.fabio@gmail.com]
Sent: Mon 9/22/2008 2:15 PM
To: submit@mamedev.org
Subject: fix for MT 2254
Hi,
enclosed please find a patch which fixes bug 2254. Tags were switched. Thanks to Haze for noticing the root of the problem.
Regards,
Fabio
fine and basic searching/playback/skipping is functional. Still a bit
glitchy.
Firefox improvements:
- removed need for deprecat.h
- memory map is complete from schematics
- gutted laserdisc hacks in favor of actual laserdisc implementation
- fixed all CPU and sound clocks
Removed old laserdsc.c implementation.
Added generic timer devices, which simply allocate a timer but don't
prime it. This is the preferred method for allocating timers, and may
eventually be the only mechanism for doing so in the future.
System 23:
* Added Rapid River readme
* Adjusted Gorgon h/w MIPS clock to 133 MHz based on readme
* Renamed GP500 to 500GP, which is it's correct name
Game Cristal:
* Use correct BIOS [f205v]
Uploaded to roms/current/g.
Includes mamedriv.c I missed with the System 23 checkin.
New games marked as GAME_NOT_WORKING
------------------------------------
GameCristal (version 2.613) [ANY, f205v]
* Fixed text layer to show (colors are wrong)
* Added very preliminary support for Gorgon h/w
* Added Rapid River and an alternate Time Crisis 2
New games marked as GAME_NOT_WORKING
------------------------------------
Rapid River (RD3 Ver. C) [Guru, R. Belmont]
Time Crisis 2 (TSS2 Ver. B) [Guru]
* Removes arbitrary opcode groupings in favor of flat decode model.
* Fixes a number of small issues with unknown opcodes.
* Added the final ALU parallel move ops.
I've ported Andreas' code over, it doesn't work for ms5pcb, there is probably an additional lineswap or something, I've asked him to look at it. Some of the bootlegs are still using decrypted roms but that should be correct IMO.
Sent: Thursday, September 18, 2008 6:01 AM
To: submit@mamedev.org
Subject: fix for MT 2252
1 line fix (silly mistake that I was sure I had fixed BEFORE sending the patch) :(
Regards,
Fabio
Sent: Wednesday, September 17, 2008 10:31 PM
To: submit@mamedev.org
Subject: Shadow Force clocks
Verified cpu clocks and corrected/verified OKI M6295 frequencies and pin
7 status. Updated Xtal.h file
Sent: Sat 9/13/2008 5:15 PM
To: submit@mamedev.org
Cc: atariace@hotmail.com
Subject: [patch] Make NBA Jam TE a set
Hi mamedev,
This patch treats NBA Jam TE versions as a set, rather than treating
them as clones of NBA Jam. The treatment of sets varies throughout
MAME, this choice is emphasizing the fact that the games were distinct
from NBA Jam, with different marquees et cetera.
~aa
After adding these, I downloaded all manuals for the driver (couldn't find a
Boulder Dash manual) and I validated the DIPs with the manual and ensured that
the service mode (when available) matched up as well. I also added DIP
LOCATIONS for all sets in the driver. There were also a couple DIP items set
up in the source which did not show in the manuals I obtained - so I noted
these facts in the driver.
This .DIFF is based on 0.127u3 sources and resolves MAMETesters Bug #01897.
Tafoid
tafoid@yahoo.com
due to bad roms had a fully working service mode. I also noticed the DIP
locations were well documented on-screen and differed some from the ones in
source. I took the time to read up on how to assign DIPs correctly - but I was
frustrated initially thinking I didn't understand it. I spoke to ETABETA about
this and it seems I picked an uncommon game/driver which doesn't have normal
mapping locations (for whatever reason) and that I'd need to find out what each
value is actually doing. As a result and some work and some more help - I was
able to understand how to do this and reworked the DIPs to what is output in the
service mode for all games (except for Revenger) which did not work enough at all.
While I was there, I added DIP LOCATIONS for all sets. I would assume this
eventually benefit from a PORT_CUSTOM implementation.
This .DIFF is based on 0.127u3 sources.
Tafoid
tafoid@yahoo.com
Sent: Monday, September 15, 2008 5:31 AM
To: submit@mamedev.org
Subject: Patch for new dumps
Hi,
I have attached a patch which adds support for the following;
* The "Three Wonders (Hack?)" dump from the EMMA dumping team (I'm not
100% sure of the CPS B-ID this should use)
* The "Marvel vs. Capcom (Euro 980123)" dump by bonky_0013 (this becomes
the parent set).
Regards,
Barry Harris
installing a handler in the SOUND_START function.
02249: All Sets in zn.c: Game Hangs
02248: All sets in m58.c: No sound in game
02241: kncljoe, kncljoea: Missing AY-3-8910A sound effects.
02240: All Sets in namcos12.c: Game Freeze
02239: stunrun: No OKI6295 sound.
metadata with pre-decoded frame information. Modified chdman to
automatically produce this for CHDs that are of the appropriate
parameters. To fix up existing CHDs, use chdman -fixavdata on the
CHD.
Modified the laserdisc core to leverage the pre-decoded frame
metadata, which is now required. This improves seek times when
searching and allows the player-specific emulation access to the
VBI data as soon as it would really be available. Changed update
callback timing to fire just before the first line of VBI data
would be read; at that point, the frame selection is assumed to
be committed.
Converted PR-8210 emulation over to using the actual MCU from the
laserdisc player. This MCU controls low-level functions such as
slider position and laser on/off, and receives decoded vertical
blanking data in order to make decisions. Removed old HLE behavior.
Note that the overlay text is displayed via the UI; this is
temporary and will be fixed shortly.
Converted Simutrek-hacked laserdisc emulation to using the actual
MCU from the game, which in turn hands off commands to the PR-8210
MCU. This is still not 100% but is pretty close at this point and
achieves the correct behaviors in most cases.
Fixed Cube Quest overlay scaling to cover the whole screen.
Changed laserdisc video parameters to position the screen area at
the bottom rather than the top, since this corresponds more closely
to standard line numbering.
Extended the vbiparse code to support pack/unpack, and to more
fully document all the meanings of the VBI codes.
Updated ldplayer to support slow/fast forward movement, frame/chapter
display, and separate controls for scanning/stepping.
Added new built-in variable "frame" to the debugger.
Fixed device-based ROM loading to support loading ROMs from the
game's ZIP as well.
Full controls, plus complete DIP switches and port locations. Promoted to working.
This set has adjustable prize.
New clones added
----------------
Hot Mind (adjustable prize) [David Haywood, Roberto Fresca]
- Added new clone: Pool 10 (italian, set 4).
- Improved lamps layout for all games.
- Added Pool 10 pinout and DIP switches info.
- Updated technical notes.
New clones added
----------------
Pool 10 (italian, set 4) [Roberto Fresca]
True world set with World, USA & Canada, Korea, Hong Kong, or Taiwan
Minor clean up of port include dipswitch defs
New clones added
----------------
Tengai (World) [Jet Black / Tormod]
Subject: Several patchlets
ledutil.diff
- checking if memory is allocated before using it is good, freeing what
has
been allocated in the error path is better
and added an empty BIOS driver for it.
Here is a patch file with the following changes:
* Added new Atari System 1 Motherboard BIOS dump from a LSI motherboard
* Added a new ROM dump from a Marble Madness LSI Cartridge
* Changed the hardcoded MHz values in the Cave driver to the XTAL
equivalents
* Updated the Cave driver for the game Guwange with gals that need to be
dumped
* Updated the Jail Break driver with the dip locations
* Corrected the Jail Break driver sound chip from a SN76496 to a SN76489
* Corrected the Jail Break rom names
* Redumped the Jail Break VLM rom dump
* Corrected the Super Basketball Revision H rom dump
* Updated the Super Basketball driver with the dip locations
* Corrected the Super Basketball VLM XTAL
* Corrected the Super Basketball parent/child relationships by making
the
Revision H the parent
* Turned on save state support for the Super Basketball driver
* Updated the Sega System 1 driver with more board information on the
Choplifter bootleg and updated the placeholders for the pals that need
to be
dumped
* Updated the WWF Wrestlefest driver rom names
* Added save state support to the WWF Wrestlefest driver
Subject: mametesters bug #614
Please find attached fix for bug 614
acceleration pedal now on up/down key.
It makes sense that the "down" key means push pedal down and "up"
means lift pedal up, however I am unsure that this is what the player
may expect.
http://mametesters.org/mantis/view.php?id=614
Best regards
Mike
Subject: [patch] Even more reset/multisession cleanup
Hi mamedev,
These two patches try to reduce the amount of variable in .data, which
usually point to multisession/reset bugs or missing const qualifiers.
The first patch just adds const to a number of items, moving them from
.data to .rdata. The second patch sets other items to zero (moving
them to .bss), adding reset/init code where appropriate.
~aa
Found few things not right in 8080/8085 implementation.
1. ANA/ANI instruction, HF flag was not set right because error in calculation of it (missing brackets)
2. 8080 have NF flag always set (it is not used flag but bit is always set)
3. On unused ports/not connected memory values from status word were readed not 00 or FF, that is why I add it as a new internal register, it can also be buffered by some external hardware, so this could help other implementations too.
Regards,
Miodrag Milanovic
the driver's memory maps.
Reverted recent changes to MCS-48 core that were very hacky and which crashed
many games. You can now properly override the internal memory map and do
your own banking.
Also fixed 02204: masao: Memory bank error.
- Simulated the MCU communication/protection.
The game seems to work properly, but is hard to win.
I conserved the game flags till we have the MCU decapped,
and emulated properly.
- Added full sound support.
- Added lamps support + layout.
- Fixed memory maps.
- Documented Super Derby outputs.
- Added lamps support + layout to Super Derby.
- Fixed the phisical RAM size to all games.
- Fixed the wrong NVRAM size to spacewin (16Kb instead of 16KB).
- Added proper NVRAM to sderby and pmroulet.
- Added the missing 3rd input to pmroulet (needed for 3-button mode).
- Cleaned up the driver.
for this new support to work.
Clickable input support. Mostly by Nathan. A few changes from the
proposal:
* as far as the layout is concerned, states are 0 (off) or 1 (on) and
aren't impacted by the port's ACTIVE_HIGH or ACTIVE_LOW
* instead of checking each individual field for a hit, we look to see
what is hit once per frame and then just check against that; this
is faster, but does limit us to a single hit item
* added function input_field_by_tag_and_mask() to look up a particular
input_field_config by tag and mask; this makes it possible to easily
get the port default value or other information as necessary
is either DEVICE_START_OK or DEVICE_START_MISSING_DEPENDENCY. The latter
should be returned by a device if there is another device it depends on
which hasn't been started yet. Added new flag in the device interface to
indicate whether a device has been started.
Changed laserdisc interface to explicitly specify the screen and sound
devices it should route to. Drivers no longer have to manually call
laserdisc_vsync(). Instead, the laserdisc code connects up to the routed
screen device and works based on that screen's VBLANK timing. Removed
all existing calls to laserdisc_vsync().
Changed laserdisc behavior so that it completes the previous video read
and initiates the next read at the end of VBLANK instead of the beginning.
This gives player logic time during VBLANK to alter the slider position
prior to fetching the next frame.
Added new laserdisc callback for vsync begin and changed the update
callback to be called at the end of VBLANK. Also added functions to set
the slider speed, advance the slider, and directly control the video/
audio squelch. In addition, there is a new status function to get the
slider position in general terms.
Added parameter to the VBLANK callbacks supported in emu/video.c. Updated
all callers to provide a callback value.
Fixed bug that would cause watchpoints to trigger if you had a memory
window open to the watchpoint address.
Further updates to the PR-8210 ROM simulation. Still not quite there but
the system is much better understood now. Added layout to the PR-8210
which displays the state of the front-panel LEDs.
- Some corrections to the memory map.
- Added proper working RAM.
- Added Dallas DS1220Y NVRAM.
- Added output port.
- Added lamps layout.
- Added complete inputs.
- Changed description to "Scacco Matto / Space Win" since the default game is Scacco Matto.
You must enter the service mode and change graphics in order to switch the game.
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Scacco Matto / Space Win [David Haywood, Roberto Fresca]
now have their tags auto-prefixed with the device's tag. This allows for
multiple instances to be present. For example, the PR-8210 laserdisc player
has a CPU with a tag of "pr8210". When it is included as a device by a
driver, the driver may tag the device "laserdisc". The resulting final
CPU tag name will be "laserdisc:pr8210". Also updated the debugger
expression engine to support names with embedded colons.
Added warnings to ensure that tags used for CPUs, sound chips, regions, and
devices follow some basic rules: they should be less than 12 characters long,
be all lower-case, and only contain letters, numbers, underscores, or dots
(no spaces). This is to ensure that they can be used properly in debugger
expressions and don't get too long or unwieldy to type (even 12 chars is a
bit long).
* Because twinadv (snowbros.c) had a crash introduced in 127u1, I wasn't able to test the results of the automated IO_MAP merge operation. It's a simple map though, so I don't expect any difficulties. I apologize for not having the time to fix the bug myself (mantis : 02184).
also the default state, obviating the need for a default value. Removed
the "default" attribute as a result. Switching from "Off" to another
state first executes the "on" script followed by the "change" script.
Switching to "Off" from another state executes the "off" script. While
not off, the "run" script is executed each frame.
device to provide a set of ROM regions to be loaded along with the game
ROMs. It is expected that most regions defined for devices will use the
ROMREGION_LOADBYNAME flag to enable the ROMs to live in a central location.
Added new device interface selector: DEVINFO_PTR_MACHINE_CONFIG. This allows
a device to specify a partial machine driver which is appended to the end of
the machine driver for any game using that device. The intention for this is
to allow devices which have their own BIOS logic to specify CPUs and other
characteristics common to all systems using the device.
Added new ROMREGION flag: ROMREGION_LOADBYNAME, which means that if the ROMs
in that region are not found in the usual driver files, then the name of the
region will be used as a driver filename for loading.
Extended the ldcore interface structure to allow each player type to provide
its own ROM region and partial machine driver.
Moved preliminary PR-8210 emulation code from ldplayer.c to ldpr8210.c. It
is currently disabled behind the EMULATE_PR8210_ROM compile time flag.
- Better structure and organization.
- Added Super Gran Safari.
- Added improved lamps layout to Super Gran Safari and Magic's 10.
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Super Gran Safari [Roberto Fresca]
removed snkwave since it doesn't seem to be used and might not be present on the pcb at all
general driver cleanup, bringing it in line with snk.c but not merging it since somthing doesn't quite fit
New clones added
----------------
The Great Ragtime Show (Japan v1.3, 92.11.26) [Stefan Lindberg]
Renamed the roms for the Japanese v1.5 from kh_0x-1 to kh_0x-2 like the other v1.5 sets. This new earlier version is the "true" kh_0x-1
Slight update to info... the PAL "VF-00" wasn't mentioned. PCB picture is at http://arcade.ym2149.com/
This rom set is not working. Bad dump??? Slightly different encryption??? Emulation issue???
Subject: Update to MC146818 RTC
Hi,
Here's a small patch to the MC146818 code, which gives a basic
implementation of the "update ended" interrupt flag.
The code is based on the behaviour of the Aleste 520EX (Russian Amstrad
CPC clone) BIOS, which periodically (about 7 or 8 times a second) checks
the flag to see if the date and time display on the BIOS setup screen
needs to be updated. Without the flag implemented, the date and time
are static on the setup screen, or if the time hasn't been initialised
(blank NVRAM) it is blank.
The BIOS function that does this basically checks bit 4 of register
0x0c, and if 0, ends there, otherwise it will read register 0x0b, sets
bit 7 of the result and writes it back to register 0x0b (presumably,
this resets the interrupt flags). Then it continues on to the display
refresh function.
(Disassembly attached)
Subject: a few patches
Hi,
enclosed please find a few patches that finally conclude my
input_port cleanups. I will still probably change some bit
here and there, but there will be no more massive changes
which could collide with current developments.
Notice that, after applying these patches, indexed input reads
remain only present in CPU interfaces (e.g. all the yamaha
interfaces when the sound cpu is used to read inputs) and no
more 16bit/32bit indexed read are present at all in MAME or
MESS source. Therefore, you may consider the removal of
input_port_N_word_r & input_port_N_dword_r, if you think you
don't need them anymore.
More in detail:
* patch01.diff & patch02.diff: conclude the cleanup for
drivers W -> Z
* primrage.diff: changes the start buttons with input buttons
in primrage, as per the test mode (no start button is reported)
and the control panel (see
http://www.mameworld.info/ubbthreads/showthreaded.php?Cat=&Number=161107 )
* drivedge.diff: makes drivedge ports fully 32bit and removes
the protection bit (which seems not to be used in this game, or
at least not in the port where it was tested since at least MAME
0.100)
* duplicate.diff: introduces a PORT_CUSTOM which returns a tagged
input (like a input_port_read). this could be useful for those
games which require to read the same 8bit (resp. 16bit) input in
both the upper and lower half of a 16bit (resp. 32bit) port. you
can see its use for this purpose in the modified drivers (fuukifg3,
dreamwld, cojag etc.)
Regards,
Fabio Priuli
fixed palette decoding of early SNK games (from marvins to athena + fitegolf). The least significan bits were assigned incorrectly.
merged marvins.c into snk.c, with all resulting fixes (removed hacks, correct shadows, scroll offsets etc)
This contains three different patches:
20080829.patch
Introducing the running_machine* parameter in a few more places. Next
step would be to make the execute_* function aware of it, if that's
OK. Also used the machine parameter in memory.c were it's available.
20080829_1.patch
The already discussed and probably being rejected removal of
dreprecat.h from debugger.h. I think this is a low-risk patch (we had
worse cleanups) and it lowers the risk of new code using deprecated
function beign introduced in MAME/MESS, because there is no invisible
inclusion of deprecat.h anymore (I think one driver - kofball.c - got
it with deprecated code).
20080829_2.patch
The last Machine -> machine conversion I had sitting in my local
tree. I know the proper way is to turn them into devices, but I still
haven't looked into that.
Each player now gets its own source file, along with new hooks
which enable more precise control over the behavior. Updated the
PR-8210 and LD-V1000 implementations to the new spec. Other
players will come online shortly.
Changed scan behavior so that it requires a constant stream of
signals to continue scanning. Updated ldplayer accordingly.
- Added irqs ack
- Implemented raster irq
- Fixed coin2 and service input not working during the game
- Added watchdog
- Fixed visible area
- Added video enable and irqs enable flags
renamed ikaria to ikarinc (for Ikari No Continues)
ikari is the JAMMA board, with conitnues
ikaria is the non-JAMMA board, with continues
ikarinc is the non-JAMMA board, without continues
New clones added
----------------
Ikari Warriors (US) [Nicola Salmoria]
Since I touch up a couple of things and test each driver after the automated merge, it still takes a few minutes for each file. More IO_MAP merges will trickle in over the next few days.
It's likely not worth writing every driver in the whatsnew.txt, since there will be ~100.
- Added Magic Joker.
- Fixed the 3rd background offset to Galaxi.
- Remapped inputs to match the standard poker games.
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Magic Joker (v1.25.10.2000) [Roberto Fresca]
* Adds MCS48_INTERNAL_ROMBANK define to header
* Drivers which need to control the ea line have to initialize banking for internal/external rom
This is not yet optimal but works as expected with existing drivers and modified mario.c
(not worth putting in whatsnew)
Please note, this does touch mario.c and dkong.c (two drivers which are currently undergoing modifications), but it does so unobtrusively. I also asked the proper parties before committing.
All games are tested and working after this patch.
* MB8884 is a I8035 ==> 12 addr, no internal rom map
* EA line high: external access - this is "default"
The whole EA implementation is as Aaron named it, cheeky. EA=1 external rom access, EA=0 internal rom access.
But all variants are treated the same, i.e. for i8035, MB8884, I8039, the external rom is used in the same
way as the internal.
These ports are actually ports which sink current on logical 0. With a logical 1, they are in high impedance mode and may be read. The high impedance is treated as logical 1 by TTL gates connected to them.
Fixed bug in my recent DISCRETE_MIXER update.
Note: the DISCRETE_MIXER bug caused most of the speed increase of its optimization and caused some games to crash. Donkey Kong is now at 14% faster on my machine then when I started. Better then nothing.
For those keeping score dkong was at 268% on my computer before I started optimizing. It now runs at 342%. The 555 and mixer changes also speed up just about every current discrete game.
- Added Magic's 10 version 16.15
- Remapped all inputs to match other poker games.
- Added a missing input to Magic's 10 games.
New clones added
----------------
Magic's 10 (ver. 16.15) [Roberto Fresca]
Subject: few more patches
Hi,
enclosed please find a few patches:
TV_1.diff -> TV_4.diff: clean up of input ports for drivers starting with T,U,V
eeprom.diff: some remaining eeprom_bit_r made CUSTOM_PORT
stv_fix.diff: a small missing bit in my previous stv fix for bug 650. this patch assumes the previous has been applied and removes duplication of button 4 also from batmanfr (somehow I think I sent an outdated version of stv.diff previously)
That's all folks
Regards,
Fabio
Sent: Monday, August 25, 2008 8:16 AM
Subject: [patch] Remove useless backslashes
Hi mamedev,
I've been using pmd 4.2.2 to analyze the MAME codebase for duplicate
code, and it's C parser complains about useless backslashes and
dangling defines in #if...#endif sections. Here's a patch that fixes
this, and additionally fixes one real bug, a string in djmain.c was
malformed, it's curious it compiled.
~aa
Sent: Monday, August 25, 2008 1:45 AM
To: submit@mamedev.org
Subject: Stepper motor changes
Updated stepper motor code to use a MAME-style config interface, rather
than a load of setting functions. Changed optic functions to use clearly
defined start and end points. Added standard layout for Starpoint units
used in many machines. Updated all affected drivers.
PS. At one point, I was led to believe that the UPD sound chip would
have
support for its messaging pins added, is this still pending (I have Phil
B's old source here if it's needed). Such support would prove very
useful
for AGEMAME as many of the drivers in that that use that chip rely on it
for timing.
Subject: another small revised patch
After Fujix's new findings, I realized that the coinage settings
for ckongg were still not completely correct after my previous
patch galaxold.diff. The attached new patch (diff'ed from clean 0.127)
fixes the Coinage dips at last. Sorry for the possible confusion.
Regards,
Fabio
Subject: more patches
Hi,
enclosed please find the following patches:
spaceinv.diff : this is an important patch. Please revert (if applied)
my previous fix to bugs 2143 & 2144. It was wrong. This is the correct
fix for those two bugs and many other issues not reported on MT (e.g.
spaceatt, spaceat2 not starting because tilted, missing dips in many
invaders clones etc). Basically, in 8080bw.c all the "DSW0" input ports
should have been "IN2" for invaders_map to work correctly, and no
additional "IN2" is necessary. After this fix, you may want to change
all the "IN2" occurrences 8080bw.c and in mw8080bw.c with "DSW" since
they mostly are dips. But the latter is a cosmetic change, so it's up
to you decide if it's worth or not (the patch leaves "IN2").
avgdvg.diff : this correctly fixes avgdvg_done usage without using a
parameter, but using IPT_ACTIVE_LOW where needed (I'm a bit ashamed
because I should have thought to that since the beginning).
galaxold.diff : this changes ckongg coinage inputs to fix bug 2154.
Notice anyway that coinage settings in dips do not correspond to the
numbers which appear on screen. This is probably due to the conversion
to galaxian hardware (e.g. it's shown the value of coin2, but in ckongg
there is no coin2 at all, so the appearance of the coin 2 value has no
meaning). Notice also that an unused dips sets the possibility to play
in 2 or not. I defaulted this to 1 player because setting "2 players"
automatically gives 2/4 credits with a single coin, which I don't think
it was the default back then ;)
However, perhaps ckongg is worth further analysis when it will be
updated to the new galaxian driver.
stv.diff : this patch fixes the longstanding bug 650 (duplicated P1
button 4). After testing all sets which reach the test mode, I found
out that only batmanfr uses the button4 in port "P1", while all other
games with more than 3 buttons use the one in "EXTRA". Therefore I made
the "P1" 4th buttons a specific batmanfr input.
patch01.diff, patch02.diff, sys1.diff : these patches simplifies input
ports in the remaining driver starting with S (plus a few small changes
to other drivers I forgot previously), using PORT_INCLUDE, AM_READ_PORT
& converting 'fake' 8bit ports to full 16/32bit ports where suitable
Let me know if something fails to apply, or if there is any other problem
Subject: Profiler related #2 (v2)
Hi, this a revised version of a patch I sent yesterday.
This one is much more cleaner, and the speed improvement is now significant
enough to come out of the profiling noise.
More over, this one compiles correctly... ;-)
Best regards,
Christophe Jaillet
Shares the memory with the c75.
Renames the c75 region to c7x from user4.
Implements the c75 reset/halt control.
Implements the irqs more correctly.
[From OG]
Subject: fix for MT 2135
This bug dates back to the introduction of the world parent set of rtype.
Finally spotted and (easily) fixed in the attached patch.
Regards,
Fabio
mechanism; instead, you must access the sliders via the main menu. While in
the menu, you can use the ~ key to turn off the menu display and leave only
the bar display, in order to see more of the screen.
* removed redundant and unused definitions from header file
* renamed constants and functions to be MCS48* prefixed
* re-verified all opcode behaviors and timing
* changed illegal opcodes to count 1 cycle to avoid infinite loops
* changed EA behavior so that it is a push from the driver instead of a pull on each opcode fetch
(this may change further in the future).
* reimplemented IRQ generation and timer behavior according to documentation
* updated all drivers accordingly
* fixed several uses of PULSE_LINE, which no longer works
While this isn't 'free' as tilemap_set_palette_offset() is (when the offset changes, the pixmap cache needs to be invalidated), it helps removing some redundant code from drivers.
Updated snk.c and snk68.c to take advantage of the new function.
Added 1:1 fallback if surface creation fails at prescale values. Changed
prescale logic to create prescale target surfaces as ARGB for YUY2
sources. Forced the use of render-to-texture over StretchRect for YUY2
sources.
Register access is still performed using direct memory accesses,
but the pointers are fetched through the memory system. Now you can
see i8039 RAM in the debugger. Added internal memory maps of the
appropriate size so that drivers don't need to declare this RAM.
Added a number of variants from the MCS-48 family as it was not
clear which variants had what capabilities. All documented variants
now have internal memory maps for internal ROM and RAM. Removed
memory maps from drivers using embedded ROM/EPROM/OTPROM since
they are defined by the core now.
Added some initial logic to boot and run the PR-8210 ROM (i8049)
in ldplayer.c. Currently this is disabled behind a compile-time
switch. Once this is working, the plan is to incorporate this into
the existing PR-8210 emulation, but we're not there yet.
array is involved, it seems to think it is not a constant expression.
Added MDRV_DEVICE_CONFIG_DATA32_EXPLICIT() macro which takes an explicit
size and offset. Changed MDRV_DEVICE_CONFIG_DATA32() to be built off of
this macro. Added MDRV_DEVICE_CONFIG_DATA32_ARRAY() and
MDRV_DEVICE_CONFIG_DATA32_ARRAY_MEMBER() which do explicit computations
of the offset to work around MSVC's problems.
Replicated these changes for DATA64 and DATAPTR macros. Updated latch8.h
to use the new macros.
Added gun emulation for judge dredd.
Fixed judge dredd ide emulation when building with visual studio.
Mapped primal rage 2 inputs
Mapped player 3 & 4 inputs for 1 on 1 government, these are now the default with the 6 button inputs only mapped for games that need them.
Converted AT28C16 to a device.
Added preliminary support for devices to load/save nvram.
New games added or promoted from NOT_WORKING status
Super Football Champ (Ver 2.5O)
Super Football Champ (Ver 2.4J)
Magical Date / Magical Date - dokidoki kokuhaku daisakusen (Ver 2.02J)
Fighters' Impact (Ver 2.02O)
Judge Dredd (Rev C Dec. 17 1997)
Judge Dredd (Rev B Nov. 26 1997)
* renamed MDRV_LATCH8_MASK to MDRV_LATCH8_MASKOUT to clarify meaning
* Added MDRV_LATCH8_NOSYNC to specify which lines do not reed a cpu sync
* Updated drivers
The MDRV_LATCH8_NOSYNC is not used in dkong.c. All latches need synchronization
because at least one line does need a cpu synchronization.
* adds new latch device where appropriate
* increased accuracy since now all main/sound cpu communications are properly latched
* removed quite some code as a consequence
* minor cosmetic edits
8 bit latch interface and emulation
Generic emulation of 74LS174/175, 74LS259 and other latches.
Apart from providing synched latch operation, these
latches can be configured to read their input bitwise from other
devices as well and individual bits can be connected to
discrete nodes.
Please see audio/dkong.c for examples.
Bermuda Triangle / World Wars
removed ROM patches
simulated "turbo front" check
renamed bermudao->bermudaj
clarified the relationship between the four sets
made World Wars a main set instead of a clone of Bermuda Triangle
tliemaps, proper memory maps, inputs, etc.
Date: Thu Aug 21 11:31:19 2008 +0200
Outrun irq fix
The level 6 irq happens only when both irq2 and irq4 line are active,
not when either is, obviously.
02136: cubeqst: from minimal UI cubeqst requires the optional CHD
02127: xymg: The game name should be Xing Yun Man Guan and "Pin Yin:"should be omitted
02138: flamegun: Debugger/Cheat System upper case cpu tag of MAIN doesn't work
02139: In audio/system16.c, there is a reference to REGION_SOUND1
02133: chindrah: The title of Zhong Guo Long?(Hong Kong,V011H) is Dong Fang Zhi Zhu(Hong Kong, V011H)
02126: corrupt CHDs are reported as missing
After an exhaustive analysis to the unknown writes, finally figured out the missing sound device.
- Added sound support to "Poker 4-1" and "Pull Tabs".
- Figured out the output ports. Documented each bit accessed.
- Added button lamps support. Created layouts for both games.
- Switched the 8255 port C to be used as output port.
- Adjusted the coin pulse timing.
- Updated technical notes.
- Splitted the driver to driver + video.
- Final clean-up.
Ikari Warriors, Victory Road
removed ROM patches
simulated "hard flags" behaviour
proper memory maps
fixed ikarijp color test
renamed dogosokj to dogosokb and loaded the correct palette PROMs
inputs, dip locations, etc.
removed NO_COCKTAIL flag since these games don't have a flip screen dip switch
02035: gwarb: Guerrilla War bootleg doesn't need a rotary joy
00869: ikari: The title screen and high score screen do not have a black background, as MAME displays.
New clones added
----------------
Ikari Warriors (US) [Corrado Tomaselli]
TNK3, Athena, Fighting Golf, Country Club
converted to tilemaps
removed hacks
proper memory maps
screen flip / cocktail mode support
dip locations
better implementation of sound CPU communication
hooked sound cpu interrupts to YM chips
fitegolf hax 1xYM3812, not 2xYM3526
Subject: few patch based on u5
Hi,
since it seems there will be one more update in this cycle, it is probably
better to submit these patches. Hopefully, not too many changes have been
done to the source and these will apply cleanly. Let me know if I have to
re-submit any of the patches.
content of the zip
* Ndriv.diff, OPQdriv.diff and RSdriv.diff: clean up of input ports in drivers
N->R and partially S. as usual AM_READ_PORTs, conversions to full 32bit inputs
where suitable, CUSTOM_PORTs for eeprom bits etc.
* cps1.diff: small clean up of the inputs in cps1.c. In particular, I exploited
a few port_include (modeled on cps2.c) and added specific inputs for sf2 hacks
so that I could simplify input readings in video/cps1.c. Also, I added the 3rd
buttons to games which test it in Service Mode even if they don't use it in game:
if the game code tests for them in the service mode, they were supposed to be
present...
* deco.diff, pgm.diff, psikyo.diff, nbmj.diff, jaleco.diff: clean up for
specific large drivers
* other.diff: some usage of PORT_CUSTOM that I missed to implement previously
Regards,
Fabio Priuli
Before this patch a:
cpunum_set_input_line(5, ASSERT_LINE);
cpunum_set_input_line(3, ASSERT_LINE);
cpunum_set_input_line(3, CLEAR_LINE);
loses the state of line 5. This patch fixes it by adding an explicit
but optional "virtual irq line" support to the 68k interface.
Fix m68k interrupt handling by some drivers.
Clearing the NMI line to clear all the IRQ lines worked, but it just
doesn't make sense. Now that the irq lines are really independant,
the handling can be simplified.
Subject: [patch] fd1089 external keys
Hi mamedev,
The attached patch moves the fd1089 decryption keys out of the source
of MAME and into the ROM files. Nicola suggested this would now be
reasonable, so long as the incomplete ones were marked with BAD_DUMP.
~aa
Subject: [patch] More reset/multisession cleanup
Hi mamedev,
This patch eliminates more cases of .data objects, in an effort to
make more drivers multisession/reset safe. The changes should not
change the first time run behavior at all, except perhaps the ygv608.c
change, which had a suspicious use of a static rectangle.
~aa
Currently not working any better then the parent
Restores old Wave Runner (Rev A, Model 2B) as a single non clone game
New clones added
----------------
Top Skater (USA) [Gerald (COY)]
My mail is broken (or I'm not on the list anymore?) so I don't know how the suggestion went down, but given that within the space of a week simply updating the tree completely broke my compile again I *need* these files maintained to develop with if we're going to see accurate genesis emulation in MAME. There's too much to split out of MAME.
I haven't included driver definitions, but the source files at least need to compile or I'm going to go completely bananas.
Subject: Profiler related
Hi,
here is a smalll patch that :
- remove include "profiler.h" to files that do not use profiling function
* emu/machine/laserdsc.c
* osd/windows/video.c
- use PROFILER_USER2 instead of PROFILER_USER1 in mame/video/tx1.c
USER1 was used twice, USER3 once. I guess that USER1 should be used
only once and USER2 used in the 2nd place
- remove unused MACRO in emu/memory.c
Best regards,
Christophe JAILLET
Subject: Various cleanups
A couple of minor cleanups sitting on my disk for a while:
- removed obsolete ENABLE_DEBUGGER occurance
- removed more unprintable characters in SH-2 disassembler
- memset() usage cleanups
- removed duplicated TMS5110 entry in sound.mak
- use machine in uigfx.c where it's already available
Removes bad_dump from WW3 as readme said "most" reads matched the Red Alert sound rom. Also it the read me stated the BPROM also matched the Red Alert BPROM.
Subject: small submission
Hi,
enclosed please find a tiny diff which makes megadriv_vdp_r & megadriv_vdp_w
handlers in megadriv.c non-static (and includes them in megadriv.h).
This small change, while making essentially no difference for MAME, would make
life easier to maintain pico emulation in MESS.
--
From: Fabio Priuli [mailto:doge.fabio@gmail.com]
Subject: fix for MT bug 2115
Hi, enclosed please find a small fix for the typo causing berlwall inputs
breakage. No matter how extensively I test my changes, some typos always
succeed to slip through my cross checks :(
Anyway, this regression is fixed.
--
From: Fabio Priuli [mailto:doge.fabio@gmail.com]
Subject: Fix for MT bug 2114
Hi,
enclosed please find a patch which fixes the red/blue inversion for eolith.c
games. It regressed in 0.124, when the driver it's been converted from bitmap_format_rgb15
to bitmap_format_indexed16 with the wrong palette_init.
Hi there,
Astro Wars (Zaccaria 1980) can be added to the galaxia.c.
The attract mode works and it uses the same hardware and
the rom names/lacations are identical.
The picture shows three screenshots of Astro Wars, the left and middle uses
only one of the gfx roms and the right both.
M*A*S*H
New game NOT WORKING: Astro Wars
* Added roms/unemulated/Irem/iremM10_incomplete.zip as ipminva1 to m10.c
* Marked as GAME_NOT_WORKING
* The roms are all different from ipminvad, one is missing. The game does
enough to see that it is some sort of invaders type game.
* Added roms/unemulated/Irem/ww3_roms.zip as ww3 to redalert.c
* Dumped by Stefan Lindberg
* Please credit Stefan Lindberg as well
* Either redalert is the clone or ww3 is the clone. Redalert has a speech board in addition
to the m37b audio board.
New games marked as GAME_NOT_WORKING
------------------------------------
I P M Invader (Incomplete Dump) [unknown dumper, Couriersud]
New games added or promoted from NOT_WORKING status
---------------------------------------------------
WW III [Stefan Lindberg, Couriersud]
This handler works for both disc-only games and those with overlays.
For disc-only games, the base macro is sufficient. For games with
overlays, an additional set of configuration macros are provided:
MDRV_LASERDISC_OVERLAY - specifies update function, width, height,
and bitmap format of the overlay
MDRV_LASERDISC_OVERLAY_CLIP - specifies the visible area of the
overlay bitmap
MDRV_LASERDISC_OVERLAY_POSITION - specifies default x,y position
MDRV_LASERDISC_OVERLAY_SCALE - specifies default x,y scale factors
The update function provided to MDRV_LASERDISC_OVERLAY is identical to
a normal VIDEO_UPDATE callback, so a standard one can be used. All
existing laserdisc drivers have been updated to support this new
rendering mechanism, removing much duplicated code.
Added the ability to configure the overlay position and scale
parameters at runtime. Added OSD menus to control them. Added logic
to save/restore the data in the game's configuration file.
Added new macros MDRV_LASERDISC_SCREEN_ADD_NTSC and _PAL, which
defines a standard screen with the correct video timing characteristics
and update function for laserdiscs. Updated all drivers to use these
macros instead of defining their own screens.
Added DISK_REGIONS to all laserdisc drivers.
Added DISK_IMAGE_READONLY_OPTIONAL to support games (like Cube Quest)
where the disk is non-essential to the game's operation.
Fixed bug in identifying the custom sound driver for the laserdisc.
Updated ldverify to identify blank regions of the disc for post-
processing.
Fixed rendering 16bpp with alpha using bilinear filters (fixes
screenshots of laserdisc games with overlays).
Included support for parsing .gdi files in chdman. [ElSemi]
Added new driver for Cube Quest. This includes CPU cores for the three
bitslice processors, as well as laserdisc support for the hacked
laserdisc that was used to drive the games.
[Philip Bennett, Joe Magiera, Warren Ondras]
Note that the SHA1/MD5 for the laserdisc will likely undergo at least
one more change before being finalized.
- Moved IRQ handling front-end into recompiled code
- Added TSTM/ANDM/XORM instructions
- Added SH-1 CPU support, including lower precision on MAC.W and locking out SH-2 only instructions
- Simulated the co-processor to pass the initial test.
- All Inputs worked from the scratch.
- Fixed position of tilemap layers.
- Added scroll register preliminary support.
- Fixed Super Pool graphics.
New games marked as GAME_NOT_WORKING
------------------------------------
Hot Slot (ver 05.01) [Roberto Fresca]
Magic Colors (ver 1.7a) [Roberto Fresca]
Subject: cps3 sfiii3 title+linear zoom effect fix
fix the sfiii3's title animation (cps3.c line 1055)
also fix the linear zoom effect that OopsWare didn't improve properly
since 0.122u7(cps3.c line 1168,1189,1190)
i've attached 2 images to show the difference between the priginal and
fixed one~
hope this helps~
Subject: two more patches
Hi,
enclosed please find the following patches
* portM.diff which completes the basic port cleanup in
drivers starting with M. It's mostly conversion of 8bit
-> 16/32bit inputs and usage of AM_READ_PORT in memory maps
(plus a couple of eeprom_bit_r replaced with PORT_CUSTOM
and daitorid_soundstatus_r in metro.c converted to a
CUSTOM_INPUT as well)
* avgdvg.diff converts most of the games checking avgdvg_done()
in inputs to use a CUSTOM_INPUT (which I added to video/avgdvg.c).
avgdvg_done() is still in use in mhavoc.c (which requires some
more changes, so I'll take a look later) and in omegrace.c (which
reads it directly and not through inputs). While at it, I've
also done a small cleanup of inputs in starwars.c and tempest.c.
Regards,
Fabio
Subject: [patch] Collapse timer callbacks
Hi mamedev,
The following patch collapses timer callbacks in some cases to avoid
duplicating code. In the case of crystal.c, it also refactors two DMA
handlers and shuffles the init/reset code around a bit. I noticed
while doing this that h8_itu_read8 is missing cases 0x96,0x97 which is
almost certainly a bug, but I left it alone.
~aa
Subject: [patch] Fix i386 bsr implementation
Hi mamedev,
The i386 cpu emulator will return the wrong result for bsr when the
highest bit is set (0 instead of 15 or 31). The attached patch fixes
this.
~aa
Subject: few more patches
Hi,
enclosed please find a few patches to continue the input port
clean up (and to fix a mistake in the previous submission). In
detail:
* hal21.diff: with my last submission I made a mistake in hal21.c
(I converted it only partially to custom inputs, still returning
1<<5 instead of 1 from the handler). please revert that change
(it was in u4_custom04.diff) and apply this one, to fix the
communication with sound cpu
* clean_new.diff: introduce AM_READ_PORT & c. in drivers starting
with M (only few of them updated, more to come)
* custom_new.diff: improves input handling in mainsnk.c and marvins.c
by using CUSTOM_INPUTs and AM_READ_PORTs
* gaelco3d.diff: converts radilkalb inputs to 32bit inputs (as
they are), removing the need of AM_READ16 for those
* itech32.diff: converts inputs of later games to 32bit inputs and
updates all the occurrences as needed. It also simplifies input
handling by removing special_port_r from most of the maps (replaced
by a CUSTOM_INPUT). Now only drivedge still uses 16bit inputs and
special_port_r, but I'll investigate it later.
* arkanoid.diff: changes mcu reads to CUSTOM_INPUTS (and muxed
inputs as well). Bootleg inputs has been slightly changed as well
to cope with the new implementation of the protection
* irem.diff: this patch changes a lot of input related things in
m10->m107 irem boards. First of all, it moves input definitions from
drivers/m92.h to include/iremipt.h (which was already there, just
a bit unused ;) ) and it removes completely drivers/m92.h (which
only contained those definitions). Moreover, it adds more common
inputs to iremipt.h and starts to use that file in m62->m107 instead
of local #defines. Finally, it adds diplocations to all the games in
m62->m107 which were missing and it implements coinage mode 2 through
dipconditions in the drivers which didn't support it.
I tested as much as I could these changes and I can see no regressions.
Regards,
Fabio
Subject: [patch] Fix 1802 cybrcomm, raveracw, raveracj, raveraja,
ridgerac, ridgerab, ridgeraj, acedrvrw, victlapw: No sound in games
after reloading via the MAME UI
Hi mamedev,
The problem with namcos22 games losing sound when running multisession
is actually an m37710 cpu initialization bug. The attached patch
fixes it, and also collapses all the timer callbacks together as an
unrelated code cleanup.
Note: namcos22 has a lot of uninitialized state, so I wouldn't be
surprised if there are other multisession issues.
Subject: some more input clean-ups
Hi,
attached please find a few patches against u4. These diffs improve
input ports for drivers starting with F->L. In particular: they add
AM_READ_PORT whenever suitable, they make inputs fully 32bit where
needed, they remove indexed input read handlers from INITs, they
replace many read handlers with appropriate CUSTOM_INPUTs.
Additional improvements:
* added dip switches and locations to go2000 (even if they were
partially documented in the source)
* fixed artmagic protection (it used a wrong tag, which probably
I added somewhere in 0.125uX); even if I haven't experienced any
problems due to the bug since the regression now it's fixed
More details on the patches:
* u4_clean01 -> u4_clean07: these are standard changes like the
one I submitted previously (no custom inputs involved)
* u4_custom01 -> u4_custom04: here there are also changes involving
custom inputs (they mainly deal with eeprom reads, but a few were a
bit more interesting); I separated these from the other ones in
case you want to check them more in detail
* itech8.diff: this patch improves ports & their handling in itech8.c.
In particular, it replaces the 'special' handlers with a single
custom input and I would like a confirmation that it was the right
choice in this case.
Patches are independent one from the other and should apply with
no problems. Let me know if this is not the case.
Regards,
Fabio
included by generic components in emu/ and thus should have no
dependencies on the MAME code.
Added new target ldplayer, which is based on MAME but serves as
a standalone laserdisc player for CHDs. Right now only the
Pioneer LD-V1000 is connected, and limited commands are available.
Each player type is a driver, so you specify the player type on
the command-line. The driver then opens the first CHD it finds
in your ROM path and uses that as the laserdisc. The intention is
that you specify the -rompath each time on the command-line, so
a typical approach might be:
ldplayer ldv1000 -rompath j:\mach3
where it will pick up the mach3.chd lurking in your j:\mach3
folder. Several basic commands are supported:
Space = play/pause
Alt = toggle frame display
Left = scan forward (when playing) or step forward (when paused)
Right = scan backward (when playing) or step backward (when paused)
0-9 = enter numbers for search
Enter = execute search to frame
item will be visible but not selectable.
Fixed bug that prevented the cheat engine from working when the
debugger was disabled.
Modified xmlfile.c to accept integer values in decimal or hex. The
default is decimal. Numbers may be prefixed by '#' for decimal
values, or by '$' or '0x' to indicate hexadecimal values. Also
added function xml_get_attribute_int_format() to return the format
of the attribute, so that it can be later replicated.
Updated cheat parser to preserve the format of attribute values
used for cheat parameters and items.
Added support for information-only cheat items, which will be
displayed in the menu but which are not selectable and have no
action associated with them. Empty information-only items are
automatically converted to menu separators.
The structures/names were getting too complex for my macros to handle. They would require hand editing and my computer is too slow to keep re-compiling.
Passes a clean compile.
Removed channels parameter from avcomp decode configuration.
Fixed incorrect test in winwork that led to spinning instead
of using the nicely allocated events we had on hand.
Forced a sound synchronization on each vsync in the laserdisc
playback. This prevents overwriting the tail end of the
buffer which was fouling up the MACH 3 audio decoding.
Removed obsolete size check for uncompressable audio data.
1) convert framebuffer's ram from 8 bit to 16 bit
2) convert dma command from 8 bit to 16 bit
3) convert gfx command from 8 bit to 16 bit
4) implemented all gfx mode: 1,2,4,8,16 bpp
for now the rendering is only 8 bpp
now we can use this gfx chip for adp driver that use 4bpp
streams and a delta-RLE pre-encoding. Added optimized
case for the Y/Cb/Y/Cr video encoding case. Cleaned up
the code.
Updated avcomp.c to use the new huffman.c functions.
Reworked configuration options to allow for both input
and output of naturally aligned data streams. Updated
chdman and laserdsc to use the new interfaces. New
compression gives an additional 3-7% over previous
attempt and compresses the dummy CHDs down significantly.
Marked madalien and madalina as Imperfect Graphics. They are missing an effect. When you shoot an enemy in the dark, the whole screen lights up. Basically the headlights fill the whole screen.
credit Guru, Derrick Renaud
I did not do much to the following files because I did not know the best way to name them.
aicadsp.h
sid.h
sidenvel.h
sidvoice.h
ymdeltat.h
I did not update structures only used in the src\emu\sound\*.c files. They are only used locally in the file so they were not worth the effort.
Credit Guru.
(This completes adding all of Guru's readmes to the MAME source. There remain ~20 readmes that I still need to compare to what's in MAME to see if they have any additional information, but beyond that, this little project is done!)
---------------------------------------------------
Killer Instinct (SNES bootleg) [Tomasz Slanina]
Final Fight 2 (SNES bootleg) [David Haywood, Tomasz Slanina, Kowal]
New games marked as GAME_NOT_WORKING
------------------------------------
Sonic Blast Man TURBO 2 (SNES bootleg) [Corrado Tomaselli]
- General clean up (merged memory maps, inputs, readme's)
- Marked vbowl program rom as bad, patched to not crash (fixes bug 00492)
- Protection emulation / patches, promoting to working:
dbc, xymg, lhba (fixes bug 02027), drgwrld3 (fixes bug 00491), chindrac, chindrah
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Da Ban Cheng [Pierpaolo Prazzoli, Luca Elia]
Xing Yen Man Guan [Luca Elia, Wei Mingzhi]
New clones added
----------------
Zhong Guo Long (China, V010C) [Luca Elia]
Zhong Guo Long? (Hong Kong, V011H) [Luca Elia]
- Pass chip type around and restore Jarek's original behavior for YM2203/YM2610
- Always recalculate attack rate in set_ar_ksr, fixes Megadrive/Genesis "Batman & Robin"
What a PITA. :) I'll have to go back and do A-J to lower case the handlers to match the new structure names I already did.
Sorry Mess and other port developers, but the code should match what is stated on the official WIKI. But don't worry, I don't plan on updating anything but the sound cores.
- Reverse engineering of custom IC's 06B49P, 06B53P & 09R81P.
- Mapped the missing 3x SN76489.
- Measured and traced all clocks on the board.
- Measured and fixed the interrupt system.
- Implemented timings/clocks from custom 06B49P.
- Added sound support. All regular game sounds/musics are working.
- Implemented the ADPCM samples system through 09R81P + M5205 emulation.
- Added pinouts and technical notes about custom IC's 06B49P, 06B53P & 09R81P.
- Added flip screen mode.
- Inverted the order of double-up difficult DIP switches.
(Seems to be the opposite of the indicated in the instruction sheet).
- Changed 'Key In' to be active LOW instead of HIGH (checked in the PCB).
- Complete memory map and ports scheme.
- Created handlers for USART port and co-processor communication.
- Renamed the sets accordingly.
- Updated all notes.
- Cleaned-up the driver.
Please co-credit Grull Osgo.
You may have to do a clean compile, or delete the affected driver object files.
struct C140interface to c140_interface
struct cem3394_interface to cem3394_interface
struct ES5503interface to es5503_interface
struct ES5505interface to es5505_interface
struct ES5506interface to es5506_interface
struct ssg_callbacks to ssg_callbacks
struct gaelcosnd_interface to gaelcosnd_interface
struct ics2115_interface to ics2115_interface
I'll stop until my posted question about chip names and upper case is answered.
FWIW, I first check for variables named name_interface and rename them as name_cofig, so they don't conflict with the new interface names.
struct YMF262interface to ymf262_interface
struct YM2151interface to ym2151_interface
struct YM2203interface to ym2203_interface
struct YM2608interface to ym2608_interface
struct YM2610interface to ym2610_interface
struct YM2612interface to ym2612_interface
struct YM3812interface to ym3812_interface
struct Y8950interface to y8950_interface
struct YM3526interface to ym3526_interface
struct TMS5110interface to tms5110_interface
struct TMS5220interface to tms5220_interface
struct AICAinterface to aica_interface
Added a new Japanese version of Ghouls'n Ghosts.
This could be a hack since, running on a 91634B board, it must have been made at least three years after the initial release of the game. However, if if it's a hack, it's exceptionally well made since all ROM stickers look original and the B-board DAM63B PAL label is printed on the chip.
Also, hack or not, the code alignment of none of the already supported versions matches this one so it appears to at least be based on a new version.
The dip switches need to be checked. The Lives dips, and the two unused dips after those, also change the starting level. This could be further evidence that the game is a hack.
New clones added
----------------
Dai Makai-Mura (Japan new version)
struct CustomSound_interface to custom_sound_interface
struct Samplesinterface to samples_interface
struct SN76477interface to SN76477_interface
struct AY8910interface to AY8910_interface
The algorithm is more complex than it should be, but I haven't been able to simplify it more.
The keys are still embedded in the source. It would now be reasonable to move them to external files; however, for several games we only have partial keys so the files would need to be BAD_DUMP.
memory regions. Extended error codes to report incorrect memory
spaces, memory names, or memory sizes. Added verification callback
to the debugger to validate CPU and memory region names, as well
as verifying that a requested address space exists for a given
CPU.
Added support for oneshot cheats (those with only an "on" script).
They are activated via UI_SELECT in the cheat menu, and pop up a
message when activated. Also added a "Reset All" item in the cheat
menu to reset all cheats back to their default state, and added
support for UI_SELECT on a non-oneshot cheat so that it resets that
cheat to its default value.
Restored previous behavior that allowed popmessage() messages to
overlay menus and other UI.
and reports if no white flags were seen.
Fixed bug in aviio.c which could cause an infinite loop if attempting
to read sound beyond the end of the file.
Rewrote the white flag detection to use a histogram for outlier detection
and peak identification.
+ plus
- minus
* times or mul
/ div
% mod
! not
~ bnot
&& and
& band
|| or
| bor
^ bxor
lt <
le <=
gt >
ge >=
eq ==
ne !=
Changed cheat escaping to automatically escape && & < and <=
to and band lt and le.
Subject: New russian game
Dear Aaron,
thanks to the very kind and good guys at the "Soviet Arcade Games Museum"
(www.15kop.ru), namely Alex and Max; and thanks to Antro (a good friend of
mine), we have a new dump for a previously unknown Russian game: S.O.S. by Terminal.
It works on the same hardware as Konek (already in MAME), it's a simple rom
swap. I still have to chek about PROMs.
A diff file is included, together with roms.
All the best
Antonio (f205v)
Subject: some diplocations
Hi, enclosed please find a patch to add diplocations to the some
drivers which still missed them. The patch assumes my changes to
drivers starting with C,D,E have been applied (port01.diff -
>port09.diff I sent on Aug 1st... there is at least crshrace.c w
hich could fail to correctly patch, due to possibly different tags,
and probably 1 or 2 more... not many, but maybe annoying anyway).
It adds diplocations to the following drivers: combatsc.c, copsnrob.c,
cosmic.c, crgolf.c, crimfght.c, crospang.c (here I also added service
dips to heuksun and bestri, which allowed me to verify locations),
crshrace.c, dambustr.c, darkseal.c, dassault.c, dblewing.c, ddrible.c,
deadang.c
It also adds locations to the following games: ddragon & ddragon2 on
ddragon.c and docastle, dorunrun & dowild in docastle.c
Regards,
Fabio Priuli
From: Fabio Priuli [mailto:doge.fabio@gmail.com]
Subject: to simplify cischeat inputs
Hi,
the enclosed diff has a twofold effect on cischeat.c:
on one side: it adds diplocations to bigrun, scudhamm,
cischeat & f1gpstar
on the other side: it removes the current hacky handling of
f1gpstar coinage dips (check video/cischeat.c to see what I
mean with hacky!) to use conditional ports instead. BUT in
order to do this, I had to add more possible values for the
PORTCOND in iptport.c. The problem is that f1gpstar has a set
of coinage settings when you set the region to JPN or USA and
another one when you set the region to EUR or FRA. To implement
this I added the following self-explanatory new PORTCOND:
ISLARGER (>), ISNOTLARGER (<=), ISSMALLER (<), ISNOTSMALLER (<=).
Only two were really needed to implement f1gpstar dips, but
the other two seemed costless to me while offering even more
flexibility to the PORT_CONDITION macro.
Also notice that the handling of conditional ports in 'TAB>Dip
Switches' menu doesn't work well (in the current source, not
affected by my patch) with contracted expressions like
PORT_DIPUNKNOWN_DIPLOC: the wrong items remain listed in the
UI menu even when you change the condition! If you leave the
DEF_STR( Unknown ) with ON/OFF cases, everything is displayed
correctly in the menu. However, I was not able to track down
what part of code is responsible for this bug.
Regards,
Fabio Priuli
Subject: another small fix
Hi,
with this last patch I hope to have fixed all regressions I could
had introduced with my past submissions. This time it was a small
problem due to my fix to bug 1565 (alleymas duplicated inputs):
the game was unplayable in u3 (even if not reported to MT).
Regards,
Fabio Priuli
Subject: fix for MT bug 2056
I failed to see this wrong tag for almost 2 days!! One would guess that
looking for the cause of coins problems, an handler with the comment "coin
inputs" should have been noticed immediately. I saw it only this morning :(
However, fix in attachment.
Regards,
Fabio Priuli
PORT_START_TAG to PORT_START.
From: Fabio Priuli [mailto:doge.fabio@gmail.com]
Subject: let's say goodbye to untagged input ports ;)
Hi,
enclosed please find a few patches against 126u3 source
* port01.diff -> port09.diff : these patches continues the
cleanup of inputs in drivers starting with C (the remaining ones),
D and E. No ambiguous situations this time, so I guess there should
be no problem with the changes. Improvements include conditional dips
added to dynduke and diplocations for chinagat, chqflag, circus,
citycon, cloak, contra and dynduke
* tag01.diff -> tag09.diff : these patches add tag to EVERY input port
in drivers starting with F->Z. Notice that only tags are added, no
AM_READ_PORT, nor PORT_INCLUDE (and I saw a lot of drivers would need
it ;) ), nor other cleanups contained in the patches above. I'll keep
cleaning input next week, probably, but at least we can definitely
remove the untagged version of PORT_START :) Notice I was able to
compile the source commenting out the definition of PORT_START, so
I guess every occurrence is covered...
- new tag <comment> (within <cheat>) is read and preserved
when saved
- removed variable attribute from <parameter>; it is now
assumed to be 'param'
- added default attribute for <parameter>
Added new variable 'frame' accessible from cheat scripts. This
can be used in the conditional to prevent execution on every
frame, or for other effects (like displaying temporary messages).
Added new variable 'argindex' which is the index when processing
an <argument> with a count attribute greater than 1. Can be used
in expressions like:
<argument count="3">main.pb@(1000+argindex)</argument>
Reinstated the cheat menu. It now displays all loaded cheats and
allows for them to be activated. All known cheat behaviors should
be working now.
* moved a couple of exp(x) from _step into _reset where appropriate
* use tabulated function values for the transfer function in DSS_INVERTER_OSC
==> 40% speed increase in dkong - from 520% to
$ ./mame64 -noautosave -nothrottle -str 30 -video none dkong -nomt -nosleep
Average speed: 722.48% (29 seconds)
tool which walks through either an AVI or CHD capture from a
laserdisc and ensures that there are no anomalies lurking in
the VBI data.
Added new option to chdman, where if you use -createav with
a special filename (either 2:2 or 3:2) it will create a fake
laserdisc files with the equivalent cadence. This can be used
for testing until full captures are available. Most games used
2:2 apart from Dragon's Lair and Space Ace, which were 3:2.
Note that even though these files are essentially blank, they
are Huffman-compressed, meaning that the maximum compression
ratio you will get is 8:1, so they still end up ~5GB.
Moved error strings from chdman.c to chd.c, where they can be
fetched from any caller via the new chd_error_string()
function.
Updated vbiparse to improve Manchester code decoding. It now
assigns a confidence level per bit based on how solid the
data is. Also added a new function vbi_parse_all which parses
the white flag and all three lines of metadata from a
laserdisc frame. It then compares line 17 and 18 against each
other and selects the most likely candidate based on per-bit
confidence and other factors.
Added frame number display to laserdsc.c. It is off by
default, though most players can be configured to turn it on
(not sure if any actually do). It can be manually toggled via
the backslash key during playback.
Commander (MACH 3 hardware). Old laserdisc hacks are now removed.
The code now talks to the standard Pioneer PR-8210 interface. Also
removed hacky "target list" from the MACH 3 ROMs; this information
is now decoded on the fly from the right channel laserdisc audio.
Other Gottlieb cleanups:
- moved sound inputs to audio/gottlieb and included them in
all relevant drivers
- ordered input ports and ROM definitions consistently
Other laserdisc changes:
- changed PR-8210 interface to work consistently for both Gottlieb
and Stern games
- added audio callback mechanism to allow drivers to peek at the
raw audio streams
- extended the VBI parser to be even more lenient
Instead, they are identified by the region they were loaded in. This
generally means one disk per region. get_disk_handle() now takes a
region name in place of an index. Updated all callers to do this.
The SCSI modules in particular posed a challenge to make this work,
so watch out for potential bugs there.
Changed the IDE interfaces to default to choosing the region with the
same tag as the device for its master disk (assuming no slave). Added
support for specifying explicit master/slave disk regions as part of
the configuration, though slave disks are still not supported yet.
Change the laserdisc interface to no longer require a disk number or
a custom sound device. Both are now assumed to be tagged the same as
the laserdisc device. Updated all drivers accordingly.
maps and behaviors according to the schematics. Hooked up coin
counters.
Added new functions cputag_set_input_line() to assert input lines
via CPU tag instead of index.
Formerly known as pokerigs in iqblock.c (wrong driver).
I've renamed it to cpokert and moved it to csk.c.
It works now.
New clones added
----------------
Champion Poker (v200G) [Luca Elia]
now simply requires an AVI file input.
Relaxed VBI Manchester code clocking to allow for a little bit
of wiggle when finding the clock.
Changed laserdisc support to parse white flags and other data
from the VBI data directly, rather than relying on the textual
metadata. Expanded video frame cache to 3. Changed the way
frames are assembled to decrease the likelihood of getting an
interlaced weave. Fixed sound creation so that it is done at
reset time instead of device start, when the sound devices aren't
yet live.
Fixed bug in winwork that caused the creation of single work
items to return NULL, and thus lead to massive memory leaks when
using A/V CHDs.
Removed the Enable line from the DISCRETE_ADJUSTMENT modules. They should never be disabled.
Some before/after speed tests:
dkong - from 203% to 204%
firetrk - from 418% to 429%
phoenix - from 253% to 257%
polaris - from 448% to 476%
(roms in current/j/jingbell.zip)
The background (slot reels) is not emulated properly,
hence it's not playable and marked as not working.
New games marked as GAME_NOT_WORKING
------------------------------------
Jingle Bell [Luca Elia]
Like some other Space games (mosaic.c), it is protected by an MCU
that supplies the addresses to jump to.
I've done some basic simulation that at least shows the service mode.
This is a candidate for decapping / trojaning, or for Nicola to examine
like he did with Mosaic ;-)
Note to Guru: u118 is probably bad, it fails the rom test.
New games marked as GAME_NOT_WORKING
------------------------------------
Quiz Punch 2 [Luca Elia]
to whole functions. The other one I'm not so sure about. Commented
code is usually hilighted differently, making it very easy to spot.)
Hi mamedev,
This set of patches has one aim only, to identify chunks of code that
have been disabled by the use of C/C++ comments, and to disable them
instead by using the preprocessor. The C comment approach to
disabling code isn't safe (embedded comments will trip it up), and the
C++ comment approach isn't elegant (you shouldn't need to touch every
line to disable a chunk of code). Using #if...#endif is preferable
always, excepting perhaps if (0) { ... }.
The patch has three parts. The first only handles cases where full
functions were disabled. The second handles cases where parts of
functions were disabled. The third then tries to restore the
whitespace that the use of comments converted from tabs to spaces via
srcclean.exe. It also cleans up the whitespace in a handful of the
files in areas outside of the original two patches.
~aa
Subject: a few cleanups
This patch contains:
- removal of unprintable chars (newlines) in SH-2 disassembler (I
submitted this in the past nd it wasn't included)
- a few unnecessary checks after malloc_ort_die() calls
- changes two romload.c warnings to use GAMENOUN instead
- adds "deprecat.h" in a few src/mame/drivers files (would be
necessary, if the debugger.h one would be removed)
- cleans up the mame.mak by adding all missing defines and grouping
them based on cpu.mak
- renamed video_exit() to winvideo_exit() for consistency in function
names
files. Removed old option 'cheat_file'.
Updated xmlfile.c to specify the line number for each node, for more
accurate error reporting.
Removed old cheat.c/.h and replaced them with code that will read and
write the new XML-based cheat format using the new cheatpath option
(cheats still need to be enabled in order to load at all). Note that
the cheats are not implemented yet, but they are fully parsed. To test
saving, whenever a cheat file is successfully loaded, it is immediately
written back out as 'output.xml' to the cheat directory for validation.
Game is NOT WORKING because it uses an H8/3644 MCU plus an IDE HDD to emulate the home PS1 version's redbook audio tracks. Cross your fingers for decapping.
Roms are in current/g/galaxi.zip.
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Galaxi [Luca Elia]
The ROL/ROR/SHL/SHR opcodes provide the carry flags typically generated by
almost all CPUs. The RORC/ROLC opcdes map directly to the rotate through
carry of most CPUs as well.
auto-filled by the device manager before starting the device. This
simplifies the auto-binding process for devices.
Added new selector for device-specific ROM regions. Not yet wired
up in the ROM loader.
1) refactors many global and static variables in video\dc.c into a
structure to hold the tile accelerator state
2) textures should be better decoded with more pixel formats
3) adds placeholders for some register probably used by the dimm board
4) corrects a little error in a rom board register (very important, now at
least the gdrom games try to start)
Sent: Sunday, July 27, 2008 2:46 PM
To: submit@mamedev.org
Subject: misc patches
Hi,
enclosed please find a few more patches based on 126u2. It's just a few
minor bugfixes because I'm quite busy and I still have to test the other
changes to tagged inputs (I will send them in the next few days)
In misc2.zip you'll find a few corrections to my previous patches and a
few new bugfixes:
* cachat.diff: It fixes bug 2046. This is a bug I introduced misreading
the default value of the flip dip when updating taito_l.c to use
taitoipt.h definitions. My bad, sorry.
* witch.diff: It fixes another small 'mistake' I introduced when tagging
the ports in witch.c. I searched and replaced a few too many 'port'
occurrences, making some comments unreadable. Again, sorry for the
inconvenience.
* btime.diff: It's an updated version of my previous patch, following
your suggestions. 'Off' comes always first now and manual settings which
do not work on the emulated game are commented out
* skyfox.diff: It fixes bug 2050. Being at it, I also added dip
locations to the driver and updated memory maps to use AM_READ_PORT
* combatsc.diff: It fixes bug 456, solving both the regression which
made disappear all sprites (they were covered by the non-transparent
text layer since 118u1) and the corruption of the graphics in title
screen (due to the wrong drawing order). Mind that bug 400 (scrolling
problems present since 0.79) is not fixed yet, unfortunately.
Regards,
Fabio
From: Atari Ace [mailto:atari_ace@verizon.net]
Subject: [patch] Stricter ADDRESS_MAP checks
Hi mamedev,
The current implementation of address maps is lacking some useful
checks of the initial tokens. In particular, it doesn't validate that
a particular entry doesn't try to define the same handler multiple
times.
The attached patch adds this and some other validations as fatalerrors
in address_map_detokenize, and fixes the affected maps. The errors
generally fall into the following categories.
1. AM_RAM AM_WRITE(...). Should have been AM_RAM_WRITE(...)
2. AM_RAM AM_READWRITE(...). The AM_RAM is a NOP.
3. AM_RAM AM_RAMBANK(...). The AM_RAM is a NOP.
4. AM_ROM AM_ROMBANK(...). The AM_ROM is a NOP.
5. AM_ROM AM_READ(...). The AM_ROM is a NOP.
One peculiar error was in equites.c, where there were two AM_BASE
entries.
~aa
second SH2 for ST-V games.
Fixed buffer overrun in latest SCSP code. Not sure how that ever
worked.
colmns97 still asserts in SCSPDSP, but this happened before the
region change.
- Pre-defined CPU and SND clocks.
- Switched the color system to RESNET calculations.
- Completed the remaining DIP switches.
- Added lamps support. Created a layout to show them.
- Changes on the interrupt system (need to be verified on the PCB).
- Renamed the graphics regions to more descriptive names.
- Corrected the manufacturer's name.
- Splitted the driver to driver + video.
- Updated technical notes.
integer value, regions are now referred to by a region class and
a region tag. The class specifies the type of region (one of CPU,
gfx, sound, user, disk, prom, pld) while the tag uniquely specifies
the region. This change required updating all the ROM region
definitions in the project to specify the class/tag instead of
region number.
Updated the core memory_region_* functions to accept a class/tag
pair. Added new memory_region_next() function to allow for iteration
over all memory regions of a given class. Added new function
memory_region_class_name() to return the name for a given CPU
memory region class.
Changed the auto-binding behavior of CPU regions. Previously, the
first CPU would auto-bind to REGION_CPU1 (that is, any ROM references
would automatically assume that they lived in the corresponding
region). Now, each CPU automatically binds to the RGNCLASS_CPU region
with the same tag as the CPU itself. This behavior required ensuring
that all previous REGION_CPU* regions were changed to RGNCLASS_CPU
with the same tag as the CPU.
Introduced a new auto-binding mechanism for sound cores. This works
similarly to the CPU binding. Each sound core that requires a memory
region now auto-binds to the RGNCLASS_SOUND with the same tag as the
sound core. In almost all cases, this allowed for the removal of the
explicit region item in the sound configuration, which in turn
allowed for many sound configurations to removed altogether.
Updated the expression engine's memory reference behavior. A recent
update expanded the scope of memory references to allow for referencing
data in non-active CPU spaces, in memory regions, and in EEPROMs.
However, this previous update required an index, which is no longer
appropriate for regions and will become increasingly less appropriate
for CPUs over time. Instead, a new syntax is supported, of the form:
"[tag.][space]size@addr", where 'tag' is an optional tag for the CPU
or memory region you wish to access, followed by a period as a
separator; 'space' is the memory address space or region class you
wish to access (p/d/i for program/data/I/O spaces; o for opcode space;
r for direct RAM; c/u/g/s for CPU/user/gfx/sound regions; e for
EEPROMs); and 'size' is the usual b/w/d/q for byte/word/dword/qword.
Cleaned up ROM definition flags and removed some ugly hacks that had
existed previously. Expanded to support up to 256 BIOSes. Updated
ROM_COPY to support specifying class/tag for the source region.
Updated the address map AM_REGION macro to support specifying a
class/tag for the region.
Updated debugger windows to display the CPU and region tags where
appropriate.
Updated -listxml to output region class and tag for each ROM entry.
- Fixed ADPCM decoder to remove bad optimization and match YMZ280B. DC offset is fixed and output quality is higher
- Improved handling of slot monitor and timers B and C
- Simplified interpolation code
- Rewrote core logic, communications, and interfaces.
- Added three parallel memory moves to the disassembler.
- Initial interrupt logic in place.
Plygonet.c updates.
- All communication hacks have been removed.
- Memory maps have been temporarily reverted while new DSP56k cpu core catches up.
Subject: [patch] Conditional code cleanup resubmit
Hi mamedev,
This is a resubmit of a previous patch. The earlier version would not
compile with 32-bit MSVC, due to the fact that its linker required
external dependencies in dead code to be met before dead code
elimination was done, causing linker errors. The proper fix for this
would be to add the necessary dependencies, so I instead simply left
the conditional code in place in winalloc.c and chd.c.
~aa
Original submission email below:
----
Conditionally compiled code tends to bitrot, so MAME should try to
avoid it as much as possible. I sent a patch six months ago to
eliminate conditional code associated with logging, here's another
patch that does more of this. Some notes:
1. drc_ops.c: I couldn't find a LOG_CODE anywhere, so I used if (0).
2. romload.c: I converted all the users of debugload to use
LOG((...)) instead, following the traditional conditional logging
pattern.
3. windows/sound.c: I eliminated the separate sound log and directed
the few outputs to the error log.
~aa
Subject: [patch] .data removals to fix reset/multisession bugs
Hi mamedev,
One nice artifact of properly constifying data structures in MAME is
that it makes it relatively easy to spot a class of reset/multisession
bugs, namely that almost any object in .data is probably in error.
Unless the value is properly initialized in a reset routine the
initial non-zero value can't be relied upon, so there's no need to
have a non-zero value to begin with.
With that in mind, here's a patch to move more items out of .data by
either applying const, removing the non-zero initializer (if its
overwritten by init/reset) or by adding appropriate initialization
code. In most cases I tried to add initialization code to a reset
routine, but in some cases I chose an init routine, possibly leaving a
reset bug intact.
Some interesting bits:
1. tms9900 core. The use of .data to initialize the irq_level wasn't
correct in some cases as the layout of the structure was core
dependent.
2. bfcobra.c. By introducing a VIDEO_START routine a hack in
VIDEO_UPDATE could be removed.
~aa
Sent: Wed 7/23/2008 8:15 AM
To: submit@mamedev.org
Subject: more input patches
Hi,
with the attached diff I started drivers with C. Added all the missing
tags, made more extensive use of PORT_INCLUDE where possible and added
AM_READ_PORT where suitable. I also added dip locations for: cabal,
canyon, cbuster, cclimber, swimmer and guzzler.
Patch for cave.c is separated in case fix for bug 1681 has been submitted
and accepted (changing maybe the driver)
Regards
Fabio
Sent: Tue 7/22/2008 11:30 AM
To: submit@mamedev.org
Subject: Demon's world set 5
Enclosed another revision of Demon's World (my pcb has the jumpers set
to japan).
I renamed the other sets because in my opinion the code needs to be
studied before saying what's older and newer revisions.
Demon's World / Horror Story (set 5)
Sent: Tue 7/22/2008 11:30 AM
To: submit@mamedev.org
Subject: more tags and AM_READ_PORT
Hi,
with the following patches I added tags to all ports (and used AM_READ_PORT
in the memory maps of all the drivers which didn't) in drivers starting with
B. I also added diplocations and factory settings for the games which had
either a manual or a dips listing at crazykong (and to squaitsa, thanks to
a scan from f205v) [1]. A couple of patches are separated from the main ones
because they contain changes which could need additional review
In details:
* diffB01->diffB07 contains standard addition of tags and AM_READ_PORTS to
driver starting with B (a diff each 4/5 drivers).
* bsktball.diff adds diplocations to the driver, but also removes the fake
handling of P1 Start/P1 Button1. Since other games have no separate P1 Start
in MAME (e.g bagman, or joust2 as noticed in the invalid bug 1734), I
personally see no reason to duplicate inputs in this game.
[1] In details, I added locations to: bwidow.c & bzone.c games, bestleag,
blackt96, bogeyman, bombjack, boogwing, bottom9, brkthru, darwin, buggychl,
squaitsa, btime, bnj, lnc, zoar and disco
Sent: Monday, July 21, 2008 2:16 PM
To: submit@mamedev.org
Subject: fix for MT 2029
I noticed only today the silly mistake which produced the bug passing from 126 to 126u1. Stupid typo.
Attached you find the fix.
Regards,
Fabio
Sent: Monday, July 21, 2008 9:16 AM
To: submit@mamedev.org
Subject: Plotting/Flipull pal dump
The pal was dumped by Charles Mcdonald, I enclose the raw dump, pld and
jed files.
It works perfectly as a replacement on the pcb
Sent: Sunday, July 20, 2008 5:46 AM
To: submit@mamedev.org
Subject: last batch of misc. diffs
Hi,
attached please find a few patches to fix some (trivial) mametesters' bug
and a patch to use whenever possible AM_PORT_READ in drivers starting with
# or A. More in detail
* hypreact.diff 'fixes' bug 1572 on MT (not really a bug, in fact), adding
a better description to inputs only used in Joystick Mode
* alleymas.diff 'fixes' bug 1565 on MT. In this case I'd like some dev to
review the patch: the two duplicate inputs in alleymas are properly detected
also in service mode, so MAME is not wrong as is. Nevertheless, inspired to
the common habit of commenting out duplicate coinage inputs, I decided to
comment them out but leaving them in the source for documentation purpose
* bishi.diff fixes bug 1718 on MT. Duplicate inputs did nothing and the new
inputs are now correct both during the game and in Service Mode
* Finally, portA.diff is a bit more interesting and converts a few driver to
use AM_READ_PORTs and tags. Here and there, I also changed a few tags to e.g. s
tress similarities in the handling which were hidden by anonymous "INn" tags
(see atarifb & atarifb4 for instance)
Regards,
Fabio Priuli
Sent: Saturday, July 19, 2008 7:46 AM
To: submit@mamedev.org
Subject: a few bugfixes (or at least proposals of fix)
Hi,
enclosed please find the following patches for bugs currently
in MAME (sorry for the verbose explanations, but I hope it makes
faster the verification and not to steal too much time to the
reviewer)
correct fixes (IMHO)
* harddriv.diff : Fixes a bug introduced in u7 which broke racedrvc,
hdrivair and their clones (due to some tags not being renamed).
Strange no one has noticed this (not even Firevawe when he ran its
regtest before 0.126!), anyway now it's fixed...
* gstrik2.diff : This patch fixes bug 1568. One of the two service
mode keys doesn't give access to the service mode (and in fact it's
not read at all in the input test in service mode). I changed it to
an unknown dipswitch
* atarijsa.diff : This changes the ports #defined in
src/mame/audio/atarijsa.h to be EXTERNAL_INPUTS (and modifies
accordingly the drivers using them). It allows to remove the SWAPPED
version (modified locally in xybots.c) and it allowed me to fix half
of bug 818 (duplicated coins in stunrun). Indeed, stunrun and steeltal
use their own coin input and the jsa ones are not recognized in
Service Mode. Therefore, I removed them through PORT_MODIFY. @Aaron: I
left in COIN3, even if those games do not use it, maybe it can be made
UNUSED as well
proposals:
* leland.diff : I noticed that the SERVICE MODE key in leland.c games
doesn't do anything service related, but it simply adds a coin. This
patch changes them to IPT_COIN3 (because this is the mapping of the same
inputs for offroad and pigout). Actually, it could be an IPT_SERVICE1
(but I don't have currently access to any manual to verify it) or there
could be a different bug in the driver causing the input to be read as a
coin... If one of the latter options sounds more correct to you, please
change the IPT or ignore this patch.
[Note: this was changed to IPT_SERVICE1]
* pc10.diff: This one fixes bug 595, i.e. Start button in playch10.c is
currently mapped to key "2". This could be by design, but it's a bit
confusing since it works the other way around in vsnes.c. If it was by
design and you don't plan to change it, please post at MameTesters so
that we can close the report as Not-a-bug.
* twotiger.diff : This addresses bug 1448. The wheel is completely
centered for any value in the (closed) interval [0x64, 0x69] (goes to
left for 0x63 and to right for 0x70). I've chosen 0x67 because it's in
between, but I'm not sure 100% about the way analog inputs are managed
in the core, so feel free to use another value in that range if it m
akes more sense than 0x67.
That's all. Thanks for the atention
Regards,
Fabio
Subject: [patch] Fix zr107 multisession issues
Hi mamedev,
The attached patch makes the initialization of various Konami PPC
drivers consistent from run to run, hopefully fixing most multisession
issues. I confirmed that this resolves running midnrun multisession,
but it is possible other issues remain.
The patch also moves some allocations from static to dynamic storage.
~aa
Subject: a last bunch of patches
Hi,
attached please find a last block of diffs which completely removes
every explicit use of input_port_read_indexed from src/mame/ (it
remains in the various input_port_N_r, but I'll move to those later
:) ) and fixes a small input bug
Namely:
nbmj_fix.diff: fixes bug MT 479. livegal turns out to use in a
slightly different way the nichibutsu mahjong panel and inputs in
test mode confirms that my change is correct ;)
patch01.diff -> patch03.diff: convert to use tagged inputs and
handlers the remaining drivers (U to Z and a few others)
taito.diff: converts taitoic.c handlers to use tags (this required
some more re-tagging in a few taito drivers, which I overlooked previously)
namcos22.diff: converts namcos22 read handlers to use tags. I have
been very carefully about where each read handler is used (and adopted
read_safe where necessary), so there shall be no problem with this
(despite the complexity of the driver)
mediagx.diff: finally, I re-submit this patch about mediagx.c. Much more
work would be needed to correctly map inputs for this driver, but I fear
is still a bit beyond my current skills. However, from inspection through
the debugger and from error.log, you can notice that the variable
parallel_latched (used to read inputs) takes values 0,...,23 so this diff
does no harm to the driver and allows to remove also the last occurrence
of input_port_read_indexed!
As usual, I tested as much as I could the changes and I expect no
regressions is introduced
Regards,
Fabio Priuli
Subject: 8257dma
Hi Aaron,
Small changes for 8257.
Fixed terminal count stop for autoload mode and added callback function existance check [Miodrag Milanovic]
Regards,
Miodrag
convert between attotimes and a clock tick at an integral frequency.
Changed the 6532 RIOT device into a proper device. Rewrote the
logic to be simpler and leverage the new attotime functions. Changed
the I/O port setters to specify a mask, and changed the I/O port
callbacks to pass in the previous value. Updated tourtabl and
gameplan drivers to use the new device interface.
Converted audio/starwars.c, audio/exidy.c, and audio/gottlieb.c to
use the new RIOT implementation instead of rolling their own.
Began gottlieb.c cleanup. Converted palette calculations to resistor
weights. Corrected video timing. Reduced the number of separate
machine drivers. Fixed incorrect spriteram sizes. Populated full
memory maps for the main CPU and the rev 1 sound board. More to
come.
New games added or promoted from NOT_WORKING status
---------------------------------------------------
Shinobi III (Mega Play) [Tomasz Slanina, Kowal]
- Rearranged decoding behavior.
- Updated code style to MAME standards.
- Tested each single-word opcode with custom ROMs.
(This is a precursor to other major dsp56k changes I have made. I just gotta' get plygonet commanders up and running to do some tests)
- TGP now correctly uses table roms (model1/2 updated accordingly)
- removed FIFO hack on srallyc (game now runs)
- added analog ports reading for model 2A/B/C
- fixed some loading instructions in the TGP. that fixes srallyc automatic transmission bug
Added validity checks to ensure no duplicate sound or CPU tags.
Fixed several duplicate sound tags from the last checkin.
-listxml now outputs the tag names for CPUs and sound chips.
